| Message ID | 20191015070042.92707-1-asomalap@amd.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | akhil goyal |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E7B501D174; Tue, 15 Oct 2019 09:01:04 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-eopbgr740080.outbound.protection.outlook.com [40.107.74.80]) by dpdk.org (Postfix) with ESMTP id 33CC11C43F; Tue, 15 Oct 2019 09:01:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m/P2vbaxmgrWynnKkHiW60GF/m1OC7rlNvAQDQ/cthDiNYlaPj3lQ+ckMKpOSc+7Ny72JgPKKYe1F5yNGCDMGup8nxv32/GrypZmSAQkIuk/75p6Qdt2JnyUcTWHBfd/yeEojw88jEXJTQiM8ZOSmBBC99r0dztXD+FMbNdrdQcBXqIgG7rhd/k0g5yLDTyoa2u62LtqQAu6sp33JBaFNZr2MX8iaNvVe/LxQz+oYqMIxQELsXaEvv2PO3E9sRvFXYWoZPm599+fubk3YQ9kg1Q4hil8cZU6VbIymWCWprWHBpyNs3JEjjh1X9/gtVqDx5q/ig9Pd+n0gWgtqzJ8QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lk8VHfK4WKh4gybbf2gyuMRDrPmsaQxBGlBWPluOmcg=; b=PxA2Ldcmds52W3Kbdin2czMoeDFxqE66anW9vQZnYtpoi7dbJedvKb4zdnZio0aQS3izZjuovHGS/wUmHQ8Wb5I30Zk/BjUyKP/GLTs6dm0ZPpxA34M9KU2eVB0AdeHPMjRQlgcQeKhlFjgtWfjcFaSlWH5tnTF8yUBRgi7+4EK/J/6aTEWi5ogaRX9xjPB3VGHn/JytRNVVtc8EMO2jmjp7lQDV1bSCd0QzE0Zt/vCNpWqZ1gNmmY0JzL6aAl7Vj0rxfUcl5PJbrwTGUwuSTkadrRUQCcfBDRaCbhWg/x1YYbYpZMywlzWoN0Be3Z5/m5Yb8f8ACTrFvUuFJkkXAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lk8VHfK4WKh4gybbf2gyuMRDrPmsaQxBGlBWPluOmcg=; b=0cyZKRswREj7g+A6mA45QBfWjE1NPsLSanRruI7ytmPdDZ2Jq2gGko0eCVUTKFdXKNKYtsMZOADHGR0veopUIRq9qITMDUwaU3ad3nzlV5NMyTo5qmZCa4tJ9TPNaEQGrdJOWgEhrGK9g3Un9H7kg58rq1MiJns34q7jF/Wo5NA= Received: from DM5PR1201MB2474.namprd12.prod.outlook.com (10.172.87.136) by DM5PR1201MB2472.namprd12.prod.outlook.com (10.172.86.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.19; Tue, 15 Oct 2019 07:01:02 +0000 Received: from DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::f3:94a5:9dbc:1fd5]) by DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::f3:94a5:9dbc:1fd5%12]) with mapi id 15.20.2347.023; Tue, 15 Oct 2019 07:01:02 +0000 From: <asomalap@amd.com> To: "dev@dpdk.org" <dev@dpdk.org> CC: "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [PATCH v1 2/6] crypto/ccp: max queue pair and max burst sizes changes Thread-Index: AQHVgyZO1NRs7NlnTk2oZ/dKYCH0CA== Date: Tue, 15 Oct 2019 07:01:02 +0000 Message-ID: <20191015070042.92707-1-asomalap@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR0101CA0001.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:c::11) To DM5PR1201MB2474.namprd12.prod.outlook.com (2603:10b6:3:e3::8) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Amaranath.Somalapuram@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [165.204.156.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1119b74d-a357-48e1-efc6-08d7513d706f x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: DM5PR1201MB2472: x-microsoft-antispam-prvs: <DM5PR1201MB24729836F2527E6AA8166803F8930@DM5PR1201MB2472.namprd12.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:854; x-forefront-prvs: 01917B1794 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(366004)(376002)(39860400002)(396003)(189003)(199004)(305945005)(450100002)(81156014)(1076003)(25786009)(7736002)(81166006)(1730700003)(66476007)(66446008)(50226002)(8936002)(64756008)(316002)(8676002)(4744005)(2616005)(71190400001)(71200400001)(6916009)(2906002)(99286004)(36756003)(66556008)(6506007)(386003)(6486002)(102836004)(14454004)(2351001)(2501003)(256004)(52116002)(6436002)(186003)(486006)(66946007)(66066001)(5640700003)(476003)(5660300002)(26005)(4326008)(3846002)(6512007)(6116002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR1201MB2472; H:DM5PR1201MB2474.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XuI7AxtpxZle1dviuObaKxOPIPFVXtbM+KOxPDy5MIxPPAT9cOybQD+TFQeUL/yVfkB/lSH6ZRqnDlLJUbnehnyutTwAc9OfmO3b79EdAJujS/KJtNHFMrCxSQ4cfsDazo1yqETmwebo8u5X+Ek/UmUQjnc6gSeqpWdz16B7QunnTAeRO/lcuAEkEDQ7LzB8ElSuKpZnqNhSFwuw8yEvX5HB110IAycMhT9ynSfGvNqSQFntopMX6MGPQJmOVx8tNQlU+EECdLd0eetFz71u1dfNCbvKhl2vBVooUtJ6YnquV1qsgTV8W6Sj7+CD4zoT8KyxQO2NYzYqZOTguSNCcg9tnkOvrFaiwugpw6GMmN6PhI413EkK5KBS+n8/t5bu4vFO0f6FqA3/TKzI/vltcp3LNA16K7RUrfEm+cNkWgY= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1119b74d-a357-48e1-efc6-08d7513d706f X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2019 07:01:02.1901 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AfWBCwsPVzLdvUUVsQclvb42eTZQBcW+qT9NvjwsAm+U2HE5ngPC6eJlUWsIclJU0gWnux7/QFvaM1JOSAjeDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2472 Subject: [dpdk-dev] [PATCH v1 2/6] crypto/ccp: max queue pair and max burst sizes changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
[v1,1/6] doc: documentation update
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
| ci/checkpatch | success | coding style OK |
Commit Message
AMARANATH SOMALAPURAM
Oct. 15, 2019, 7:01 a.m. UTC
From: Amaranath Somalapuram <asomalap@amd.com> issue occurred during VPP testing, crash's issue in VPP when ccp used. vpp max burst size is 256, and minimum queue pair required is 3. Cc: stable@dpdk.org Signed-off-by: Amaranath Somalapuram <asomalap@amd.com> --- drivers/crypto/ccp/ccp_pmd_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Title should be: crypto/ccp: update max qp and burst size. > > From: Amaranath Somalapuram <asomalap@amd.com> > > issue occurred during VPP testing, crash's issue in VPP when ccp used. > vpp max burst size is 256, and minimum queue pair required is 3. Please explain the issue appropriately in the description. Does that mean, without VPP, this issue cannot be reproduced. Add a fixes line with the commit which introduces this issue. > Cc: stable@dpdk.org > > Signed-off-by: Amaranath Somalapuram <asomalap@amd.com> > --- > drivers/crypto/ccp/ccp_pmd_private.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/ccp/ccp_pmd_private.h > b/drivers/crypto/ccp/ccp_pmd_private.h > index 7f2979e89..781050c31 100644 > --- a/drivers/crypto/ccp/ccp_pmd_private.h > +++ b/drivers/crypto/ccp/ccp_pmd_private.h > @@ -31,9 +31,9 @@ > #endif > > /**< Maximum queue pairs supported by CCP PMD */ > -#define CCP_PMD_MAX_QUEUE_PAIRS 1 > +#define CCP_PMD_MAX_QUEUE_PAIRS 8 > #define CCP_NB_MAX_DESCRIPTORS 1024 > -#define CCP_MAX_BURST 64 > +#define CCP_MAX_BURST 256 > > #include "ccp_dev.h" > > -- > 2.17.1
We can reproduce this issue in l2fwd by changing MAX_PKT_BURST 32 to 256 -----Original Message----- From: Akhil Goyal <akhil.goyal@nxp.com> Sent: Tuesday, October 15, 2019 4:28 PM To: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>; dev@dpdk.org Cc: stable@dpdk.org Subject: RE: [dpdk-dev] [PATCH v1 2/6] crypto/ccp: max queue pair and max burst sizes changes [CAUTION: External Email] Title should be: crypto/ccp: update max qp and burst size. > > From: Amaranath Somalapuram <asomalap@amd.com> > > issue occurred during VPP testing, crash's issue in VPP when ccp used. > vpp max burst size is 256, and minimum queue pair required is 3. Please explain the issue appropriately in the description. Does that mean, without VPP, this issue cannot be reproduced. Add a fixes line with the commit which introduces this issue. > Cc: stable@dpdk.org > > Signed-off-by: Amaranath Somalapuram <asomalap@amd.com> > --- > drivers/crypto/ccp/ccp_pmd_private.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/ccp/ccp_pmd_private.h > b/drivers/crypto/ccp/ccp_pmd_private.h > index 7f2979e89..781050c31 100644 > --- a/drivers/crypto/ccp/ccp_pmd_private.h > +++ b/drivers/crypto/ccp/ccp_pmd_private.h > @@ -31,9 +31,9 @@ > #endif > > /**< Maximum queue pairs supported by CCP PMD */ > -#define CCP_PMD_MAX_QUEUE_PAIRS 1 > +#define CCP_PMD_MAX_QUEUE_PAIRS 8 > #define CCP_NB_MAX_DESCRIPTORS 1024 > -#define CCP_MAX_BURST 64 > +#define CCP_MAX_BURST 256 > > #include "ccp_dev.h" > > -- > 2.17.1
> > We can reproduce this issue in l2fwd by changing MAX_PKT_BURST 32 to 256 > > Description should have appropriate information explaining what the issue is and What is done in the patch to fix the issue. > > Title should be: crypto/ccp: update max qp and burst size. > > > > > From: Amaranath Somalapuram <asomalap@amd.com> > > > > issue occurred during VPP testing, crash's issue in VPP when ccp used. > > vpp max burst size is 256, and minimum queue pair required is 3. > > Please explain the issue appropriately in the description. > Does that mean, without VPP, this issue cannot be reproduced. > > Add a fixes line with the commit which introduces this issue. > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Amaranath Somalapuram <asomalap@amd.com> > > --- > > drivers/crypto/ccp/ccp_pmd_private.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/crypto/ccp/ccp_pmd_private.h > > b/drivers/crypto/ccp/ccp_pmd_private.h > > index 7f2979e89..781050c31 100644 > > --- a/drivers/crypto/ccp/ccp_pmd_private.h > > +++ b/drivers/crypto/ccp/ccp_pmd_private.h > > @@ -31,9 +31,9 @@ > > #endif > > > > /**< Maximum queue pairs supported by CCP PMD */ > > -#define CCP_PMD_MAX_QUEUE_PAIRS 1 > > +#define CCP_PMD_MAX_QUEUE_PAIRS 8 > > #define CCP_NB_MAX_DESCRIPTORS 1024 > > -#define CCP_MAX_BURST 64 > > +#define CCP_MAX_BURST 256 > > > > #include "ccp_dev.h" > > > > -- > > 2.17.1
diff --git a/drivers/crypto/ccp/ccp_pmd_private.h b/drivers/crypto/ccp/ccp_pmd_private.h index 7f2979e89..781050c31 100644 --- a/drivers/crypto/ccp/ccp_pmd_private.h +++ b/drivers/crypto/ccp/ccp_pmd_private.h @@ -31,9 +31,9 @@ #endif /**< Maximum queue pairs supported by CCP PMD */ -#define CCP_PMD_MAX_QUEUE_PAIRS 1 +#define CCP_PMD_MAX_QUEUE_PAIRS 8 #define CCP_NB_MAX_DESCRIPTORS 1024 -#define CCP_MAX_BURST 64 +#define CCP_MAX_BURST 256 #include "ccp_dev.h"