[v8] eal: make lcore_config private
Checks
Commit Message
The internal structure of lcore_config is no longer be part of
visible API/ABI. Make it private to EAL.
Rearrange and resize the fields in the structure so it takes
less memory (and cache footprint).
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
v8 - update release notes
rearrange to move cpuset to second cache line
doc/guides/rel_notes/deprecation.rst | 4 ----
doc/guides/rel_notes/release_19_11.rst | 2 ++
lib/librte_eal/common/eal_common_launch.c | 2 ++
lib/librte_eal/common/eal_private.h | 24 +++++++++++++++++++++++
lib/librte_eal/common/include/rte_lcore.h | 24 -----------------------
lib/librte_eal/common/rte_service.c | 2 ++
lib/librte_eal/rte_eal_version.map | 1 -
lib/librte_eal/windows/eal/eal_thread.c | 1 +
8 files changed, 31 insertions(+), 29 deletions(-)
Comments
On Wed, Oct 2, 2019 at 9:40 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
> +struct lcore_config {
> + pthread_t thread_id; /**< pthread identifier */
> + int pipe_master2slave[2]; /**< communication pipe with master */
> + int pipe_slave2master[2]; /**< communication pipe with master */
> +
> + lcore_function_t * volatile f; /**< function to call */
> + void * volatile arg; /**< argument of function */
> + volatile int ret; /**< return value of function */
> +
> + uint32_t core_id; /**< core number on socket for this lcore */
> + uint32_t core_index; /**< relative index, starting from 0 */
> + uint16_t socket_id; /**< physical socket id for this lcore */
> + uint8_t core_role; /**< role of core eg: OFF, RTE, SERVICE */
> + uint8_t detected; /**< true if lcore was detected */
> + volatile enum rte_lcore_state_t state; /**< lcore state */
> + rte_cpuset_t cpuset; /**< cpu set which the lcore affinity to */
> +};
There are still changes on the core_id, core_index, socket_id that I
am not confortable with (at this point).
I prepared a series for -rc1 on ABI changes in EAL (that I will send shortly).
I took your patch without the changes on core_id, core_index and socket_id.
We can discuss those changes later, thanks.
On Tue, 22 Oct 2019 11:05:01 +0200
David Marchand <david.marchand@redhat.com> wrote:
> On Wed, Oct 2, 2019 at 9:40 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > +struct lcore_config {
> > + pthread_t thread_id; /**< pthread identifier */
> > + int pipe_master2slave[2]; /**< communication pipe with master */
> > + int pipe_slave2master[2]; /**< communication pipe with master */
> > +
> > + lcore_function_t * volatile f; /**< function to call */
> > + void * volatile arg; /**< argument of function */
> > + volatile int ret; /**< return value of function */
> > +
> > + uint32_t core_id; /**< core number on socket for this lcore */
> > + uint32_t core_index; /**< relative index, starting from 0 */
> > + uint16_t socket_id; /**< physical socket id for this lcore */
> > + uint8_t core_role; /**< role of core eg: OFF, RTE, SERVICE */
> > + uint8_t detected; /**< true if lcore was detected */
> > + volatile enum rte_lcore_state_t state; /**< lcore state */
> > + rte_cpuset_t cpuset; /**< cpu set which the lcore affinity to */
> > +};
>
> There are still changes on the core_id, core_index, socket_id that I
> am not confortable with (at this point).
>
> I prepared a series for -rc1 on ABI changes in EAL (that I will send shortly).
> I took your patch without the changes on core_id, core_index and socket_id.
Why, please be more precise.
Do you expect to support more than 32 bit worth of cores?
On Tue, Oct 22, 2019 at 6:30 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Tue, 22 Oct 2019 11:05:01 +0200
> David Marchand <david.marchand@redhat.com> wrote:
>
> > On Wed, Oct 2, 2019 at 9:40 PM Stephen Hemminger
> > <stephen@networkplumber.org> wrote:
> > > +struct lcore_config {
> > > + pthread_t thread_id; /**< pthread identifier */
> > > + int pipe_master2slave[2]; /**< communication pipe with master */
> > > + int pipe_slave2master[2]; /**< communication pipe with master */
> > > +
> > > + lcore_function_t * volatile f; /**< function to call */
> > > + void * volatile arg; /**< argument of function */
> > > + volatile int ret; /**< return value of function */
> > > +
> > > + uint32_t core_id; /**< core number on socket for this lcore */
> > > + uint32_t core_index; /**< relative index, starting from 0 */
> > > + uint16_t socket_id; /**< physical socket id for this lcore */
> > > + uint8_t core_role; /**< role of core eg: OFF, RTE, SERVICE */
> > > + uint8_t detected; /**< true if lcore was detected */
> > > + volatile enum rte_lcore_state_t state; /**< lcore state */
> > > + rte_cpuset_t cpuset; /**< cpu set which the lcore affinity to */
> > > +};
> >
> > There are still changes on the core_id, core_index, socket_id that I
> > am not confortable with (at this point).
> >
> > I prepared a series for -rc1 on ABI changes in EAL (that I will send shortly).
> > I took your patch without the changes on core_id, core_index and socket_id.
>
>
> Why, please be more precise.
>
I commented earlier that there were integer conversion with the fields
you changed.
core_id is ok, and a uint32_t would be fine, but this does not change the size.
socket_id needs investigation, but should be safe.
I am nervous about core_index, because it is used as a signed integer.
It looks too dangerous to blindly accept this change with the only
reason of saving space.
@@ -23,10 +23,6 @@ Deprecation Notices
* eal: The function ``rte_eal_remote_launch`` will return new error codes
after read or write error on the pipe, instead of calling ``rte_panic``.
-* eal: The ``lcore_config`` struct and global symbol will be made private to
- remove it from the externally visible ABI and allow it to be updated in the
- future.
-
* eal: both declaring and identifying devices will be streamlined in v18.11.
New functions will appear to query a specific port from buses, classes of
device and device drivers. Device declaration will be made coherent with the
@@ -110,6 +110,8 @@ ABI Changes
Also, make sure to start the actual text at the margin.
=========================================================
+* eal: The ``lcore_config`` struct and global symbol are now private.
+
Shared Library Versions
-----------------------
@@ -15,6 +15,8 @@
#include <rte_per_lcore.h>
#include <rte_lcore.h>
+#include "eal_private.h"
+
/*
* Wait until a lcore finished its job.
*/
@@ -10,6 +10,30 @@
#include <stdio.h>
#include <rte_dev.h>
+#include <rte_lcore.h>
+
+/**
+ * Structure storing internal configuration (per-lcore)
+ */
+struct lcore_config {
+ pthread_t thread_id; /**< pthread identifier */
+ int pipe_master2slave[2]; /**< communication pipe with master */
+ int pipe_slave2master[2]; /**< communication pipe with master */
+
+ lcore_function_t * volatile f; /**< function to call */
+ void * volatile arg; /**< argument of function */
+ volatile int ret; /**< return value of function */
+
+ uint32_t core_id; /**< core number on socket for this lcore */
+ uint32_t core_index; /**< relative index, starting from 0 */
+ uint16_t socket_id; /**< physical socket id for this lcore */
+ uint8_t core_role; /**< role of core eg: OFF, RTE, SERVICE */
+ uint8_t detected; /**< true if lcore was detected */
+ volatile enum rte_lcore_state_t state; /**< lcore state */
+ rte_cpuset_t cpuset; /**< cpu set which the lcore affinity to */
+};
+
+extern struct lcore_config lcore_config[RTE_MAX_LCORE];
/**
* Initialize the memzone subsystem (private to eal).
@@ -66,30 +66,6 @@ typedef cpuset_t rte_cpuset_t;
} while (0)
#endif
-/**
- * Structure storing internal configuration (per-lcore)
- */
-struct lcore_config {
- unsigned detected; /**< true if lcore was detected */
- pthread_t thread_id; /**< pthread identifier */
- int pipe_master2slave[2]; /**< communication pipe with master */
- int pipe_slave2master[2]; /**< communication pipe with master */
- lcore_function_t * volatile f; /**< function to call */
- void * volatile arg; /**< argument of function */
- volatile int ret; /**< return value of function */
- volatile enum rte_lcore_state_t state; /**< lcore state */
- unsigned socket_id; /**< physical socket id for this lcore */
- unsigned core_id; /**< core number on socket for this lcore */
- int core_index; /**< relative index, starting from 0 */
- rte_cpuset_t cpuset; /**< cpu set which the lcore affinity to */
- uint8_t core_role; /**< role of core eg: OFF, RTE, SERVICE */
-};
-
-/**
- * Internal configuration (per-lcore)
- */
-extern struct lcore_config lcore_config[RTE_MAX_LCORE];
-
RTE_DECLARE_PER_LCORE(unsigned, _lcore_id); /**< Per thread "lcore id". */
RTE_DECLARE_PER_LCORE(rte_cpuset_t, _cpuset); /**< Per thread "cpuset". */
@@ -21,6 +21,8 @@
#include <rte_memory.h>
#include <rte_malloc.h>
+#include "eal_private.h"
+
#define RTE_SERVICE_NUM_MAX 64
#define SERVICE_F_REGISTERED (1 << 0)
@@ -4,7 +4,6 @@ DPDK_2.0 {
__rte_panic;
eal_parse_sysfs_value;
eal_timer_source;
- lcore_config;
per_lcore__lcore_id;
per_lcore__rte_errno;
rte_calloc;
@@ -12,6 +12,7 @@
#include <rte_common.h>
#include <eal_thread.h>
+#include "eal_private.h"
RTE_DEFINE_PER_LCORE(unsigned int, _lcore_id) = LCORE_ID_ANY;