diff mbox series

[v2] lib/distributor: fix livelock issue on flush

Message ID 20190725090301.4821-1-david.hunt@intel.com (mailing list archive)
State Accepted, archived
Headers
Series [v2] lib/distributor: fix livelock issue on flush |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-Compile-Testing success Compile Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Hunt, David July 25, 2019, 9:03 a.m. UTC 
  From: Liang Ma <liang.j.ma@intel.com>

The Distributor autotest can lock if ran enough times. Worker and
distributir threads get into a livelock situation waiting on each
other.
Issue first encountered by RedHat in Travis CI
https://bugs.dpdk.org/show_bug.cgi?id=316

To repeat:
`while sudo sh -c "echo 'distributor_autotest' |
		./build/app/test/dpdk-test"; do :; done`

The root cause is where we are flushing on exit, and do not wait for
all worker packets to be returned before exiting.
Add a delay on flush so that all worker packets are returned before
completing the flush.

Bugzilla ID: 316
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: stable@dpdk.org

Tested-by: Michael Santana <msantana@redhat.com>
Signed-off-by: David Hunt <david.hunt@intel.com>
Signed-off-by: Liang Ma <liang.j.ma@intel.com>

---
v2 add correct patch attribution
---
 lib/librte_distributor/rte_distributor.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Thomas Monjalon July 29, 2019, 9:22 p.m. UTC | #1 
25/07/2019 11:03, David Hunt:
> From: Liang Ma <liang.j.ma@intel.com>
> 
> The Distributor autotest can lock if ran enough times. Worker and
> distributir threads get into a livelock situation waiting on each
> other.
> Issue first encountered by RedHat in Travis CI
> https://bugs.dpdk.org/show_bug.cgi?id=316
> 
> To repeat:
> `while sudo sh -c "echo 'distributor_autotest' |
> 		./build/app/test/dpdk-test"; do :; done`
> 
> The root cause is where we are flushing on exit, and do not wait for
> all worker packets to be returned before exiting.
> Add a delay on flush so that all worker packets are returned before
> completing the flush.
> 
> Bugzilla ID: 316
> Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
> Cc: stable@dpdk.org
> 
> Tested-by: Michael Santana <msantana@redhat.com>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> Signed-off-by: Liang Ma <liang.j.ma@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c
index 9fa05f69a..21eb1fb0a 100644
--- a/lib/librte_distributor/rte_distributor.c
+++ b/lib/librte_distributor/rte_distributor.c
@@ -542,6 +542,9 @@  rte_distributor_flush_v1705(struct rte_distributor *d)
 	while (total_outstanding(d) > 0)
 		rte_distributor_process(d, NULL, 0);
 
+	/* wait 10ms to allow all worker drain the pkts */
+	rte_delay_us(10000);
+
 	/*
 	 * Send empty burst to all workers to allow them to exit
 	 * gracefully, should they need to.