From patchwork Wed Jul 24 15:16:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Morrissey X-Patchwork-Id: 57035 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78A3F1C1FF; Wed, 24 Jul 2019 17:17:05 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 41F2F1C1FD for ; Wed, 24 Jul 2019 17:17:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 08:17:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,303,1559545200"; d="scan'208";a="160599716" Received: from silpixa00389815.ir.intel.com (HELO silpixa00389815.ger.corp.intel.com) ([10.237.223.111]) by orsmga007.jf.intel.com with ESMTP; 24 Jul 2019 08:17:01 -0700 From: Sean Morrissey To: dev@dpdk.org Cc: thomas@monjalon.net, Sean Morrissey Date: Wed, 24 Jul 2019 16:16:58 +0100 Message-Id: <20190724151658.17768-1-sean.morrissey@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] Revert "eal: fix parsing option --telemetry" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. Reverting this patch as it currently breaks the initialization of telemetry, more investigation is ongoing to fix the issue for the printed error message for unrecognized argument. --- lib/librte_eal/common/eal_common_options.c | 3 --- lib/librte_eal/common/eal_options.h | 4 ---- 2 files changed, 7 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 24e36cf23..512d5088e 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -81,9 +81,6 @@ eal_long_options[] = { {OPT_LEGACY_MEM, 0, NULL, OPT_LEGACY_MEM_NUM }, {OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM}, {OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM}, -#ifdef RTE_LIBRTE_TELEMETRY - {OPT_TELEMETRY, 0, NULL, OPT_TELEMETRY_NUM }, -#endif {0, 0, NULL, 0 } }; diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h index e4c8e25c2..9855429e5 100644 --- a/lib/librte_eal/common/eal_options.h +++ b/lib/librte_eal/common/eal_options.h @@ -69,10 +69,6 @@ enum { OPT_IOVA_MODE_NUM, #define OPT_MATCH_ALLOCATIONS "match-allocations" OPT_MATCH_ALLOCATIONS_NUM, -#ifdef RTE_LIBRTE_TELEMETRY - #define OPT_TELEMETRY "telemetry" - OPT_TELEMETRY_NUM, -#endif OPT_LONG_MAX_NUM };