From patchwork Tue Jun 18 16:16:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 54922 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D02E1C235; Tue, 18 Jun 2019 18:16:57 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 4863F1C220 for ; Tue, 18 Jun 2019 18:16:50 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id t16so7928562pfe.11 for ; Tue, 18 Jun 2019 09:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NfmHrhNMiW6Al7ZFuvaqHgd6S0UgmkcDx6rgSHyEXUI=; b=AcIW7F3Z98R23smpk7FC/pi7Bqfw/P2dB8i4YovYqh4n8EyyO4C6rJ6t7YHlyf7CEa GoZb/Wv89xv6Iiy06AtjcrvKJOucL1zVh/T0xLEm0vg4LBP1c5vxVu4q5Bei5/4Wt8nL MQk0/K4FGZLcWyv4oUEBFlSb9ziG4HcA1bj5YnrFuU1l6RTRFwprvgHyueW+ZwYS4PG6 DKNEG26sbsFnwn4FaBW9V9frjsvwOT9CU3ZRkdn4nnNegfSzvQUNKitG+mA4BZz6cENs oS5g8XRDTPsGeeeboiMmr2PZl/iSOe130oSNQ+u9XHreoWU11E9GOFQfw+67TjIz76R9 vtUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NfmHrhNMiW6Al7ZFuvaqHgd6S0UgmkcDx6rgSHyEXUI=; b=fTJGvzA4APXmi4g/59vDrpLCEw9MVpPhHxqbJKD8OVNpvBCyGpd0YdM42aG30I94UU rL9sypMySmLXzJ3j4L5pRqWmN8T8mtZp4rif2EuzQkN6V1BeOy7j/dzwQ3MFUCwe8ha8 ieV55GHmmyniups98HHlaYsiKVqcVWlEaKTkTwYQh6PTLU0pwxHsIL7/yliA5kOdJiyg rHXt7D7p/dg0YTCfgmN4bKRKwdTQ3Y0T2YNRmEVWkvAmbJDf3tgO8qqCVm0jxfBiQl39 H02MGDYUJ9x+3FZ3kw+SXxSCYBVfbMLOSke2aJL26RAVFMTbmpJQDpSi3BwAx0l1Ix8l bAWg== X-Gm-Message-State: APjAAAWmpq2FuEnAS1RPQf8WXWak98tg/a/unDcI15ocodhBL9Rgb36Q 7/FUHB/YEOrdfgtXUST4gjAuKf+iJ/g= X-Google-Smtp-Source: APXvYqwQgM996CMCwY5kVBFRlxnuKH6zv1SNqLVR0bqIbrnbnWlm6dOyzFnDkkrvtBW3ShziOPrcEw== X-Received: by 2002:a17:90a:d814:: with SMTP id a20mr6053213pjv.48.1560874609186; Tue, 18 Jun 2019 09:16:49 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 3sm15485385pfp.114.2019.06.18.09.16.47 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 18 Jun 2019 09:16:48 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 18 Jun 2019 09:16:32 -0700 Message-Id: <20190618161636.23748-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190618161636.23748-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> <20190618161636.23748-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 4/8] kni: drop unused fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The kni net structure only exists in driver no API/ABI. Several fields were either totally unused or set and never used. The fields in dev_info do need to stay in the ABI but kernel can ignore them. Signed-off-by: Stephen Hemminger kni: drop unused status element Yet another ethtool leftover. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 5 ----- kernel/linux/kni/kni_misc.c | 1 - 2 files changed, 6 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index 21e4b0d92368..f3e6c3ca4efa 100644 --- a/kernel/linux/kni/kni_dev.h +++ b/kernel/linux/kni/kni_dev.h @@ -39,8 +39,6 @@ struct kni_dev { /* kni list */ struct list_head list; - int status; - uint16_t group_id; /* Group ID of a group of KNI devices */ uint32_t core_id; /* Core ID to bind */ char name[RTE_KNI_NAMESIZE]; /* Network device name */ struct task_struct *pthread; @@ -79,9 +77,6 @@ struct kni_dev { /* mbuf size */ uint32_t mbuf_size; - /* synchro for request processing */ - unsigned long synchro; - /* buffers */ void *pa[MBUF_BURST_SZ]; void *va[MBUF_BURST_SZ]; diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c index 1fc5eeb9c8ca..b59cf24c2184 100644 --- a/kernel/linux/kni/kni_misc.c +++ b/kernel/linux/kni/kni_misc.c @@ -346,7 +346,6 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num, kni = netdev_priv(net_dev); kni->net_dev = net_dev; - kni->group_id = dev_info.group_id; kni->core_id = dev_info.core_id; strncpy(kni->name, dev_info.name, RTE_KNI_NAMESIZE);