[v1,9/9] dpaa2: mark internal functions with __rte_internal
Checks
Commit Message
Identify functions in the dpaa2 driver which are internal (based on
their not having an rte_ prefix) and tag them with __rte_internal
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
CC: Bruce Richardson <bruce.richardson@intel.com>
CC: Thomas Monjalon <thomas@monjalon.net>
CC: Akhil Goyal <akhil.goyal@nxp.com>
CC: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 ++--
drivers/crypto/dpaa2_sec/dpaa2_sec_event.h | 4 ++--
.../crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map | 13 ++++++-------
3 files changed, 10 insertions(+), 11 deletions(-)
Comments
Neil Horman <nhorman@tuxdriver.com> writes:
> Identify functions in the dpaa2 driver which are internal (based on
> their not having an rte_ prefix) and tag them with __rte_internal
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> CC: Bruce Richardson <bruce.richardson@intel.com>
> CC: Thomas Monjalon <thomas@monjalon.net>
> CC: Akhil Goyal <akhil.goyal@nxp.com>
> CC: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
I think it's incomplete.
https://travis-ci.com/ovsrobot/dpdk/builds/115329014
On Wed, Jun 12, 2019 at 05:14:53PM -0400, Aaron Conole wrote:
> Neil Horman <nhorman@tuxdriver.com> writes:
>
> > Identify functions in the dpaa2 driver which are internal (based on
> > their not having an rte_ prefix) and tag them with __rte_internal
> >
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> > CC: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > CC: Bruce Richardson <bruce.richardson@intel.com>
> > CC: Thomas Monjalon <thomas@monjalon.net>
> > CC: Akhil Goyal <akhil.goyal@nxp.com>
> > CC: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
>
> I think it's incomplete.
>
> https://travis-ci.com/ovsrobot/dpdk/builds/115329014
>
It appears the travis environment is using the meson build system, while I was
building with the traditional Make system, and meson doesn't yet set
BUILDING_RTE_SDK in its environment. I'll fix that
Neil
@@ -3152,7 +3152,7 @@ dpaa2_sec_process_atomic_event(struct qbman_swp *swp __attribute__((unused)),
}
int
-dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev,
+__rte_internal dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev,
int qp_id,
uint16_t dpcon_id,
const struct rte_event *event)
@@ -3195,7 +3195,7 @@ dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev,
}
int
-dpaa2_sec_eventq_detach(const struct rte_cryptodev *dev,
+__rte_internal dpaa2_sec_eventq_detach(const struct rte_cryptodev *dev,
int qp_id)
{
struct dpaa2_sec_dev_private *priv = dev->data->dev_private;
@@ -7,12 +7,12 @@
#define _DPAA2_SEC_EVENT_H_
int
-dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev,
+__rte_internal dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev,
int qp_id,
uint16_t dpcon_id,
const struct rte_event *event);
-int dpaa2_sec_eventq_detach(const struct rte_cryptodev *dev,
+int __rte_internal dpaa2_sec_eventq_detach(const struct rte_cryptodev *dev,
int qp_id);
#endif /* _DPAA2_SEC_EVENT_H_ */
@@ -1,12 +1,11 @@
-DPDK_17.05 {
-
- local: *;
-};
-
-DPDK_18.11 {
+INTERNAL {
global:
dpaa2_sec_eventq_attach;
dpaa2_sec_eventq_detach;
+};
+
+DPDK_17.05 {
-} DPDK_17.05;
+ local: *;
+};