From patchwork Sat Jun 8 00:20:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 54560 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A4B591BCCF; Sat, 8 Jun 2019 02:20:30 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 574B11BC9C for ; Sat, 8 Jun 2019 02:20:20 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id e5so1396807pls.13 for ; Fri, 07 Jun 2019 17:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1NDmwzHrmZPX3u9NF7x3GeKUDjSznkLaHCXozcreu7g=; b=vYWljLV84nYy7LAjidpKaA1ljLSa85uyLJ1wcWbhXWP+la1iH5qST7h9tFrEdvQc+I lFckYKiyME1upwnYcITsB7zDj2C7HdPRKe/XUmpeplbbHbpctA71hi/e2J5RXMstBJMc uk6fVu1hnRkzJ1HfTJ5hCaWO489VZ4pYTe1Y0O1oZ8AhLcIicmxspf5yWbYaUZWgWi+t kHEu/xbLfiOqQxRsKy2qjeL2lzwepS5GfU//u2QdsINg/kYWcpOYQIxcY+iQMlYMGv91 y9g4biE6UT2fhBMKHpYxuhGfzXQl88jiM4GvNDnpIKFkqpQZmWh5RUt/tDxUDXSEHHZM DyDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1NDmwzHrmZPX3u9NF7x3GeKUDjSznkLaHCXozcreu7g=; b=PrRuzP1BX1491mNoKIKZFt3s0YHFZ6Fejzuoqkio5zIFJyMlgzr7lVnNMW1w59n9kz qux/mHVvVGc0Y47cvklifh0PErQ3EQXzOYCrYbhY5aToaPDccpE7/ZZDl3dWxr30SIWr wYBCH43VRxhCvgETFpeOyjdE+uyEXsxWumef0JMyodRdyvUZ2qgsho5GZtEvtLjFBUP/ gWQkldkhYo53yxdA1nFUVwmrpDtqUHtSnxbus2mwnvbGvIQ75Z/nfAmh+LmmXvgJ6PMW Lh0WGj7sXTWztgfUpKjEIp6sndwcV2r5xmj6PxSwQeMqLvpIvnoKiwBIzzoP2pz74Irl Dwwg== X-Gm-Message-State: APjAAAV805fw17WHHzQiQsLGn5wv18gghrKGhI8hjXKDtJpPsHDB0Rh6 /hMxn7fEqK6iq+j6Xq8Ei/fP5g== X-Google-Smtp-Source: APXvYqzSCCk5NBjVAX/QIob02M1LpxUhqXT3BgS3s9UErHZyCIxOhQy+BYb0rv2varnvd5Fq3M1lsQ== X-Received: by 2002:a17:902:e582:: with SMTP id cl2mr43731522plb.60.1559953219605; Fri, 07 Jun 2019 17:20:19 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n184sm4012463pfn.21.2019.06.07.17.20.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 07 Jun 2019 17:20:18 -0700 (PDT) From: Stephen Hemminger To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Stephen Hemminger Date: Fri, 7 Jun 2019 17:20:02 -0700 Message-Id: <20190608002003.19942-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190608002003.19942-1-stephen@networkplumber.org> References: <20190608002003.19942-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 8/9] kni: return -EFAULT if copy_from_user fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The correct thing to return if user gives a bad data is to return -EFAULT. Logging is also discouraged because it could be used as a DoS attack. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_misc.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c index 6a206d883c0d..a67991066cd9 100644 --- a/kernel/linux/kni/kni_misc.c +++ b/kernel/linux/kni/kni_misc.c @@ -301,11 +301,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num, return -EINVAL; /* Copy kni info from user space */ - ret = copy_from_user(&dev_info, (void *)ioctl_param, sizeof(dev_info)); - if (ret) { - pr_err("copy_from_user in kni_ioctl_create"); - return -EIO; - } + if (copy_from_user(&dev_info, (void *)ioctl_param, sizeof(dev_info))) + return -EFAULT; /* Check if name is zero-ended */ if (strnlen(dev_info.name, sizeof(dev_info.name)) == sizeof(dev_info.name)) { @@ -433,15 +430,12 @@ kni_ioctl_release(struct net *net, uint32_t ioctl_num, if (_IOC_SIZE(ioctl_num) > sizeof(dev_info)) return -EINVAL; - ret = copy_from_user(&dev_info, (void *)ioctl_param, sizeof(dev_info)); - if (ret) { - pr_err("copy_from_user in kni_ioctl_release"); - return -EIO; - } + if (copy_from_user(&dev_info, (void *)ioctl_param, sizeof(dev_info))) + return -EFAULT; /* Release the network device according to its name */ if (strlen(dev_info.name) == 0) - return ret; + return -EINVAL; down_write(&knet->kni_list_lock); list_for_each_entry_safe(dev, n, &knet->kni_list_head, list) {