Revert "net/mlx: support IOVA VA mode"
Checks
Commit Message
From: Stephen Hemminger <sthemmin@microsoft.com>
This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
That commit breaks support for netvsc PMD with MLX SRIOV
on both Hyper-V and Azure.
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
drivers/net/mlx4/mlx4.c | 4 ++--
drivers/net/mlx5/mlx5.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Comments
On Fri, 7 Jun 2019 16:08:41 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> From: Stephen Hemminger <sthemmin@microsoft.com>
>
> This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> That commit breaks support for netvsc PMD with MLX SRIOV
> on both Hyper-V and Azure.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Ping. What happened to this patch?
On Fri, 7 Jun 2019 16:08:41 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> From: Stephen Hemminger <sthemmin@microsoft.com>
>
> This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> That commit breaks support for netvsc PMD with MLX SRIOV
> on both Hyper-V and Azure.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Could one of the MLX maintainers review this. DPDK 19.08 is broken
right now on Hyper-V/Azure.
On Fri, 7 Jun 2019 16:08:41 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> From: Stephen Hemminger <sthemmin@microsoft.com>
>
> This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> That commit breaks support for netvsc PMD with MLX SRIOV
> on both Hyper-V and Azure.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
DPDK 19.08-rc is broken on Azure. This patch which seems to have been
ignored fixes it.
09/07/2019 16:39, Stephen Hemminger:
> On Fri, 7 Jun 2019 16:08:41 -0700
> Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> > From: Stephen Hemminger <sthemmin@microsoft.com>
> >
> > This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> > That commit breaks support for netvsc PMD with MLX SRIOV
> > on both Hyper-V and Azure.
> >
> > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>
> DPDK 19.08-rc is broken on Azure. This patch which seems to have been
> ignored fixes it.
This patch was not ignored. I was waiting for the IOVA changes
to settle down. As a result, the revert will happen because the
type RTE_KDRV_NIC_MLX is not needed anymore:
https://patches.dpdk.org/patch/56314/
However, I don't understand how it is related to netvsc PMD.
Please could you give more details?
11/07/2019 00:18, Thomas Monjalon:
> 09/07/2019 16:39, Stephen Hemminger:
> > On Fri, 7 Jun 2019 16:08:41 -0700
> > Stephen Hemminger <stephen@networkplumber.org> wrote:
> >
> > > From: Stephen Hemminger <sthemmin@microsoft.com>
> > >
> > > This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> > > That commit breaks support for netvsc PMD with MLX SRIOV
> > > on both Hyper-V and Azure.
> > >
> > > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> >
> > DPDK 19.08-rc is broken on Azure. This patch which seems to have been
> > ignored fixes it.
>
> This patch was not ignored. I was waiting for the IOVA changes
> to settle down. As a result, the revert will happen because the
> type RTE_KDRV_NIC_MLX is not needed anymore:
> https://patches.dpdk.org/patch/56314/
The revert is applied on master now.
> However, I don't understand how it is related to netvsc PMD.
> Please could you give more details?
Please did you investigate what happened?
@@ -1142,8 +1142,8 @@ static struct rte_pci_driver mlx4_driver = {
},
.id_table = mlx4_pci_id_map,
.probe = mlx4_pci_probe,
- .drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
- RTE_PCI_DRV_IOVA_AS_VA,
+ .drv_flags = RTE_PCI_DRV_INTR_LSC |
+ RTE_PCI_DRV_INTR_RMV,
};
#ifdef RTE_IBVERBS_LINK_DLOPEN
@@ -2107,8 +2107,8 @@ static struct rte_pci_driver mlx5_driver = {
.remove = mlx5_pci_remove,
.dma_map = mlx5_dma_map,
.dma_unmap = mlx5_dma_unmap,
- .drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
- RTE_PCI_DRV_PROBE_AGAIN | RTE_PCI_DRV_IOVA_AS_VA,
+ .drv_flags = (RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
+ RTE_PCI_DRV_PROBE_AGAIN),
};
#ifdef RTE_IBVERBS_LINK_DLOPEN