From patchwork Wed May 29 15:41:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 53823 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 139321B9A0; Wed, 29 May 2019 17:41:45 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 3D8F91B99C; Wed, 29 May 2019 17:41:43 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 08:41:41 -0700 X-ExtLoop1: 1 Received: from silpixa00399126.ir.intel.com (HELO silpixa00399126.ger.corp.intel.com) ([10.237.223.2]) by FMSMGA003.fm.intel.com with ESMTP; 29 May 2019 08:41:41 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , bluca@debian.org, stable@dpdk.org Date: Wed, 29 May 2019 16:41:29 +0100 Message-Id: <20190529154132.49955-2-bruce.richardson@intel.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190529154132.49955-1-bruce.richardson@intel.com> References: <20190529154132.49955-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/4] build: fix quoting on RTE_ARCH string value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The value for RTE_ARCH needs to be quoted when output to the rte_build_config.h file, so use "set_quoted" rather than "set" when assigning it. Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds") Fixes: 54d609a13876 ("build: add ppc64 meson build") Cc: bluca@debian.org Cc: stable@dpdk.org Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- config/ppc_64/meson.build | 2 +- config/x86/meson.build | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/config/ppc_64/meson.build b/config/ppc_64/meson.build index 7ceae1d39..9246d319c 100644 --- a/config/ppc_64/meson.build +++ b/config/ppc_64/meson.build @@ -4,7 +4,7 @@ if not dpdk_conf.get('RTE_ARCH_64') error('Only 64-bit compiles are supported for this platform type') endif -dpdk_conf.set('RTE_ARCH', 'ppc_64') +dpdk_conf.set_quoted('RTE_ARCH', 'ppc_64') dpdk_conf.set('RTE_ARCH_PPC_64', 1) # overrides specific to ppc64 diff --git a/config/x86/meson.build b/config/x86/meson.build index bb23771b4..1a88e52d9 100644 --- a/config/x86/meson.build +++ b/config/x86/meson.build @@ -31,10 +31,10 @@ endforeach dpdk_conf.set('RTE_ARCH_X86', 1) if dpdk_conf.get('RTE_ARCH_64') dpdk_conf.set('RTE_ARCH_X86_64', 1) - dpdk_conf.set('RTE_ARCH', 'x86_64') + dpdk_conf.set_quoted('RTE_ARCH', 'x86_64') else dpdk_conf.set('RTE_ARCH_I686', 1) - dpdk_conf.set('RTE_ARCH', 'i686') + dpdk_conf.set_quoted('RTE_ARCH', 'i686') endif if cc.get_define('__AES__', args: machine_args) != ''