From patchwork Fri Apr 12 11:01:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gagandeep Singh X-Patchwork-Id: 52697 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AF3F1B140; Fri, 12 Apr 2019 13:02:10 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50078.outbound.protection.outlook.com [40.107.5.78]) by dpdk.org (Postfix) with ESMTP id EF3265F20; Fri, 12 Apr 2019 13:01:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zL/fUD3o6w67QBHFZjUeaBj4pxVV8URfNEB9yX9OI38=; b=bJsGAbyb9XV1ydzYJvuyTHCYP8uf77DzBdTz4OSqjaWvriMezbGaweyD7EYrzWRlfC+NnbL/U3KvzMCR/ELZRs9RwIPfxhksEAO0zLq4qRwW+wmyBsHtJRConXMeCh6XFZfFX56n2IWmWRGaRdjzE/FNyvSVlqYeGtw0ezTrD2I= Received: from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by VE1PR04MB6384.eurprd04.prod.outlook.com (20.179.232.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.18; Fri, 12 Apr 2019 11:01:57 +0000 Received: from VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::f5ad:f178:4c55:13e0]) by VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1792.016; Fri, 12 Apr 2019 11:01:57 +0000 From: Gagandeep Singh To: "dev@dpdk.org" , "ferruh.yigit@intel.com" CC: Gagandeep Singh , "stable@dpdk.org" Thread-Topic: [PATCH v3 13/13] net/enetc: fix crash at high speed traffic Thread-Index: AQHU8R8lmuj+KwCqIkWcM/rKt1jrOQ== Date: Fri, 12 Apr 2019 11:01:57 +0000 Message-ID: <20190412105105.24351-14-g.singh@nxp.com> References: <1555075598-4988-1-git-send-email-g.singh@nxp.com> <20190412105105.24351-1-g.singh@nxp.com> In-Reply-To: <20190412105105.24351-1-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: TYAPR01CA0204.jpnprd01.prod.outlook.com (2603:1096:404:29::24) To VE1PR04MB6365.eurprd04.prod.outlook.com (2603:10a6:803:12a::14) x-mailer: git-send-email 2.17.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=G.Singh@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [92.120.1.68] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 34e92fe4-57c9-4f7e-d600-08d6bf364788 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6384; x-ms-traffictypediagnostic: VE1PR04MB6384: x-microsoft-antispam-prvs: x-forefront-prvs: 0005B05917 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(396003)(376002)(346002)(39860400002)(189003)(199004)(8676002)(8936002)(14454004)(186003)(446003)(478600001)(476003)(11346002)(72206003)(81166006)(81156014)(50226002)(2616005)(66066001)(4326008)(2501003)(26005)(305945005)(2906002)(5660300002)(3846002)(6116002)(486006)(386003)(6506007)(7736002)(102836004)(1076003)(68736007)(4744005)(99286004)(76176011)(14444005)(86362001)(6486002)(25786009)(97736004)(54906003)(110136005)(6436002)(316002)(52116002)(105586002)(6512007)(256004)(71200400001)(71190400001)(106356001)(53936002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6384; H:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Wm0SNBk+b24d798CptJPul2U6WeFJa9584aQ65Tn0XjS8i8gcNVIEuHjtAaSZpUozdEqWsHBVAOqgTCUKwOM21rtMlE2SiTXXzM8b0vQtpW92b0chtXGPYrbWuLhbA1ARplMTLw+yQ6lICvhtZ5kZ1Jr8qCjbBC3FdIEWbZO81ilJVdirhAxXqSvbx/+s9AJlI0ls36TM+X5oPXdgjcHpZYROq9uNyEAtgPaAsA/IDTl4dm08UdrbcFJQZPmF8y6lQz13qSAKO+b2ENQq29hh8G85WIKASOwaM5wITKndFm/VUJ2kwm9NLUaTi9MftO2WJfsHvIkGxMWS1iuJrhICXG1si8pODf8qU+mSG2t7H598HnXnuaYVr9GYr2JTBIBJZL0OO5zF5eoT6m5zBhC/K7GZGo8CmAQM2P4g+unqVU= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34e92fe4-57c9-4f7e-d600-08d6bf364788 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2019 11:01:57.6758 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6384 Subject: [dpdk-dev] [PATCH v3 13/13] net/enetc: fix crash at high speed traffic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On xmit side, there should be a check whether BD ring has free BDs available before transmit a packet to avoid data corruption and buffer leak issue. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: stable@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c index 0ce7dbe..81b0ef3 100644 --- a/drivers/net/enetc/enetc_rxtx.c +++ b/drivers/net/enetc/enetc_rxtx.c @@ -49,11 +49,16 @@ uint16_t nb_pkts) { struct enetc_swbd *tx_swbd; - int i, start; + int i, start, bds_to_use; struct enetc_tx_bd *txbd; struct enetc_bdr *tx_ring = (struct enetc_bdr *)tx_queue; i = tx_ring->next_to_use; + + bds_to_use = enetc_bd_unused(tx_ring); + if (bds_to_use < nb_pkts) + nb_pkts = bds_to_use; + start = 0; while (nb_pkts--) { enetc_clean_tx_ring(tx_ring);