[v2] lib/power: fix governor storage to trim newlines
Checks
Commit Message
Currently the Power Libray stores the governor name with an embedded
newline read from the scaling_governor sysfs file. This patch strips
it out.
Fixes: 445c6528b55f ("power: common interface for guest and host")
Cc: stable@dpdk.org
Signed-off-by: David Hunt <david.hunt@intel.com>
---
lib/librte_power/power_acpi_cpufreq.c | 2 ++
lib/librte_power/power_pstate_cpufreq.c | 2 ++
2 files changed, 4 insertions(+)
Comments
On 29-Mar-19 4:39 PM, David Hunt wrote:
> Currently the Power Libray stores the governor name with an embedded
> newline read from the scaling_governor sysfs file. This patch strips
> it out.
>
> Fixes: 445c6528b55f ("power: common interface for guest and host")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
29/03/2019 18:56, Burakov, Anatoly:
> On 29-Mar-19 4:39 PM, David Hunt wrote:
> > Currently the Power Libray stores the governor name with an embedded
> > newline read from the scaling_governor sysfs file. This patch strips
> > it out.
> >
> > Fixes: 445c6528b55f ("power: common interface for guest and host")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Hunt <david.hunt@intel.com>
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
@@ -147,6 +147,8 @@ power_set_governor_userspace(struct rte_power_info *pi)
s = fgets(buf, sizeof(buf), f);
FOPS_OR_NULL_GOTO(s, out);
+ /* Strip off terminating '\n' */
+ strtok(buf, "\n");
/* Check if current governor is userspace */
if (strncmp(buf, POWER_GOVERNOR_USERSPACE,
@@ -292,6 +292,8 @@ power_set_governor_performance(struct pstate_power_info *pi)
s = fgets(buf, sizeof(buf), f);
FOPS_OR_NULL_GOTO(s, out);
+ /* Strip off terminating '\n' */
+ strtok(buf, "\n");
/* Check if current governor is performance */
if (strncmp(buf, POWER_GOVERNOR_PERF,