From patchwork Wed Feb 13 19:08:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Santana X-Patchwork-Id: 50307 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C3797CE2; Wed, 13 Feb 2019 20:08:18 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 94CCB5F32 for ; Wed, 13 Feb 2019 20:08:15 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC14CE6A68; Wed, 13 Feb 2019 19:08:14 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6BCFF600C4; Wed, 13 Feb 2019 19:08:14 +0000 (UTC) From: Michael Santana To: dev@dpdk.org Cc: Thomas Monjalon Date: Wed, 13 Feb 2019 14:08:12 -0500 Message-Id: <20190213190813.12702-2-msantana@redhat.com> In-Reply-To: <20190213190813.12702-1-msantana@redhat.com> References: <20190213190813.12702-1-msantana@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 13 Feb 2019 19:08:15 +0000 (UTC) Subject: [dpdk-dev] [PATCH 1/2] Enable codespell from config file. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Enable turning on codespell from any of the config files for checkpatches.sh. codespell is a feature by checkpatch.pl that checks for common spelling mistakes in comments in patches. This feature is disabled by default. To enable it one must add the '--codespell' flag to the $options variable in checkpatches.sh. With this change the user can decide to turn on codespell from a config file rather than directly modifying checkpatches.sh Signed-off-by: Michael Santana Reviewed-by: Rami Rosen --- devtools/checkpatches.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 3b03b7ef2..cfe01223b 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -5,6 +5,7 @@ # Load config options: # - DPDK_CHECKPATCH_PATH # - DPDK_CHECKPATCH_LINE_LENGTH +# - DPDK_CHECKPATCH_CODESPELL . $(dirname $(readlink -e $0))/load-devel-config VALIDATE_NEW_API=$(dirname $(readlink -e $0))/check-symbol-change.sh @@ -13,6 +14,9 @@ length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} # override default Linux options options="--no-tree" +if [ "$DPDK_CHECKPATCH_CODESPELL" == "enable" ]; then + options="$options --codespell" +fi options="$options --max-line-length=$length" options="$options --show-types" options="$options --ignore=LINUX_VERSION_CODE,\