| Message ID | 20190111161244.712-1-bluca@debian.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series | build: use static deps of libs for pkg-config libs.private | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | success | Compilation OK |
11/01/2019 17:12, Luca Boccassi: > Dependencies of the RTE libraries were not being added to the > Requires.private field of the pc file since the variable used for > dynamic linking was passed to the related field of pkg.generate. > Use the static one so that dependencies are included. > > Fixes: 57ae0ec62620 ("build: add dependency on telemetry to apps with meson") > Cc: stable@dpdk.org > > Signed-off-by: Luca Boccassi <bluca@debian.org> > --- > split from the other series, it's a stand-alone non-invasive change Applied, thanks
diff --git a/meson.build b/meson.build index 426e0bf3a..d500507c5 100644 --- a/meson.build +++ b/meson.build @@ -81,7 +81,7 @@ pkg.generate(name: meson.project_name(), filebase: 'lib' + meson.project_name().to_lower(), version: meson.project_version(), libraries: dpdk_libraries, - libraries_private: dpdk_drivers + dpdk_libraries + + libraries_private: dpdk_drivers + dpdk_static_libraries + ['-Wl,-Bdynamic'] + dpdk_extra_ldflags, description: '''The Data Plane Development Kit (DPDK). Note that CFLAGS might contain an -march flag higher than typical baseline.
Dependencies of the RTE libraries were not being added to the Requires.private field of the pc file since the variable used for dynamic linking was passed to the related field of pkg.generate. Use the static one so that dependencies are included. Fixes: 57ae0ec62620 ("build: add dependency on telemetry to apps with meson") Cc: stable@dpdk.org Signed-off-by: Luca Boccassi <bluca@debian.org> --- split from the other series, it's a stand-alone non-invasive change meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)