From patchwork Tue Dec 18 10:14:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hideyuki Yamashita X-Patchwork-Id: 49075 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53BAE1BB3E; Tue, 18 Dec 2018 11:16:10 +0100 (CET) Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id 6E3341B43B for ; Tue, 18 Dec 2018 11:16:09 +0100 (CET) Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp [10.107.0.111]) by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id wBIAG8dO027784; Tue, 18 Dec 2018 19:16:08 +0900 Received: (from root@localhost) by gwchk03.silk.ntt-tx.co.jp (unknown) id wBIAG8Vb017223; Tue, 18 Dec 2018 19:16:08 +0900 Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] by gwchk03.silk.ntt-tx.co.jp with ESMTP id VAA17222; Tue, 18 Dec 2018 19:16:08 +0900 Received: from imss05.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by ccmail04.silk.ntt-tx.co.jp (unknown) with ESMTP id wBIAG7Ff016823; Tue, 18 Dec 2018 19:16:07 +0900 Received: from imss05.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by imss05.silk.ntt-tx.co.jp (unknown) with ESMTP id wBIAG7FK016352; Tue, 18 Dec 2018 19:16:07 +0900 Received: from ccmail04 (smtp03.silk.ntt-tx.co.jp [10.107.0.135]) by imss05.silk.ntt-tx.co.jp (unknown) with SMTP id wBIAG702016349; Tue, 18 Dec 2018 19:16:07 +0900 Date: Tue, 18 Dec 2018 19:14:30 +0900 From: Hideyuki Yamashita MIME-Version: 1.0 X-Mailer: Becky! ver. 2.74 [ja] X-CCMail7: CC-Mail-V7.0.2-Client-Relayed Message-Id: <201812181015.wBIAFlYk016726@ccmail04.silk.ntt-tx.co.jp> X-TM-AS-MML: No X-CC-Mail-RelayStamp: CC-Mail-V5.14-Server To: dev@dpdk.org, ogawa.yasufumi@lab.ntt.co.jp Subject: [dpdk-dev] [PATCH] vhost: delete freeing mac_addrs in eth_dev_close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Hideyuki Yamashita When rte_dev_remove is called for vhost, eth_dev_close and rte_eth_dev_release_port is called. Both eth_dev_close and rte_eth_dev_release_port calls rte_free for same data area(mac_addrs) and thus causes double free. This patch fixes this by deleting rte_free for mac_addrs. Signed-off-by: Hideyuki Yamashita --- drivers/net/vhost/rte_eth_vhost.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 42bdfcbd5..b2cda0483 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -1000,7 +1000,6 @@ eth_dev_close(struct rte_eth_dev *dev) for (i = 0; i < dev->data->nb_tx_queues; i++) rte_free(dev->data->tx_queues[i]); - rte_free(dev->data->mac_addrs); free(internal->dev_name); free(internal->iface_name); rte_free(internal);