From patchwork Fri Dec 14 19:35:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 48929 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E6F61B9D1; Fri, 14 Dec 2018 20:36:03 +0100 (CET) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 45DE21B9C8 for ; Fri, 14 Dec 2018 20:36:02 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id i12so3294738pfo.7 for ; Fri, 14 Dec 2018 11:36:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5X4LtEChoOPz5hR0pFSzydjY9m5viVq+SmkUQNnUIFg=; b=g0OSUz1Bbh/oPq7zzXNThpT5vRGwfi35EocdGMjQZDws9bCBxZyxP+OhQKko9dMUQf PVYbJmtshMQLySKMwzG2tsC/w2/H5GSQRSCXcIC8jNiKqzq81+lrLyMVMzJ2lizjMI4f FMD6TybT/aCNSyK9nN6ERZfGQusmsfzDZVU3GG2wFxy4D9SWoCmcQgA5iY/MHk4tXUxl Ar4/TXTgK605kAe1B+a/k8GJaiTkYZ+ZaHyz5Pw5Iqax4oPOsaSftouv98IKYbiv9E33 UjJp5yHVo05gQK/eULa6dDQwrqzxuGy0nHFO6veoseY7hTZpP71Z6KxZ7xa9aJbr5yrd 3x5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5X4LtEChoOPz5hR0pFSzydjY9m5viVq+SmkUQNnUIFg=; b=qCWWJ4ckWfnOSlX78Y6wOBb1iWsemdguZoB6EK5GZDssGfrA5xm+3/DjL7JrHZHx6u HLQa90RRXU1ZdvKhcsVYbmEztJwEfsAADZAToWTh26ntud6+nOysxPiKhFo75xhNvxGE 2OlT9gLrXcHxgMVs7tC2AjJgKguvRD7WZM/6260pz3ykiw1c+fqfU81m5AxF6YDAHQVc nONip1JwrZ9u0oj0rPpeQoHxPFbiPuySGNLGjUqMQYr1z7mYvFG7/pkpX2hoxT/nVZO9 g09ZkUU62Yd4nf1IdPLmy2GDzLIlksWJrb7GVlZb3JBPgUWvzloeiitjqjtsOHyXqXvg C7eQ== X-Gm-Message-State: AA+aEWaAvHa//wAWcnKrJnMtN97yd93KlMIGVdkKxEpwlwSg5plwCJ3Z j72kWtcp1ByV3D2WVjiVPGV1jA== X-Google-Smtp-Source: AFSGD/WIDF3/YAKw8Ia0r7fhknzLrnV/fNMsjyMX+vgFl62lyzr0YYEcyCcHGA9zFKVBV4kkNB4r5A== X-Received: by 2002:a62:5d0c:: with SMTP id r12mr4194121pfb.0.1544816161274; Fri, 14 Dec 2018 11:36:01 -0800 (PST) Received: from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e86sm7629773pfb.6.2018.12.14.11.35.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Dec 2018 11:36:00 -0800 (PST) From: Stephen Hemminger To: gaetan.rivet@6wind.com Cc: dev@dpdk.org, Stephen Hemminger , Stephen Hemminger Date: Fri, 14 Dec 2018 11:35:52 -0800 Message-Id: <20181214193552.12408-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/failsafe: remove unnecessary debug messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The failsafe driver spews messages every time it is polling making debugging other things more difficult. Just remove it. Example: net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm ... Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit --- drivers/net/failsafe/failsafe_private.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h index 7e3189685901..0dfea65c2a3c 100644 --- a/drivers/net/failsafe/failsafe_private.h +++ b/drivers/net/failsafe/failsafe_private.h @@ -399,9 +399,6 @@ fs_lock(struct rte_eth_dev *dev, unsigned int is_alarm) return ret; } } - DEBUG("Hot-plug mutex was locked by thread %" FS_THREADID_FMT "%s", - (FS_THREADID_TYPE)pthread_self(), - PRIV(dev)->alarm_lock ? " by the hot-plug alarm" : ""); return ret; } @@ -413,7 +410,6 @@ static inline void fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm) { int ret; - unsigned int prev_alarm_lock = PRIV(dev)->alarm_lock; if (is_alarm) { RTE_ASSERT(PRIV(dev)->alarm_lock == 1); @@ -422,10 +418,6 @@ fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm) ret = pthread_mutex_unlock(&PRIV(dev)->hotplug_mutex); if (ret) ERROR("Cannot unlock hot-plug mutex(%s)", strerror(ret)); - else - DEBUG("Hot-plug mutex was unlocked by thread %" FS_THREADID_FMT "%s", - (FS_THREADID_TYPE)pthread_self(), - prev_alarm_lock ? " by the hot-plug alarm" : ""); } /*