From patchwork Fri Dec 14 13:18:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 48869 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CDD01BBED; Fri, 14 Dec 2018 14:19:25 +0100 (CET) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id BF56C1BB3B for ; Fri, 14 Dec 2018 14:19:11 +0100 (CET) Received: by mail-lj1-f195.google.com with SMTP id v1-v6so4901916ljd.0 for ; Fri, 14 Dec 2018 05:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yKFLIxxNSAOzYQiuNB9YNQkgCvJCTjgDgBeqiem55UE=; b=vHbUo7D0fIXQdDzb0jWQ5dXGbqkuOuy3Koy4Yxes3UAaSYI28DQJapT/XKEzqPAMA/ oSyAsNmhMTmLisHSd7MsxsIGav3itUOHxJZllyqF9rzZgq2CQOzWgyB3AThcPX1zCdW0 Tw9BvGvw2QJgz17NrjFaYI+ext51FejfqIcqAyFF5qJHsMt+ascM9A1Qf55dmIiIupwu NI70LySuC59h206T8d7tLphpecROrDOi6/OcsKduLTVRRPY8V3lIdaESt3N+lixeevQG jN1DcmDul3ZDCnuaNN5Gqucwa67ZWP6GN42Ee6dbWds1RbwsE/SUTMlgpQbxh+XS5eQk YItw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yKFLIxxNSAOzYQiuNB9YNQkgCvJCTjgDgBeqiem55UE=; b=dpMnTdmzQOD0+oCmf1sGxBnPGDm9WiZJIEiix5R21Q77HWhhdvfiOGVDDN4KjHG6Li tp0VgD+1ddYiwK4E/A6it9Btt4oncveSGXkEaFXiFhmPOigkbM3XYqX0ddUIBRt0cV0r 0OdKdVLpLjjOLPWK79ZqEmrH0r2EnB3EZUTCbfPDLH67OBpTKnF3gNPC6weOCWgank3z qdC1MuXAbznA+/9MnXAjRvw01WRbS/fTr5VBAugIs60TDbffiWxl+CMKz2ZCDOxVZ3PA pQRFh5Z3GW67RpCUbtn3fjV6lbr39oZIweXRWtfYazxlSzWz1qCSIq3+xtHqaSNORfhW faPQ== X-Gm-Message-State: AA+aEWZlp8E/oSUJqjU8nAf2I1iyTGvO8VDkv5eFuQ+KotWAxuQKLI6Q 4myJMDuZ0gVpZ9zqP3er5geG3W2feo0= X-Google-Smtp-Source: AFSGD/XW3O9wqIQ0uMnIVfNCEq72Y0boca81k5vNEPnrQ2VNs5zaCT+XSq3luUcu0Rf6tXZ/OCmWjw== X-Received: by 2002:a2e:9819:: with SMTP id a25-v6mr2042837ljj.6.1544793550851; Fri, 14 Dec 2018 05:19:10 -0800 (PST) Received: from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id o25sm873884lfd.29.2018.12.14.05.19.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Dec 2018 05:19:10 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: gtzalik@dpdk.org, mw@dpdk.org, matua@amazon.com, rk@semihalf.com Date: Fri, 14 Dec 2018 14:18:37 +0100 Message-Id: <20181214131846.22439-12-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20181214131846.22439-1-mk@semihalf.com> References: <20181214131846.22439-1-mk@semihalf.com> Subject: [dpdk-dev] [PATCH 11/20] net/ena: adjust new line in log messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rafal Kozik Only PMD_*_LOG is adding new line character to the log message. All printouts were adjusted for consistency. Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 3715619a7..5adc87355 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -553,7 +553,7 @@ ena_dev_reset(struct rte_eth_dev *dev) ena_destroy_device(dev); rc = eth_ena_dev_init(dev); if (rc) - PMD_INIT_LOG(CRIT, "Cannot initialize device\n"); + PMD_INIT_LOG(CRIT, "Cannot initialize device"); return rc; } @@ -880,7 +880,7 @@ static int ena_check_valid_conf(struct ena_adapter *adapter) if (max_frame_len > adapter->max_mtu || max_frame_len < ENA_MIN_MTU) { PMD_INIT_LOG(ERR, "Unsupported MTU of %d. " - "max mtu: %d, min mtu: %d\n", + "max mtu: %d, min mtu: %d", max_frame_len, adapter->max_mtu, ENA_MIN_MTU); return ENA_COM_UNSUPPORTED; } @@ -984,7 +984,7 @@ static int ena_stats_get(struct rte_eth_dev *dev, memset(&ena_stats, 0, sizeof(ena_stats)); rc = ena_com_get_dev_basic_stats(ena_dev, &ena_stats); if (unlikely(rc)) { - RTE_LOG(ERR, PMD, "Could not retrieve statistics from ENA"); + RTE_LOG(ERR, PMD, "Could not retrieve statistics from ENA\n"); return rc; } @@ -1013,12 +1013,12 @@ static int ena_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) struct ena_com_dev *ena_dev; int rc = 0; - ena_assert_msg(dev->data != NULL, "Uninitialized device"); - ena_assert_msg(dev->data->dev_private != NULL, "Uninitialized device"); + ena_assert_msg(dev->data != NULL, "Uninitialized device\n"); + ena_assert_msg(dev->data->dev_private != NULL, "Uninitialized device\n"); adapter = (struct ena_adapter *)(dev->data->dev_private); ena_dev = &adapter->ena_dev; - ena_assert_msg(ena_dev != NULL, "Uninitialized device"); + ena_assert_msg(ena_dev != NULL, "Uninitialized device\n"); if (mtu > ena_get_mtu_conf(adapter) || mtu < ENA_MIN_MTU) { RTE_LOG(ERR, PMD, @@ -1204,7 +1204,7 @@ static int ena_queue_start(struct ena_ring *ring) rc = ena_create_io_queue(ring); if (rc) { - PMD_INIT_LOG(ERR, "Failed to create IO queue!\n"); + PMD_INIT_LOG(ERR, "Failed to create IO queue!"); return rc; } @@ -1248,7 +1248,7 @@ static int ena_tx_queue_setup(struct rte_eth_dev *dev, if (!rte_is_power_of_2(nb_desc)) { RTE_LOG(ERR, PMD, - "Unsupported size of TX queue: %d is not a power of 2.", + "Unsupported size of TX queue: %d is not a power of 2.\n", nb_desc); return -EINVAL; } @@ -1337,7 +1337,7 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev, if (!rte_is_power_of_2(nb_desc)) { RTE_LOG(ERR, PMD, - "Unsupported size of RX queue: %d is not a power of 2.", + "Unsupported size of RX queue: %d is not a power of 2.\n", nb_desc); return -EINVAL; } @@ -1410,7 +1410,7 @@ static int ena_populate_rx_queue(struct ena_ring *rxq, unsigned int count) return 0; in_use = rxq->next_to_use - rxq->next_to_clean; - ena_assert_msg(((in_use + count) < ring_size), "bad ring state"); + ena_assert_msg(((in_use + count) < ring_size), "bad ring state\n"); /* get resources for incoming packets */ rc = rte_mempool_get_bulk(rxq->mb_pool, (void **)mbufs, count); @@ -1643,7 +1643,7 @@ ena_set_queues_placement_policy(struct ena_adapter *adapter, rc = ena_com_config_dev_mode(ena_dev, llq, llq_default_configurations); if (unlikely(rc)) { PMD_INIT_LOG(WARNING, "Failed to config dev mode. " - "Fallback to host mode policy.\n"); + "Fallback to host mode policy."); ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; return 0; } @@ -1945,12 +1945,12 @@ static void ena_infos_get(struct rte_eth_dev *dev, uint64_t rx_feat = 0, tx_feat = 0; int rc = 0; - ena_assert_msg(dev->data != NULL, "Uninitialized device"); - ena_assert_msg(dev->data->dev_private != NULL, "Uninitialized device"); + ena_assert_msg(dev->data != NULL, "Uninitialized device\n"); + ena_assert_msg(dev->data->dev_private != NULL, "Uninitialized device\n"); adapter = (struct ena_adapter *)(dev->data->dev_private); ena_dev = &adapter->ena_dev; - ena_assert_msg(ena_dev != NULL, "Uninitialized device"); + ena_assert_msg(ena_dev != NULL, "Uninitialized device\n"); dev_info->speed_capa = ETH_LINK_SPEED_1G |