From patchwork Fri Dec 14 01:26:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 48797 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BCEB91B5FF; Fri, 14 Dec 2018 02:26:31 +0100 (CET) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 6DFB21B5F9 for ; Fri, 14 Dec 2018 02:26:29 +0100 (CET) Received: by mail-pl1-f196.google.com with SMTP id t13so1891896ply.13 for ; Thu, 13 Dec 2018 17:26:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h6lwdm6jtJWxQI/s606EiY1GP4dgf+/8LLhmtk3omW0=; b=XX/gwfIJ5SDUryEm+lenKL6sxPv9oFxH1DGUTx08TKnL1ZtTctwaA1CIWlzmDKvF3V sVTQZ0H//q0Bk90BT2yWpnBhwxfJOg/FKP3rAnd/17tE+IthEDTRKlG6aRSU1MUVkyN/ EMgteej7OtYs+t4Zz4Clql5Uc3HUhMM9nHJEJbPfpSdiUx1lFS7rrjFNB+rDWcGpdOJG Fh2onzlXQodfl+xVxkpKEVkrZde0DKeSrgFu2JUShzYuP0/w2MgKUgWdVKspdX2JK1HJ E6G/D7UHhBP10JfnWWWS0yDV9zIP22MwjwitfEbXvdIl90rdHUgZpl4PHP2s8ks6o8rS lsuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h6lwdm6jtJWxQI/s606EiY1GP4dgf+/8LLhmtk3omW0=; b=c2E1E433tCXF2sIMNfgyJm6iP1vPwjO/NwGhsA5N7Wk+RMLKTOVaLiRRYCe80gt6f5 4J2aYjbsqxeSErfaQnvgpcNzU05xqEmN56xfWHS7BZHJ5ZfyKsAr7Z/ASKh5DM7bXBJj 6neG4pXATci2lJX4ROUUpbDs6o7oPBVNRZA8Xl+FIMn/GSAj49adcF0MrE7abq4uW+ed HsDEvadM/38LgS2kRBCI9bIlsSZ9VTd1Jx0/rCMoAGmnuxslILtQZyNNuVgDsyueI8nj vR1b02Jpfu65V+IE2kFiP8JKaIGc2LWTgkKmOT7d3/ATGL2pWU6c2njtSX2clCM9oY1Z 9guw== X-Gm-Message-State: AA+aEWYpDGYqN+6uoJaB2o7qAfcd2Bc3yAlHiZCd6wmB5JK3TauDCYhf d2Z85313//9xg1IvrapRJBoLnubb+dE= X-Google-Smtp-Source: AFSGD/WSV8dhDL1x1xI5KB5VQ2TdoktWv1kic6NaWGF6DRIhbAcaMXIFJ8Pgc9C4Xk473STRLv66XQ== X-Received: by 2002:a17:902:59c8:: with SMTP id d8mr1051712plj.116.1544750788195; Thu, 13 Dec 2018 17:26:28 -0800 (PST) Received: from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id i21sm3379085pgm.17.2018.12.13.17.26.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Dec 2018 17:26:26 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Thu, 13 Dec 2018 17:26:21 -0800 Message-Id: <20181214012621.15213-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181214012621.15213-1-stephen@networkplumber.org> References: <20181214012621.15213-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/3] net/netvsc: not finding VF should not cause failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It is possible that the VF device exists but DPDK doesn't know about it. This could happen if device was blacklisted or more likely the necessary device (Mellanox) was not part of the DPDK configuration. In either case, the right thing to do is just keep working but only with the slower para-virtual device. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index de872212d3f3..1f7a7e66a51b 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -788,7 +788,7 @@ eth_hn_dev_init(struct rte_eth_dev *eth_dev) err = hn_vf_add(eth_dev, hv); if (err) - goto failed; + hv->vf_present = 0; } return 0;