From patchwork Wed Dec 5 22:11:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 48555 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B4011B105; Wed, 5 Dec 2018 23:12:28 +0100 (CET) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 9D4618E76 for ; Wed, 5 Dec 2018 23:12:24 +0100 (CET) Received: by mail-pg1-f196.google.com with SMTP id z11so9661194pgu.0 for ; Wed, 05 Dec 2018 14:12:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sGUsUpZQbTZMdq0bum8xdHpUcyo0JaJV2c1as7pxrd8=; b=GuL0YhwR7fzW86ro6zkmlzQCbtnYCtAyufH99QMnjCx4mZ0Wu1td+2HIbjEDPQv5B8 vpokuxTHMFBmrd3MqN1tcgbwVBKmfG+iPpkhHXamNi3rPS/6D2++T8q6UWzuyT2HU6AU DB++BF/VYHwTqs4m9WcSoIrtCIMsdUInxMqF5ltNRKm441Lr3/fq7urHJILzbZbKLCSC SEFIhAweOBNrvAvZEbckNCEH8hyJ8syCYKGT0i+861K0yO2PCCwHEZEe5QwjuTq9AJH3 NNWwwtTGnG9efc64gudLjsH7YlnYy2nclV6hD8nYK/bfCZLwK2VBEZ5Oje8b1ePjLMmc uq5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sGUsUpZQbTZMdq0bum8xdHpUcyo0JaJV2c1as7pxrd8=; b=GVTE2b7a26zd0yqeuXaCtQEDG6mJVZi9mPle90WJC/MwkzO40/525kVN8A00W8kdfF 2c90iOwTSJWkUvqiS1FkWcd2ml2ZWXvELejlFSvikpKY9nhD8zZvWczdDPZy1jvPND4u /fwAHcwcn2JV1Sygi2tFIL9qh+TXTJkx5SnWcGFSJPNtueTE/+cyhMRa8zEzsEMcXKnq /AU8NnC6bggG519G7uzmBiiuIxpNpTAPzkZTJ0BUw1ogHEu4GYmuBB3B4wH8VkA9tvVV iluzIIu2hj6NQKG5V0xmczYvKdjqs780Qq6arPhUhkNKxEGBAuGkR1MGDdAfhTcY3dU3 dW0A== X-Gm-Message-State: AA+aEWZUmtA49OeZlWUn0LtYXhYtv4Iht4j40jfdfpB872k3pySgxatZ 4NuQfYLeTIZG85dF+pVqi+PvF8r9ZGI= X-Google-Smtp-Source: AFSGD/WJWFED4L4+QVSULqdGQM3OXPZ9lVql6X9CmGIyJAhpwbPcXxSJCO3lVeE0pxwPMaFyxn+7HQ== X-Received: by 2002:a62:5dd1:: with SMTP id n78mr25630379pfj.58.1544047943496; Wed, 05 Dec 2018 14:12:23 -0800 (PST) Received: from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j14sm27704578pfn.175.2018.12.05.14.12.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 14:12:22 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: mgamal@redhat.com, Stephen Hemminger , Stephen Hemminger Date: Wed, 5 Dec 2018 14:11:59 -0800 Message-Id: <20181205221159.6336-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181205221159.6336-1-stephen@networkplumber.org> References: <1543575881.5400.33.camel@redhat.com> <20181205221159.6336-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 4/4] bus/vmbus: debug subchannel setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add more instrumentation to subchannel setup to help diagnose startup issues. Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/linux/vmbus_uio.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c b/drivers/bus/vmbus/linux/vmbus_uio.c index 38df4d724ed5..09f7efdca286 100644 --- a/drivers/bus/vmbus/linux/vmbus_uio.c +++ b/drivers/bus/vmbus/linux/vmbus_uio.c @@ -357,19 +357,25 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary, continue; } - if (!vmbus_isnew_subchannel(primary, relid)) - continue; /* Already know about you */ + if (!vmbus_isnew_subchannel(primary, relid)) { + VMBUS_LOG(DEBUG, "skip already found channel: %lu", + relid); + continue; + } - if (!vmbus_uio_ring_present(dev, relid)) - continue; /* Ring may not be ready yet */ + if (!vmbus_uio_ring_present(dev, relid)) { + VMBUS_LOG(DEBUG, "ring mmap not found (yet) for: %lu", + relid); + continue; + } snprintf(subchan_path, sizeof(subchan_path), "%s/%lu", chan_path, relid); err = vmbus_uio_sysfs_read(subchan_path, "subchannel_id", &subid, UINT16_MAX); if (err) { - VMBUS_LOG(NOTICE, "invalid subchannel id %lu", - subid); + VMBUS_LOG(NOTICE, "no subchannel_id in %s:%s", + subchan_path, strerror(-err)); goto fail; } @@ -379,14 +385,14 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary, err = vmbus_uio_sysfs_read(subchan_path, "monitor_id", &monid, UINT8_MAX); if (err) { - VMBUS_LOG(NOTICE, "invalid monitor id %lu", - monid); + VMBUS_LOG(NOTICE, "no monitor_id in %s:%s", + subchan_path, strerror(-err)); goto fail; } err = vmbus_chan_create(dev, relid, subid, monid, subchan); if (err) { - VMBUS_LOG(NOTICE, "subchannel setup failed"); + VMBUS_LOG(ERR, "subchannel setup failed"); goto fail; } break;