From patchwork Wed Oct 17 02:07:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 46936 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C843558EC; Wed, 17 Oct 2018 04:07:57 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0056.outbound.protection.outlook.com [104.47.2.56]) by dpdk.org (Postfix) with ESMTP id 4FF3E58EC for ; Wed, 17 Oct 2018 04:07:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=der/7bIa7KcLaA2sUwgzXqyyKsp36Ulm8nu3YzKh6Cg=; b=hc/TLb+7ikYtk5ptcDbKWYZ6mVx72kM+PeXFp+ZVh1o1c0sAe9yWqcpMVG5R42msL9QYWWhijMLOlma9R+erV+J3OHGkvEEIM0JMlVQIqloPBETOCq5EKPTN/NbNoMGh86KgKZxFzh8Qq4CEY/g+kxHyJOWrpHjqbhUS8MwO5Zw= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3946.eurprd05.prod.outlook.com (52.134.71.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.21; Wed, 17 Oct 2018 02:07:53 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::f8a1:fcab:94f0:97cc]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::f8a1:fcab:94f0:97cc%3]) with mapi id 15.20.1228.027; Wed, 17 Oct 2018 02:07:53 +0000 From: Yongseok Koh To: Shahaf Shuler CC: "dev@dpdk.org" , Yongseok Koh , Ori Kam Thread-Topic: [PATCH 1/5] net/mlx5: add warning message for Direct Verbs flow Thread-Index: AQHUZb4253JTlEw6sECbjdrVVyILSA== Date: Wed, 17 Oct 2018 02:07:52 +0000 Message-ID: <20181017020739.11203-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR01CA0006.prod.exchangelabs.com (2603:10b6:a02:80::19) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB3946; 6:Sr83FPhnV9mW6nvO5pHFGNcDPa3XkjldKPtif9Sqg9nQ4sBilijUbbkAafH7s1MUbJYN7ev79rFoHG4wuxCh2NjP6a2JFD9kZqH/uki5Y6AX1k0Bg8jVsXlrZzcOjW9NpzJpeE80VyMJQ/wk5tPZpngC5NEopsuNUtInrA+kDP2274jHAV8DmhWK66w4lBkDoYLtEZR4j5CCn4V/N/G8cwrz2tLDCLFSVU9XlqDmkTZfglo/CSsjXWH61qW2qwPFCSAPwDV472aWD24nZvzkoykQ6MsLuznqJHz90KDFFxjTlHocyQ/Eg+JG17fPhKPp3+VxFjR+jgOe/sRFOrCFNd60MQZ4/f1oez86FVpRsfzHP+ZNXRlBPZUrAIb0s7ILJpuAo7ZVxB67wYDBtJpJRdmS9gyMY6HGNcP91xhNwgFMeMNe4Yk0S//5zUaAdghZxs8xlKxhoJ+bbkEk9WfuSA==; 5:uobduXFQRCOOdACSp/0S6yzxN4yvKSUuvKOBPEuxq5UIIbVc5HG63yR+CIYsfM+S6sbTAxKuwkInvTdVgyIC4LB5De5evnbED9CHEjrOF9AJ4mC888SfgokrP6M99656VBNKsodKnn/7WCnDxpSAp07t4M9xMdVsiEjekVoTWXs=; 7:PHQDk2xrsCDJnkcYui4rOwxkqrOLEW99jyEAK72OypPUBt/Ool+yc8YS4J08PVZRUWZRSFcL0IIYyLlDYprcI18dFykaz2Yt8P+aC7MF+Tnww1WvOu6Es01ygHoOxN5FV/Z4eqoY1fY3k8Z3/vdT+8Qi3100N1dUSDIRmhUFhtm3+eSl0sgWDPIlGhojZeiaxCXr7nnlabaZQ6s3emyO7d5PVOrwz8xe0H4rdy+bizFL9vDUdUwRzLcuoLbEdlaX x-ms-office365-filtering-correlation-id: 6cc7d163-acf9-4fd0-fbbc-08d633d5586e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3946; x-ms-traffictypediagnostic: DB3PR0502MB3946: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(3002001)(6055026)(149066)(150057)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(201708071742011)(7699051)(76991084); SRVR:DB3PR0502MB3946; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3946; x-forefront-prvs: 08286A0BE2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(346002)(376002)(136003)(366004)(199004)(189003)(71200400001)(71190400001)(105586002)(66066001)(97736004)(86362001)(52116002)(2900100001)(99286004)(107886003)(36756003)(478600001)(14454004)(15650500001)(5250100002)(106356001)(54906003)(316002)(37006003)(6636002)(6486002)(256004)(305945005)(8936002)(2616005)(476003)(14444005)(486006)(6436002)(81166006)(81156014)(8676002)(53936002)(6862004)(4326008)(2906002)(25786009)(6512007)(5660300001)(186003)(7736002)(1076002)(102836004)(68736007)(3846002)(26005)(386003)(6116002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3946; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: V0+1t6QFoHDa0U7A8gzyOw2dUfWDmRnSJy13ufsZzqlNVMK4VX7ZKIZqdHwGBqVBnu9hZo9ajiYqsS2H0I8UgpaeNfcCUnVOr/n7gz121CZA9O9CmGZzrMMWym3jGgggvySlNQbcczDl9im/jIhneCCaLD9/irN+LC9FEL1M5Drdins3NZOuk7Yg0ERaDXpU8idXdGHwHMSDI/puyKkeAaQFr8EUpiuXLTu126U7eHAjAd4aDEXYJzwidjrV/DDpFHT95dDH79MxArHAdPsi5X5bC++ymgF8tiRKBk28rVeVgzdx7sP5w3/+hKO08wTX8x6BrnBNsFEiIOYUER86Y56bl4GR23+UCedZcxDL1Wc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cc7d163-acf9-4fd0-fbbc-08d633d5586e X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2018 02:07:52.9222 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3946 Subject: [dpdk-dev] [PATCH 1/5] net/mlx5: add warning message for Direct Verbs flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In case that the library doesn't support DV flow, if enabled by 'dv_flow_en=1', print out a warning message and disable it. Fixes: 51e72d386c99 ("net/mlx5: add runtime parameter to enable Direct Verbs") Cc: orika@mellanox.com Signed-off-by: Yongseok Koh Acked-by: Ori Kam Acked-by: Ori Kam --- drivers/net/mlx5/mlx5.c | 6 ++++++ drivers/net/mlx5/mlx5_flow.c | 20 +++++++------------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 795a219771..70b8626126 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1016,6 +1016,12 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, cs_desc.counter_type, cs_desc.num_of_cs, cs_desc.attributes); #endif +#ifndef HAVE_IBV_FLOW_DV_SUPPORT + if (config.dv_flow_en) { + DRV_LOG(WARNING, "DV flow is not supported"); + config.dv_flow_en = 0; + } +#endif config.ind_table_max_size = attr.rss_caps.max_rwq_indirection_table_size; /* diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index bd70fce248..04e287f160 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -1673,25 +1673,19 @@ const struct mlx5_flow_driver_ops mlx5_flow_null_drv_ops = { * Pointer to the flow attributes. * * @return - * flow driver type if supported, MLX5_FLOW_TYPE_MAX otherwise. + * flow driver type, MLX5_FLOW_TYPE_MAX otherwise. */ static enum mlx5_flow_drv_type -flow_get_drv_type(struct rte_eth_dev *dev __rte_unused, - const struct rte_flow_attr *attr) +flow_get_drv_type(struct rte_eth_dev *dev, const struct rte_flow_attr *attr) { - struct priv *priv __rte_unused = dev->data->dev_private; + struct priv *priv = dev->data->dev_private; enum mlx5_flow_drv_type type = MLX5_FLOW_TYPE_MAX; - if (attr->transfer) { + if (attr->transfer) type = MLX5_FLOW_TYPE_TCF; - } else { -#ifdef HAVE_IBV_FLOW_DV_SUPPORT - type = priv->config.dv_flow_en ? MLX5_FLOW_TYPE_DV : - MLX5_FLOW_TYPE_VERBS; -#else - type = MLX5_FLOW_TYPE_VERBS; -#endif - } + else + type = priv->config.dv_flow_en ? MLX5_FLOW_TYPE_DV : + MLX5_FLOW_TYPE_VERBS; return type; }