[v3,0/6] replace attach/detach functions
Message ID | 20181009133450.19112-1-thomas@monjalon.net (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D39861B529; Tue, 9 Oct 2018 15:34:59 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 4C9B51B526 for <dev@dpdk.org>; Tue, 9 Oct 2018 15:34:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B7D5A22037; Tue, 9 Oct 2018 09:34:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 09 Oct 2018 09:34:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=IOFRPwrrFX Wnlq0eZZKJgDBh/loOTqYWwojkATPceHo=; b=Y3YlecpG5KnfaA4kP3GjOaMtDH OuWNl3WjJodm0mcs+An5u0Dyg8+Va4EZ2elYGEvOwJxqqmmnvI+qpzxxzQ0sTQUr /SbgvYD9uFvtTI+hVROA1hvG+6wo9+nrPJg0aNYlUDUti/ZpCAJocM0YERiIKJZQ UwyMre42JNUaaxfAY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=IOFRPwrrFXWnlq0eZZKJgDBh/loOTqYWwojkATPceHo=; b=XHldLgO7 99m7LUpC+CSN/Ry3B/qtdJbaCG09GW8hdsbXMCexN68T1FKrCe7mnlSklXainaJe kbzbarqUbv3aXvcohvRhuB511oEeg0Z9GJmFtYCxFEHIXaO2I9I6NcgfZsY3fGbT vd0NzgxKOKd/gLeZgz4LX933kVdfSiR2y135c4K24FY/7WqjGKccQFpiToxlzXEO ZNSkR7YMuJFhKhuHlOntBCbUFqN7DWd2f6eBVz0Otmzgd6A0E9jFan/clqUVbrTi AVhOwTbE66/CEBAuRStT6dlT6vCkQ39ZDFqZqnGkQ2cammuVxTr84tBXhy8mUeg5 GjsJ0dUFt7aEgQ== X-ME-Sender: <xms:gK68W4J0HhUwPEgabnI1t_fPN4-SBwP5t30_2DkDQ0JNKp3VMGRitQ> X-ME-Proxy: <xmx:ga68W0p6spDORx1nP6ujuhTL6jTwkvXEbRgzPrqojf2v7eYZEHc7IQ> <xmx:ga68Wzecby4pyY19VBe2_E2OpdRg-1yOp94WBiRyz9MoW9H_p1yoag> <xmx:ga68W_zauVAwEHJU6etXY2RbkVjoHIYTG_SNgtUe7fFS32NCvMagHw> <xmx:ga68W5Q6NLLIfYMHBcaK1TQv_ZJxMMH-WrLdVT9olDGmReXgZSDsEA> <xmx:ga68W9nTsMenO_afdET8bZ7y6u8haUlOR6MNN7qKtva4jCoixprOgg> <xmx:ga68WwwxzsN0ki0B9oVO7656bjEiXzlrhlvn3ZRECnT2jMmObSqtUA> Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DE239102EA; Tue, 9 Oct 2018 09:34:55 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, ferruh.yigit@intel.com, arybchenko@solarflare.com Date: Tue, 9 Oct 2018 15:34:44 +0200 Message-Id: <20181009133450.19112-1-thomas@monjalon.net> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181007222554.4886-1-thomas@monjalon.net> References: <20181007222554.4886-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 0/6] replace attach/detach functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Message
Thomas Monjalon
Oct. 9, 2018, 1:34 p.m. UTC
The functions for EAL attach/detach had already some replacements, so they are removed. The functions for ethdev attach/detach are removed and replaced thanks to a new ethdev iterator working with devargs. rte_eth_dev_attach(devargs, &port_id) is replaced by: rte_dev_probe(devargs); RTE_ETH_FOREACH_MATCHING_DEV(port_id, devargs, &iterator) { do what you want with the new port_id } The biggest benefit is to be able to manage devargs string matching several ports to probe. Depends on: https://patches.dpdk.org/project/dpdk/list/?series=1676 Changes in v3 - after Andrew's review: - coding rules compliance - stricter checks for snprintf - rte_eth_iterator_free() becomes rte_eth_iterator_cleanup() - add rte_eth_iterator_cleanup in .map Changes in v2 - after Andrew's review: - return only 0 or -1 in vdev_dev_match() - fix freeing of strings in the iterator - add rte_eth_iterator_free() - tolerate extra parameters from old syntax - add more comments - separate contributing guide patch Thomas Monjalon (6): bus/vdev: add iteration filter on name ethdev: add iterator to match devargs input ethdev: allow iterating with pure class filter doc: replace doxygen example in contribution guide ethdev: remove deprecated attach/detach functions eal: remove deprecated attach/detach functions app/test-pmd/testpmd.c | 17 +- doc/guides/contributing/documentation.rst | 15 +- doc/guides/prog_guide/index.rst | 1 - .../prog_guide/port_hotplug_framework.rst | 106 --------- doc/guides/rel_notes/deprecation.rst | 12 - doc/guides/rel_notes/release_18_11.rst | 14 +- drivers/bus/vdev/vdev_params.c | 19 +- drivers/net/virtio/virtio_user_ethdev.c | 1 - lib/librte_eal/common/eal_common_dev.c | 53 ----- lib/librte_eal/common/include/rte_common.h | 6 + lib/librte_eal/common/include/rte_dev.h | 27 --- lib/librte_eal/rte_eal_version.map | 2 - lib/librte_ethdev/Makefile | 2 +- lib/librte_ethdev/ethdev_private.c | 10 +- lib/librte_ethdev/ethdev_private.h | 6 + lib/librte_ethdev/meson.build | 2 +- lib/librte_ethdev/rte_class_eth.c | 9 +- lib/librte_ethdev/rte_ethdev.c | 223 +++++++++++------- lib/librte_ethdev/rte_ethdev.h | 112 ++++++--- lib/librte_ethdev/rte_ethdev_version.map | 5 +- 20 files changed, 303 insertions(+), 339 deletions(-) delete mode 100644 doc/guides/prog_guide/port_hotplug_framework.rst