diff mbox series

[v2,08/12] net/bnxt: use correct macro to register VF async event completion ring

Message ID 20180922045559.27438-9-ajit.khaparde@broadcom.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers
Series bnxt patchset |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ajit Khaparde Sept. 22, 2018, 4:55 a.m. UTC 
  From: yongping <yongping@broadcom.com>

While registering vf's event completion ring to FW, use the wrong
macro, FW doesn't set up the event completion ring successfully,
VF can't receive any async event.

Signed-off-by: yongping <yongping@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Sept. 25, 2018, 11:30 a.m. UTC | #1 
On 9/22/2018 5:55 AM, Ajit Khaparde wrote:
> From: yongping <yongping@broadcom.com>
> 
> While registering vf's event completion ring to FW, use the wrong
> macro, FW doesn't set up the event completion ring successfully,
> VF can't receive any async event.

Isn't this a fix that you would want to backport?

If so can you please update the commit log according, and perhaps it can be
better to move this patch before HWRM update patch, to help stable tree maintainers.

> 
> Signed-off-by: yongping <yongping@broadcom.com>

Can you please use "Name Surname <mail_address_all_lowercase>" syntax?

> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_hwrm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index 62da254b9..51fe3a4c2 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -3001,7 +3001,7 @@ int bnxt_hwrm_vf_func_cfg_def_cp(struct bnxt *bp)
>  	HWRM_PREP(req, FUNC_VF_CFG, BNXT_USE_CHIMP_MB);
>  
>  	req.enables = rte_cpu_to_le_32(
> -			HWRM_FUNC_CFG_INPUT_ENABLES_ASYNC_EVENT_CR);
> +			HWRM_FUNC_VF_CFG_INPUT_ENABLES_ASYNC_EVENT_CR);
>  	req.async_event_cr = rte_cpu_to_le_16(
>  			bp->def_cp_ring->cp_ring_struct->fw_ring_id);
>  	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
>
diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 62da254b9..51fe3a4c2 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -3001,7 +3001,7 @@  int bnxt_hwrm_vf_func_cfg_def_cp(struct bnxt *bp)
 	HWRM_PREP(req, FUNC_VF_CFG, BNXT_USE_CHIMP_MB);
 
 	req.enables = rte_cpu_to_le_32(
-			HWRM_FUNC_CFG_INPUT_ENABLES_ASYNC_EVENT_CR);
+			HWRM_FUNC_VF_CFG_INPUT_ENABLES_ASYNC_EVENT_CR);
 	req.async_event_cr = rte_cpu_to_le_16(
 			bp->def_cp_ring->cp_ring_struct->fw_ring_id);
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);