diff mbox series

[v2,1/4] build: include missing hypervisor files in Meson build

Message ID 20180831104154.20938-1-bluca@debian.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series [v2,1/4] build: include missing hypervisor files in Meson build | expand

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Luca Boccassi Aug. 31, 2018, 10:41 a.m. UTC
They are built by the legacy makefiles but not by Meson.

Fixes: 8f40ee0734c8 ("eal/x86: get hypervisor name")

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
 lib/librte_eal/common/arch/arm/meson.build | 2 +-
 lib/librte_eal/common/arch/x86/meson.build | 2 +-
 lib/librte_eal/common/meson.build          | 2 ++
 3 files changed, 4 insertions(+), 2 deletions(-)

Comments

Bruce Richardson Aug. 31, 2018, 11 a.m. UTC | #1
On Fri, Aug 31, 2018 at 11:41:51AM +0100, Luca Boccassi wrote:
> They are built by the legacy makefiles but not by Meson.
> 
> Fixes: 8f40ee0734c8 ("eal/x86: get hypervisor name")
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon Sept. 16, 2018, 9 a.m. UTC | #2
31/08/2018 13:00, Bruce Richardson:
> On Fri, Aug 31, 2018 at 11:41:51AM +0100, Luca Boccassi wrote:
> > They are built by the legacy makefiles but not by Meson.
> > 
> > Fixes: 8f40ee0734c8 ("eal/x86: get hypervisor name")
> > 
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Should we add "Cc: stable@dpdk.org" for the whole series?
Bruce Richardson Sept. 17, 2018, 8:20 a.m. UTC | #3
On Sun, Sep 16, 2018 at 11:00:24AM +0200, Thomas Monjalon wrote:
> 31/08/2018 13:00, Bruce Richardson:
> > On Fri, Aug 31, 2018 at 11:41:51AM +0100, Luca Boccassi wrote:
> > > They are built by the legacy makefiles but not by Meson.
> > > 
> > > Fixes: 8f40ee0734c8 ("eal/x86: get hypervisor name")
> > > 
> > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > 
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Should we add "Cc: stable@dpdk.org" for the whole series?
> 
Yes, it wouldn't hurt to do so.
Luca Boccassi Sept. 17, 2018, 9:01 a.m. UTC | #4
On Mon, 2018-09-17 at 09:20 +0100, Bruce Richardson wrote:
> On Sun, Sep 16, 2018 at 11:00:24AM +0200, Thomas Monjalon wrote:
> > 31/08/2018 13:00, Bruce Richardson:
> > > On Fri, Aug 31, 2018 at 11:41:51AM +0100, Luca Boccassi wrote:
> > > > They are built by the legacy makefiles but not by Meson.
> > > > 
> > > > Fixes: 8f40ee0734c8 ("eal/x86: get hypervisor name")
> > > > 
> > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > 
> > > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > 
> > Should we add "Cc: stable@dpdk.org" for the whole series?
> > 
> 
> Yes, it wouldn't hurt to do so.

Done in v3, thanks
diff mbox series

Patch

diff --git a/lib/librte_eal/common/arch/arm/meson.build b/lib/librte_eal/common/arch/arm/meson.build
index c6bd92272b..79731e1a2c 100644
--- a/lib/librte_eal/common/arch/arm/meson.build
+++ b/lib/librte_eal/common/arch/arm/meson.build
@@ -2,4 +2,4 @@ 
 # Copyright(c) 2017 Intel Corporation.
 
 eal_common_arch_sources = files('rte_cpuflags.c',
-	'rte_cycles.c')
+	'rte_cycles.c', 'rte_hypervisor.c')
diff --git a/lib/librte_eal/common/arch/x86/meson.build b/lib/librte_eal/common/arch/x86/meson.build
index 4e0f77900a..14bf204c6f 100644
--- a/lib/librte_eal/common/arch/x86/meson.build
+++ b/lib/librte_eal/common/arch/x86/meson.build
@@ -2,4 +2,4 @@ 
 # Copyright(c) 2017 Intel Corporation
 
 eal_common_arch_sources = files('rte_spinlock.c', 'rte_cpuflags.c',
-	'rte_cycles.c')
+	'rte_cycles.c', 'rte_hypervisor.c')
diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
index 56005bea80..b7fc984997 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -14,6 +14,7 @@  common_sources = files(
 	'eal_common_errno.c',
 	'eal_common_fbarray.c',
 	'eal_common_hexdump.c',
+	'eal_common_hypervisor.c',
 	'eal_common_launch.c',
 	'eal_common_lcore.c',
 	'eal_common_log.c',
@@ -59,6 +60,7 @@  common_headers = files(
 	'include/rte_errno.h',
 	'include/rte_fbarray.h',
 	'include/rte_hexdump.h',
+	'include/rte_hypervisor.h',
 	'include/rte_interrupts.h',
 	'include/rte_keepalive.h',
 	'include/rte_launch.h',