diff mbox series

doc: fix wrong usage of bind command

Message ID 20180824074302.18606-1-ramirose@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers
Series doc: fix wrong usage of bind command |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Rami Rosen Aug. 24, 2018, 7:43 a.m. UTC 
  This patch fixes wrong usage of bind command in vhost.rst.
Using "dpdk-devbind.py -b=uio_pci_generic 0000:00:04.0" gives 
an error of "unbind failed". It should be "-b uio_pci_generic" so 
it will work correctly.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 doc/guides/sample_app_ug/vhost.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yang, Zhiyong Aug. 24, 2018, 8:07 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Friday, August 24, 2018 3:43 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.doc; Mcnamara, John <john.mcnamara@intel.com>; Rami
> Rosen <ramirose@gmail.com>
> Subject: [dpdk-dev] [PATCH] doc: fix wrong usage of bind command
> 
> This patch fixes wrong usage of bind command in vhost.rst.
> Using "dpdk-devbind.py -b=uio_pci_generic 0000:00:04.0" gives an error of
> "unbind failed". It should be "-b uio_pci_generic" so it will work correctly.
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---

Acked-by: Zhiyong Yang <zhiyong.yang@intel.com>
Maxime Coquelin Sept. 10, 2018, 1:11 p.m. UTC | #2 
On 08/24/2018 09:43 AM, Rami Rosen wrote:
> This patch fixes wrong usage of bind command in vhost.rst.
> Using "dpdk-devbind.py -b=uio_pci_generic 0000:00:04.0" gives
> an error of "unbind failed". It should be "-b uio_pci_generic" so
> it will work correctly.
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>   doc/guides/sample_app_ug/vhost.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vhost.rst
> index fd42cb3f7..df4d6f9a0 100644
> --- a/doc/guides/sample_app_ug/vhost.rst
> +++ b/doc/guides/sample_app_ug/vhost.rst
> @@ -78,7 +78,7 @@ could be done by:
>   .. code-block:: console
>   
>      modprobe uio_pci_generic
> -   $RTE_SDK/usertools/dpdk-devbind.py -b=uio_pci_generic 0000:00:04.0
> +   $RTE_SDK/usertools/dpdk-devbind.py -b uio_pci_generic 0000:00:04.0
>   
>   Then start testpmd for packet forwarding testing.
>   
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

And applied to dpdk-next-virtio/master

Thanks,
Maxime
diff mbox series

Patch

diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vhost.rst
index fd42cb3f7..df4d6f9a0 100644
--- a/doc/guides/sample_app_ug/vhost.rst
+++ b/doc/guides/sample_app_ug/vhost.rst
@@ -78,7 +78,7 @@  could be done by:
 .. code-block:: console
 
    modprobe uio_pci_generic
-   $RTE_SDK/usertools/dpdk-devbind.py -b=uio_pci_generic 0000:00:04.0
+   $RTE_SDK/usertools/dpdk-devbind.py -b uio_pci_generic 0000:00:04.0
 
 Then start testpmd for packet forwarding testing.