[v2] mempool: check for invalid args on creation
Checks
Commit Message
Currently, a mempool can be created if the number of
objects is zero. However, in this scenario,
rte_mempool_create should return NULL,
as the mempool created is useless otherwise.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
lib/librte_mempool/rte_mempool.c | 6 ++++++
1 file changed, 6 insertions(+)
Comments
On 02.08.2018 03:35, Pablo de Lara wrote:
> Currently, a mempool can be created if the number of
> objects is zero. However, in this scenario,
> rte_mempool_create should return NULL,
> as the mempool created is useless otherwise.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
02/08/2018 13:10, Andrew Rybchenko:
> On 02.08.2018 03:35, Pablo de Lara wrote:
> > Currently, a mempool can be created if the number of
> > objects is zero. However, in this scenario,
> > rte_mempool_create should return NULL,
> > as the mempool created is useless otherwise.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied, thanks
@@ -916,6 +916,12 @@ rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size,
mempool_list = RTE_TAILQ_CAST(rte_mempool_tailq.head, rte_mempool_list);
+ /* asked for zero items */
+ if (n == 0) {
+ rte_errno = EINVAL;
+ return NULL;
+ }
+
/* asked cache too big */
if (cache_size > RTE_MEMPOOL_CACHE_MAX_SIZE ||
CALC_CACHE_FLUSHTHRESH(cache_size) > n) {