diff mbox series

[1/5] qat: remove redundant C register keyword

Message ID 20180731163059.27085-2-stephen@networkplumber.org (mailing list archive)
State Rejected, archived
Delegated to: Ferruh Yigit
Headers
Series remove usage of register keyword in C |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger July 31, 2018, 4:30 p.m. UTC 
  Modern C compilers ignore the register keyword and do automatic
register assignment.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/qat/qat_qp.c  | 10 +++++-----
 drivers/crypto/qat/qat_sym.c |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

Comments

Tomasz Jozwiak Sept. 5, 2018, 10:23 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Tuesday, July 31, 2018 6:31 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Subject: [dpdk-dev] [PATCH 1/5] qat: remove redundant C register keyword
> 
> Modern C compilers ignore the register keyword and do automatic register
> assignment.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
diff mbox series

Patch

diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c
index 7ca7a45ebfe0..21891ec1955d 100644
--- a/drivers/common/qat/qat_qp.c
+++ b/drivers/common/qat/qat_qp.c
@@ -530,13 +530,13 @@  void rxq_free_desc(struct qat_qp *qp, struct qat_queue *q)
 uint16_t
 qat_enqueue_op_burst(void *qp, void **ops, uint16_t nb_ops)
 {
-	register struct qat_queue *queue;
+	struct qat_queue *queue;
 	struct qat_qp *tmp_qp = (struct qat_qp *)qp;
-	register uint32_t nb_ops_sent = 0;
-	register int ret;
+	uint32_t nb_ops_sent = 0;
+	int ret;
 	uint16_t nb_ops_possible = nb_ops;
-	register uint8_t *base_addr;
-	register uint32_t tail;
+	uint8_t *base_addr;
+	uint32_t tail;
 	int overflow;
 
 	if (unlikely(nb_ops == 0))
diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
index 8273968f3aa7..dc77ca870fc9 100644
--- a/drivers/crypto/qat/qat_sym.c
+++ b/drivers/crypto/qat/qat_sym.c
@@ -150,7 +150,7 @@  qat_sym_build_request(void *in_op, uint8_t *out_msg,
 	struct qat_sym_session *ctx;
 	struct icp_qat_fw_la_cipher_req_params *cipher_param;
 	struct icp_qat_fw_la_auth_req_params *auth_param;
-	register struct icp_qat_fw_la_bulk_req *qat_req;
+	struct icp_qat_fw_la_bulk_req *qat_req;
 	uint8_t do_auth = 0, do_cipher = 0, do_aead = 0;
 	uint32_t cipher_len = 0, cipher_ofs = 0;
 	uint32_t auth_len = 0, auth_ofs = 0;