diff mbox series

doc: fix incorrect create bonding command in testpmd

Message ID 20180723112739.24293-1-shreyansh.jain@nxp.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series doc: fix incorrect create bonding command in testpmd |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Shreyansh Jain July 23, 2018, 11:27 a.m. UTC 
  Fixes: e76d7a768ce0 ("doc: fix syntax in testpmd user guide")
Cc: john.mcnamara@intel.com
Cc: stable@dpdk.org

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
Note: Though the git blame suggest e76d7a768c as the last modification
      for fixes, this actually existed when testpmd doc was added.

 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit July 23, 2018, 8:49 p.m. UTC | #1 
On 7/23/2018 12:27 PM, Shreyansh Jain wrote:
> Fixes: e76d7a768ce0 ("doc: fix syntax in testpmd user guide")
> Cc: john.mcnamara@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
> Note: Though the git blame suggest e76d7a768c as the last modification
>       for fixes, this actually existed when testpmd doc was added.

You are right, I think fixes should be initial commit:
Fixes: ac718398f477 ("doc: testpmd application user guide")

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Iremonger, Bernard July 25, 2018, 9 a.m. UTC | #2 
Hi Shreyansh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, July 23, 2018 9:49 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>; dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Mcnamara, John <john.mcnamara@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] doc: fix incorrect create bonding
> command in testpmd
> 
> On 7/23/2018 12:27 PM, Shreyansh Jain wrote:
> > Fixes: e76d7a768ce0 ("doc: fix syntax in testpmd user guide")
> > Cc: john.mcnamara@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> > ---
> > Note: Though the git blame suggest e76d7a768c as the last modification
> >       for fixes, this actually existed when testpmd doc was added.
> 
> You are right, I think fixes should be initial commit:
> Fixes: ac718398f477 ("doc: testpmd application user guide")
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Could you send a v2 with the correct Fixes line.

Otherwise

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
diff mbox series

Patch

diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 1d6bdf9b3..16af95035 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -1993,7 +1993,7 @@  Create a new bonding device::
 
 For example, to create a bonded device in mode 1 on socket 0::
 
-   testpmd> create bonded 1 0
+   testpmd> create bonded device 1 0
    created new bonded device (port X)
 
 add bonding slave