diff mbox series

devtools: remove NFP from test-build

Message ID 20180719030331.32389-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series devtools: remove NFP from test-build | expand

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Pablo de Lara July 19, 2018, 3:03 a.m. UTC
NFP PMD does not have any external dependency.
It only requires Linux OS, so it is not needed
to be enabled in the test-build script.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 devtools/test-build.sh | 1 -
 1 file changed, 1 deletion(-)

Comments

Alejandro Lucero July 19, 2018, 11:11 a.m. UTC | #1
On Thu, Jul 19, 2018 at 4:03 AM, Pablo de Lara <
pablo.de.lara.guarch@intel.com> wrote:

> NFP PMD does not have any external dependency.
> It only requires Linux OS, so it is not needed
> to be enabled in the test-build script.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  devtools/test-build.sh | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index 3ea82bb46..f6db99fb0 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -153,7 +153,6 @@ config () # <directory> <target> <options>
>                 sed -ri       's,(PMD_SZEDATA2=)n,\1y,' $1/.config
>                 test "$DPDK_DEP_ZLIB" != y || \
>                 sed -ri          's,(BNX2X_PMD=)n,\1y,' $1/.config
> -               sed -ri            's,(NFP_PMD=)n,\1y,' $1/.config
>                 test "$DPDK_DEP_PCAP" != y || \
>                 sed -ri               's,(PCAP=)n,\1y,' $1/.config
>                 test -z "$ARMV8_CRYPTO_LIB_PATH" || \
> --
> 2.14.4
>
>
Acked: Alejandro Lucero <alejandro.lucero@netronome.com>
Thomas Monjalon July 26, 2018, 8:31 a.m. UTC | #2
19/07/2018 13:11, Alejandro Lucero:
> On Thu, Jul 19, 2018 at 4:03 AM, Pablo de Lara <
> pablo.de.lara.guarch@intel.com> wrote:
> 
> > NFP PMD does not have any external dependency.
> > It only requires Linux OS, so it is not needed
> > to be enabled in the test-build script.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >
> Acked: Alejandro Lucero <alejandro.lucero@netronome.com>

For reference, it could have been removed when enabling the PMD:
Fixes: 80987c40fd28 ("config: enable nfp driver on Linux")

Applied, thanks
diff mbox series

Patch

diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 3ea82bb46..f6db99fb0 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -153,7 +153,6 @@  config () # <directory> <target> <options>
 		sed -ri       's,(PMD_SZEDATA2=)n,\1y,' $1/.config
 		test "$DPDK_DEP_ZLIB" != y || \
 		sed -ri          's,(BNX2X_PMD=)n,\1y,' $1/.config
-		sed -ri            's,(NFP_PMD=)n,\1y,' $1/.config
 		test "$DPDK_DEP_PCAP" != y || \
 		sed -ri               's,(PCAP=)n,\1y,' $1/.config
 		test -z "$ARMV8_CRYPTO_LIB_PATH" || \