Message ID | 20180718095443.31429-1-krzysztof.kanas@caviumnetworks.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8CA22B9D; Wed, 18 Jul 2018 11:57:38 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0041.outbound.protection.outlook.com [104.47.33.41]) by dpdk.org (Postfix) with ESMTP id E851410A3 for <dev@dpdk.org>; Wed, 18 Jul 2018 11:57:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5/2ll2tweXyKJD0m2PY2YXkRItZ2a8dn0iVIk5sPnRY=; b=EF5Ym9UVH6bCAqeAwxEzn5PKq8uHmvrtYnAqfFZHSFYnKGh4Nl7rhL2URwE8S5Xp+KH0noTT9zqxqa0mv488EnHXMjcYdj4/1CFuoGObhVK89IWP7tw+KznrsXFNwSKIALhKj6V8o19V2SMt93FWYesIlTuT0niT/sNEEAkgD+Q= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Krzysztof.Kanas@cavium.com; Received: from kk-box-0.semihalf.local (31.172.191.173) by BN6PR07MB2946.namprd07.prod.outlook.com (2603:10b6:404:42::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.18; Wed, 18 Jul 2018 09:57:33 +0000 From: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com> To: "Iremonger, Bernard" <bernard.iremonger@intel.com>, krzysztof.kanas@caviumnetworks.com, dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com> Cc: Nithin Dabilpuram <nithin.dabilpuram@cavium.com>, "Singh, Jasvinder" <jasvinder.singh@intel.com> Date: Wed, 18 Jul 2018 11:54:44 +0200 Message-Id: <20180718095443.31429-1-krzysztof.kanas@caviumnetworks.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CCCFA0@IRSMSX107.ger.corp.intel.com> References: <8CEF83825BEC744B83065625E567D7C260CCCFA0@IRSMSX107.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [31.172.191.173] X-ClientProxiedBy: AM4PR05CA0016.eurprd05.prod.outlook.com (2603:10a6:205::29) To BN6PR07MB2946.namprd07.prod.outlook.com (2603:10b6:404:42::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d329f1d7-1fd5-458d-ef04-08d5ec94e2a6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN6PR07MB2946; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2946; 3:GqpwR6jrqoOb0Vh+326Ery4yrmTHeu8ttsgmqjzKS7ChI6oU+Ez3ty0W/vr64sWPg3xX0UJa7jANt0xFpmNiM77Uw1CtRmQSjE99KXtJ/WWfPYt5n7RlNDnXS220fiw0eLdW8cpnyIq2PtIwvXAp/6aSMqejZ8M4KxEkKypXoabJ6GbJ631lki67rs+tWAoRvWCssD6SF6ujSnNE/aOin98iKPmyuHx1pJacZCbdd6zc820ynDqDAzoh9yAc3r8f; 25:XHwsdbgJ1Rk9IsCO4v1x7Qm6eHKiyvLbMs1GheCOwY0FtCmgdmCM+7MiThryuV1XvWO70UQuGb+12eBnm6gGmpGdN3iFYYm6cgD4y45hFPbJk6W5l2uWT4eCh4FZs0fq3oeWHs7BwgHLhu2y5+b/yq8YPm4AOpKbCtdxz19e0IKnGeenNyesMT2gAJeeNrgvInPtZhUBiUE6kX/21bVCMoku3ob14Qlc5T1W1wHsFFOrqRysKG3UgdoDrf5G/zuRDCCNClIhDQLD8gIQBeJZEs3PJUHdVqzu/nIyOOMr2ogn/q3FY2NcioZYz2uQ+j0QM/yt5S2d6UFW2R8/tqZiKw==; 31:bJutySqeAu5WefC86UZSQRkdQhZNlCjmj11ftN9rYtZInqBysK9SxJJu9cWXKMi5X0ZdR7GUbR6G89jSOWPWlwiICMZcB/LVAXyhhc924FLfpNEMzTuVpycUk1V+ZUNStV4MVMltRKyC1RvwbhiA4WFukK3p4KGXUEQfw78t5MdTf2Rgf44QZZ0Lx5N6dPU/GJ5ycG5N6lxLUEltfXyYJ+GPSuobYqA6kOgSeIuT25U= X-MS-TrafficTypeDiagnostic: BN6PR07MB2946: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2946; 20:uhRlzqwIkBH+FiEYmbpiLomFWp0G2wxx8CIJrjCZb/fmuRXB1eGUMmGKLyebgmgNUvXKaUKVCBezouj95Czlw9ZoVWdmIdxqPp5h5hivI6eW7JLGh3INQ2vUPhizUKCs79+oWFjS5fi0YE+zrHwByxIiCLFw9eabmIeBuC6Irb6MWKknhPOPz+70gGCWT2nIzSPvC1nMYDV8dTmui/I0+X/EtvGxEqlus96JcXuO4AG2+BSNAc8Gwcw3hz+Rq4pwXjOA1MkZBHSKG/A5TxPxkYC+8Bwg3w4Q7SbLQTl6b60/eCgL6ZGfJGKKG5Cn1f3lvyHB7xMyZYbHk1QCuWrndDbRvbyDWJEsVj2vkWm10FaV2gnpS6FPR6jl3SpfHvjgn7UH4KgjDB37hv2KMoZFB1k8hGg5viVp8BC7xLT3vI/tiFqUZUmp51FYj97mvE7TxQ7EY5ei11qgWtWpmLtBfNhYCv+Rym7XaQ2GJtI/pdN8fwH4lyTfxmLX+oAslVHsfXi24dM263YWLK8IZKV1hw1zE526J5vyOD7HmDXlx+SjNopDcqpBG08KaahMxu5lBTN+gw8Mlx7dkAD7hRhLaKuyKxT2nwHrhEO6zXhxJb8=; 4:2gPDcPI9w9FV0/ZT6iRBizPr2B0R+5+n+3nWmong3XFFsh35OzgAvoSZ4TePxD9zVJ58BxnGL+KMDxQGkU7B+a6hufmU+RxvULrYhPSy4p/rqng+6/kHOWFhLR267kHfHJsGAGeoup2s2DWb4eyoUbicu9vmegf75FebMC8lAvHGlHdWBHm9GgklsRBAXcTRqITbpvZbQ13aOrFgrQ+02pRtYC+C0bUHPvujWbASZCSPhilNLTtc+3med7SFfQRjzc5M4wOU7dd6cY/0ZxEcMw== X-Microsoft-Antispam-PRVS: <BN6PR07MB29465CB8E7D86DEBB73ABFFB86530@BN6PR07MB2946.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:BN6PR07MB2946; BCL:0; PCL:0; RULEID:; SRVR:BN6PR07MB2946; X-Forefront-PRVS: 0737B96801 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(366004)(346002)(396003)(136003)(189003)(199004)(6512007)(52116002)(47776003)(486006)(478600001)(76176011)(53936002)(476003)(2616005)(51416003)(16526019)(72206003)(106356001)(3846002)(11346002)(446003)(956004)(68736007)(6116002)(36756003)(66066001)(186003)(110136005)(42882007)(54906003)(105586002)(16586007)(50226002)(6666003)(48376002)(5660300001)(25786009)(386003)(97736004)(26005)(44832011)(6506007)(50466002)(81156014)(81166006)(8676002)(1076002)(8936002)(6486002)(4326008)(14444005)(7736002)(305945005)(2906002)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB2946; H:kk-box-0.semihalf.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB2946; 23:n20wPMEHn3wapQ9XcBMkdpyGahY2Eu4syy7C4FfRJ?= C2anwAyFA+YriXEMMqOm+a6BqFNKR8SKy+38+WTv7rDk3x953gAboySl6SXSaAYwpyKAeawsPYgc2Gwo62BxuJLEYgqZ5lWEafGcKe+3g9LsiSdGbl0smc5hAeBqEFH0vqe9jjw6iVerSYfWy7IPe0Gr4eY+qA4mW8EgN7eUKdrKJ0orND732mVPs8fQHYo4qQ7TTtCf7ABHEl7a3I5npmEPzARCHw3PlRYKcqIH8EboXlrS44FZLfAJZzGbyG7hQAakvYYvofCz4G5ItfCzmBy6xrhNf7YSEBKmCGTvWf1iMrlB0Yg32Xnfddpofzj+AgIGb0wRSB3yOlGcoQ/uKIYOwhIlLR4AxbLkUcO8AcekJVkrsiKrKW8xXtldkxKyX08sr/Ea4WSMhgpb+/m0VLfLmnotOjxs7MjPk86WqnRM4ReUoH9KHq2z5f1RbKXVL9b8Oa74UAHOJEXU9bcK1ygtbKfH1WVS5M27W/oaIjN6eK1Sp5x37ewEo+QicMpi4ufotQyZdUnZ0kVuidVc5QwZZweSw+J/s2nHoD7NDX/ZmSfYhAjUtCKcT3PsovClczEIsf3KdM77KBVV9dIEitIUFHMX7ytaBxY9GRpwoTv+Y37EZBwW1fHJdGD0dMjMQu0u4dlFzmOQ0pTznU0i+anoiYIIGenAhZytobwVgssYPCvbGOVLZWDjH78n/Chqee22LdZla5aT4zcKLi7QDMaJolTPk7ctloxRtrgeLppDgQcCyjzPPGgZfhUNxszs8jBkl4xfRUF01MSv+X5w3Uv3Gf8gr/IZaZxuizIsVnD8DUvzYD6RhUa5gojinSARcUzH7qy2XYE8H5rSI+ZO+T1IzGAOpRDfdamUk2dD89kS3yZWWjcA6ketunooZ4I0oBLMD1xVnczqso8h34Sn7VtG/s+++BQYtz9FkGB3t21zpJ65eOPcrwisj9dD0k0YHEvRwndp1CuutVjbgQ2rJPHk/UKg5Ni5yLz0EcPITDxq/0j94ubwaxSlAn3Iu6+mvDbTLClUevCXi54xIcQVy9rywDCGNyAy/Bm+EIzDJuSwIfDot82ehTWfJbO1HJJgWnCSOt12ukj6ISkH7jI3s7O9o/D+UeYxHVGt6qGRXoBh6yQgmr8Aeb5hFk+A1S4WBuGVqwPY0M1ASmxaNg7Gi9BdQfzo8YNJucNa9pO8E48IrNGP9BWwJf2kEhqCkB8gAYFEHhMohtir3RAmxIeu2Iu X-Microsoft-Antispam-Message-Info: XJUdHaxlAWh/ToeSPpkD1CaCUvc1FLTuwXywpiZBcDEPrZlckHxFOI+u1Mv9e87341yTxUV6AzFdjScoYEmdrNI/9icG4rR8MJR7+lZf5n/lWyGuRfdCu+JtIa8P9tXF6kDaZBJqvUg9tiQODuPDCPvBQ9EDTgYPrNwZuinNxa6NPJqMQ0t+2jO3pQLChgt2HNlg/1c9QCFyz4yCbHkbZH3MO7qZOlVLozsuqm24TWFS+mJDD5gFVoF8DoZdTz9Ar4ZR5/3Uze3xmHtsA0aJARSNowQ6gn1GMiFhhsQE5jJkNU2qVCyiM2VMl7EDhHUU9HqlGFxNpJzeAnJLZuapk+B2lTg1O7Tp1+CuEuuQUzo= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2946; 6:a0eQBaksGGT7qL3Kk966USkHIxhnd6W0BN4ftsqhCa8nQuNMeowvsahVG/jGDx3ghvqgYuwzZ4RvZb74HoePXVBWKYF4qhm8Wa2TmuFkzLcUjqUuh3DT8NE62S6N+JzPG4PQndNc9x9fomchKAmKOw5iRoTGDmpsE2wDASoa2wx9TCo0PE8nvyVgPW5GiS2yHdybaKBh59PIvcOijtneWGFAYnxcDw0kZia387shMvIW7wRg1/pfDlxmIqQcKcE5s3+bPqeTda6qYfjSbcSp7phawB6tk9k2rn57A4j2cGhUZXufhlf6GHVSRpFlxRBgoWLNeKlJEDP+DjRB4e5BrLMU3KjGuqonitAyhWKo/JeMWn6gQ3bRYOTZmxES7TbBJ/teUGN/CBGwo7VY0hEqOy66BTZOmcSEhjhIuNVO8Qkpxuqjh02n4h4KrLwYsZUqJ8jIdIU9sKd4SSyIq8QrLw==; 5:p29iC4D/ZiJTjYkKrLeRlatZXLhCW/wIDiMeDg3ZTbdiUwEKR///ZD0NUKlChqA8kV3zNZz6VX/UAjTvhtUxdbS+Rps9WdGJCZB6dhftooq0Gd3YMCL96DtdVAxf5MdAHGc2UrthFaV5/4XiGE9f//dCN8oQxwbfF5WlAczFA6w=; 24:vlS1lUka7KD0MoJOPMYzaxONNvE0e6qnqAheBhIrtecDtxqdwlxx67oa/1ZQa8c6Sz+tYNiobyJh1imfNpAmhZkvxT5T+fRXOAAOs2HBZ9I= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2946; 7:oOppuGyVizK322wpYPEdiKZDGb9llMy9DR33Y9GQYuW/HV6j6njK+xRbzKIuzzUAa9Koo7RXKJRnTvbnBz8rZtkH7W/l8FJ733s2iKXTvXeAgxdkO3ZL2o9F460lzIS90qU77kQlcxxal3SsztJ6aSXLohZ4JQ0QOXzrJZx5Z9c+MLv7fOY72GbY0p+sHdURI27cGhLjAtjhgpSJVKny6d6mm59SXERMSRQWbBhiU5NLE8M8t/ptH3at/kdWanl8 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2018 09:57:33.3549 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d329f1d7-1fd5-458d-ef04-08d5ec94e2a6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB2946 Subject: [dpdk-dev] [PATCH v2 2/2] app/testpmd: fix help string for tm commit cmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
None
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | fail | apply issues |
Commit Message
Krzysztof Kanas
July 18, 2018, 9:54 a.m. UTC
Fixes: bd475cefc7cb ("app/testpmd: fix use of uninitialized field")
Cc: krzysztof.kanas@caviumnetworks.com
Signed-off-by: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com>
---
v2:
* Fix the Fixes commit message line
---
app/test-pmd/cmdline_tm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Krzysztof > -----Original Message----- > From: Krzysztof Kanas [mailto:krzysztof.kanas@caviumnetworks.com] > Sent: Wednesday, July 18, 2018 10:55 AM > To: Iremonger, Bernard <bernard.iremonger@intel.com>; > krzysztof.kanas@caviumnetworks.com; dev@dpdk.org; Lu, Wenzhuo > <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com> > Cc: Nithin Dabilpuram <nithin.dabilpuram@cavium.com>; Singh, Jasvinder > <jasvinder.singh@intel.com> > Subject: [PATCH v2 2/2] app/testpmd: fix help string for tm commit cmd > > Fixes: bd475cefc7cb ("app/testpmd: fix use of uninitialized field") > Cc: krzysztof.kanas@caviumnetworks.com > > Signed-off-by: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com> > --- > v2: > * Fix the Fixes commit message line > --- > app/test-pmd/cmdline_tm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c index > 4f515241703a..09acc1b87293 100644 > --- a/app/test-pmd/cmdline_tm.c > +++ b/app/test-pmd/cmdline_tm.c > @@ -2172,7 +2172,7 @@ static void > cmd_port_tm_hierarchy_commit_parsed(void *parsed_result, > cmdline_parse_inst_t cmd_port_tm_hierarchy_commit = { > .f = cmd_port_tm_hierarchy_commit_parsed, > .data = NULL, > - .help_str = "Set port tm node shaper profile", > + .help_str = "Commit port tm hierarchy", > .tokens = { > (void *)&cmd_port_tm_hierarchy_commit_port, > (void *)&cmd_port_tm_hierarchy_commit_tm, > -- > 2.18.0 The check-git-log script is still showing an error: ./devtools/check-git-log.sh -1 Wrong 'Fixes' reference: Fixes: bd475cefc7cb ("app/testpmd: fix use of uninitialized field") It is better to send the complete patch set (2 patches) with each revision. My ack can be carried forward on the first patch. Regards, Bernard.
diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c index 4f515241703a..09acc1b87293 100644 --- a/app/test-pmd/cmdline_tm.c +++ b/app/test-pmd/cmdline_tm.c @@ -2172,7 +2172,7 @@ static void cmd_port_tm_hierarchy_commit_parsed(void *parsed_result, cmdline_parse_inst_t cmd_port_tm_hierarchy_commit = { .f = cmd_port_tm_hierarchy_commit_parsed, .data = NULL, - .help_str = "Set port tm node shaper profile", + .help_str = "Commit port tm hierarchy", .tokens = { (void *)&cmd_port_tm_hierarchy_commit_port, (void *)&cmd_port_tm_hierarchy_commit_tm,