app/testpmd: fix logically dead code
Checks
Commit Message
Remove logically dead code, tm_port_rate cannot be greater than
UINT32_MAX.
Coverity issue: 302846
Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
app/test-pmd/softnicfwd.c | 3 ---
1 file changed, 3 deletions(-)
Comments
> -----Original Message-----
> From: Laatz, Kevin
> Sent: Tuesday, July 17, 2018 11:34 AM
> To: dev@dpdk.org
> Cc: Singh, Jasvinder <jasvinder.singh@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; Laatz, Kevin <kevin.laatz@intel.com>
> Subject: [PATCH] app/testpmd: fix logically dead code
>
> Remove logically dead code, tm_port_rate cannot be greater than
> UINT32_MAX.
>
> Coverity issue: 302846
> Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > Remove logically dead code, tm_port_rate cannot be greater than
> > UINT32_MAX.
> >
> > Coverity issue: 302846
> > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")
> >
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied, thanks
@@ -175,9 +175,6 @@ set_tm_hiearchy_nodes_shaper_rate(portid_t port_id,
rte_eth_link_get(port_id, &link_params);
tm_port_rate = (uint64_t)ETH_SPEED_NUM_10G * BYTES_IN_MBPS;
- if (tm_port_rate > UINT32_MAX)
- tm_port_rate = UINT32_MAX;
-
/* Set tm hierarchy shapers rate */
h->root_node_shaper_rate = tm_port_rate;
h->subport_node_shaper_rate =