diff mbox series

[v10,11/19] net/kni: enable hotplug on secondary process

Message ID	20180709033706.27858-12-qi.z.zhang@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Qi Zhang <qi.z.zhang@intel.com> To: thomas@monjalon.net, anatoly.burakov@intel.com Cc: konstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, benjamin.h.shelton@intel.com, narender.vangati@intel.com, Qi Zhang <qi.z.zhang@intel.com> Date: Mon, 9 Jul 2018 11:36:58 +0800 Message-Id: <20180709033706.27858-12-qi.z.zhang@intel.com> In-Reply-To: <20180709033706.27858-1-qi.z.zhang@intel.com> References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20180709033706.27858-1-qi.z.zhang@intel.com> Subject: [dpdk-dev] [PATCH v10 11/19] net/kni: enable hotplug on secondary process Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	enable hotplug on multi-process \| [v10,00/19] enable hotplug on multi-process [v10,01/19] ethdev: add function to release port in local process [v10,02/19] bus/pci: fix PCI address compare [v10,03/19] bus/pci: enable vfio unmap resource for secondary [v10,04/19] vfio: remove uneccessary IPC for group fd clear [v10,05/19] eal: enable hotplug on multi-process [v10,06/19] eal: support attach or detach share device from secondary [v10,07/19] net/i40e: enable hotplug on secondary process [v10,08/19] net/ixgbe: enable hotplug on secondary process [v10,09/19] net/af_packet: enable hotplug on secondary process [v10,10/19] net/bonding: enable hotplug on secondary process [v10,11/19] net/kni: enable hotplug on secondary process [v10,12/19] net/null: enable hotplug on secondary process [v10,13/19] net/octeontx: enable hotplug on secondary process [v10,14/19] net/pcap: enable hotplug on secondary process [v10,15/19] net/softnic: enable hotplug on secondary process [v10,16/19] net/tap: enable hotplug on secondary process [v10,17/19] net/vhost: enable hotplug on secondary process [v10,18/19] examples/multi_process: add hotplug sample [v10,19/19] doc: update release notes for multi process hotplug

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	fail	Compilation issues

Commit Message

Qi Zhang July 9, 2018, 3:36 a.m. UTC

  Attach port from secondary should ignore devargs since the private
device is not necessary to support. Also previously, detach port on
a secondary process will mess primary process and cause the same
device can't be attached back again. A secondary process should use
rte_eth_release_port_private to release a port.

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/kni/rte_eth_kni.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c
index ab63ea427..984d0d29a 100644
--- a/drivers/net/kni/rte_eth_kni.c
+++ b/drivers/net/kni/rte_eth_kni.c
@@ -410,8 +410,7 @@  eth_kni_probe(struct rte_vdev_device *vdev)
 	params = rte_vdev_device_args(vdev);
 	PMD_LOG(INFO, "Initializing eth_kni for %s", name);
 
-	if (rte_eal_process_type() == RTE_PROC_SECONDARY &&
-	    strlen(params) == 0) {
+	if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
 		eth_dev = rte_eth_dev_attach_secondary(name);
 		if (!eth_dev) {
 			PMD_LOG(ERR, "Failed to probe %s", name);
@@ -419,6 +418,7 @@  eth_kni_probe(struct rte_vdev_device *vdev)
 		}
 		/* TODO: request info from primary to set up Rx and Tx */
 		eth_dev->dev_ops = &eth_kni_ops;
+		eth_dev->device = &vdev->device;
 		rte_eth_dev_probing_finish(eth_dev);
 		return 0;
 	}
@@ -463,6 +463,9 @@  eth_kni_remove(struct rte_vdev_device *vdev)
 	if (eth_dev == NULL)
 		return -1;
 
+	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+		return rte_eth_dev_release_port_private(eth_dev);
+
 	eth_kni_dev_stop(eth_dev);
 
 	internals = eth_dev->data->dev_private;