From patchwork Fri Jun 29 09:29:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "John Daley (johndale)" X-Patchwork-Id: 41917 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 202E21B454; Fri, 29 Jun 2018 11:31:29 +0200 (CEST) Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) by dpdk.org (Postfix) with ESMTP id 21A501B435 for ; Fri, 29 Jun 2018 11:31:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1283; q=dns/txt; s=iport; t=1530264687; x=1531474287; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=hElbvEo+lbK1WLzGfEm3Pal6WbsdopkRyVGnhRTAELI=; b=LfN/9U96jyZ3R1oL8Q3dMPqhlLIhPWOpTIBghg2ZXfI9HTD0zkn5HZqM /k2oOfeXNGiCubv3mW94mCflMSf/D7tAi1/ct0Kit37NiTfVH0wtVEz/Y huLCIdXDQFoKyE4v0HR4NvZWQa9/BL0/QOtM6vZwIsuOs2dZuBIL/3iMn E=; X-IronPort-AV: E=Sophos;i="5.51,285,1526342400"; d="scan'208";a="420189199" Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jun 2018 09:31:26 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by rcdn-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id w5T9VQk0012873; Fri, 29 Jun 2018 09:31:26 GMT Received: by cisco.com (Postfix, from userid 392789) id 2625E20F2001; Fri, 29 Jun 2018 02:31:26 -0700 (PDT) From: John Daley To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Hyong Youb Kim Date: Fri, 29 Jun 2018 02:29:33 -0700 Message-Id: <20180629092944.15576-5-johndale@cisco.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180629092944.15576-1-johndale@cisco.com> References: <20180628031940.17397-1-johndale@cisco.com> <20180629092944.15576-1-johndale@cisco.com> Subject: [dpdk-dev] [PATCH v2 04/15] net/enic: initialize RQ fetch index before enabling RQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Hyong Youb Kim The fetch index must be initialized only when RQ is disabled. Otherwise, it may lead to stale entries in IG descriptor cache on the VIC. Fixes: a74629cfa3a1 ("net/enic: enable RQ first and then post Rx buffers") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index aba2ff5a7..863d2463c 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -320,6 +320,8 @@ enic_alloc_rx_queue_mbufs(struct enic *enic, struct vnic_rq *rq) * enic_start_rq(). */ rq->need_initial_post = true; + /* Initialize fetch index while RQ is disabled */ + iowrite32(0, &rq->ctrl->fetch_index); return 0; } @@ -345,7 +347,6 @@ enic_initial_post_rx(struct enic *enic, struct vnic_rq *rq) dev_debug(enic, "port=%u, qidx=%u, Write %u posted idx, %u sw held\n", enic->port_id, rq->index, rq->posted_index, rq->rx_nb_hold); iowrite32(rq->posted_index, &rq->ctrl->posted_index); - iowrite32(0, &rq->ctrl->fetch_index); rte_rmb(); rq->need_initial_post = false; }