diff mbox series

[25/31] net/bnxt: fix Tx with multiple mbuf

Message ID	20180619213058.12273-26-ajit.khaparde@broadcom.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Ferruh Yigit
Headers	show Return-Path: <dev-bounces@dpdk.org> From: Ajit Khaparde <ajit.khaparde@broadcom.com> To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Xiaoxin Peng <xiaoxin.peng@broadcom.com>, stable@dpdk.org Date: Tue, 19 Jun 2018 14:30:52 -0700 Message-Id: <20180619213058.12273-26-ajit.khaparde@broadcom.com> In-Reply-To: <20180619213058.12273-1-ajit.khaparde@broadcom.com> References: <20180619213058.12273-1-ajit.khaparde@broadcom.com> Subject: [dpdk-dev] [PATCH 25/31] net/bnxt: fix Tx with multiple mbuf Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	bnxt patchset \| expand [00/31] bnxt patchset [01/31] net/bnxt: fix clear port stats [02/31] net/bnxt: add Tx batching support [03/31] net/bnxt: Rx processing optimization [04/31] net/bnxt: set min and max descriptor count for Tx and Rx rings [05/31] net/bnxt: fix dev close operation [06/31] net/bnxt: set ring coalesce parameters for Stratus NIC [07/31] net/bnxt: fix HW Tx checksum offload check [08/31] net/bnxt: add support for VF id 0xd800 [09/31] net/bnxt: fix rx/tx queue start/stop operations [10/31] net/bnxt: code cleanup style of bnxt cpr [11/31] net/bnxt: code cleanup style of bnxt rxr [12/31] net/bnxt: code cleanup style of rte pmd bnxt file [13/31] net/bnxt: code cleanup style of bnxt stats [14/31] net/bnxt: code cleanup style of bnxt vnic [15/31] net/bnxt: code cleanup style of bnxt txq [16/31] net/bnxt: code cleanup style of bnxt rxq [17/31] net/bnxt: code cleanup style of bnxt vnic [18/31] net/bnxt: code cleanup style of bnxt txr [19/31] net/bnxt: code cleanup style of bnxt ring [20/31] net/bnxt: code cleanup style of bnxt ethdev [21/31] net/bnxt: move function check zero bytes to bnxt util.h [22/31] net/bnxt: filter/flow refactoring [23/31] net/bnxt: check for invalid vnic id [24/31] net/bnxt: update HWRM API to v1.9.2.9 [25/31] net/bnxt: fix Tx with multiple mbuf [26/31] net/bnxt: Revert reset of L2 filter id in clear_ntuple_filter [27/31] net/bnxt: check filter type before clearing it [28/31] net/bnxt: fix set MTU [29/31] net/bnxt: fix incorrect IO address handling in Tx [30/31] net/bnxt: allocate RSS context only if RSS mode is enabled. [31/31] net/bnxt: fix to move a flow to a different queue

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	success	Compilation OK

Commit Message

Ajit Khaparde June 19, 2018, 9:30 p.m. UTC

From: Xiaoxin Peng <xiaoxin.peng@broadcom.com>

When using multi-mbuf to xmit large packets, we need to use total
packet lengths (sum of all segments) to set txbd->flags_type.
Packets will not be sent when using tx_pkt->data_len(The first
segment of packets).

Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
Cc: stable@dpdk.org

Signed-off-by: Xiaoxin Peng <xiaoxin.peng@broadcom.com>
Reviewed-by: Herry Chen <herry.chen@broadcom.com>
Reviewed-by: Jason He <jason.he@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_txr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c
index f8fd22156..23c8e6660 100644
--- a/drivers/net/bnxt/bnxt_txr.c
+++ b/drivers/net/bnxt/bnxt_txr.c
@@ -160,10 +160,10 @@  static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,
 		*cmpl_next = false;
 	}
 	txbd->len = tx_pkt->data_len;
-	if (txbd->len >= 2014)
+	if (tx_pkt->pkt_len >= 2014)
 		txbd->flags_type |= TX_BD_LONG_FLAGS_LHINT_GTE2K;
 	else
-		txbd->flags_type |= lhint_arr[txbd->len >> 9];
+		txbd->flags_type |= lhint_arr[tx_pkt->pkt_len >> 9];
 	txbd->address = rte_cpu_to_le_32(rte_mbuf_data_iova(tx_buf->mbuf));
 
 	if (long_bd) {