From patchwork Tue Jun 19 21:30:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 41277 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A8D91B1FC; Tue, 19 Jun 2018 23:31:25 +0200 (CEST) Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id E34481B053 for ; Tue, 19 Jun 2018 23:31:08 +0200 (CEST) Received: from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net [10.75.144.136]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 9924130C10E; Tue, 19 Jun 2018 14:31:04 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 9924130C10E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1529443864; bh=4iZbli53Rg0B4H0NwTNpNcJ/8mHTwbLBeM98EEllsLE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Stibj0XOhnwRi3kx1bTCin8jhfiojZfo1HQ/V+tV8Xf4GuLyNO367QZlR+vbomZ5Y OdtR7qd1F2bK4Udu1bq5xvztAN4veL7B/PXwxzRGab6QDz0sdzh15Z7vn4vtYcEct8 s/BybmtjIt9HbBMuX5THaCSImkghToQtdFqFYDxI= Received: from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net [10.136.50.120]) by nis-sj1-27.broadcom.com (Postfix) with ESMTP id 934E9AC07B1; Tue, 19 Jun 2018 14:31:04 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Scott Branden Date: Tue, 19 Jun 2018 14:30:37 -0700 Message-Id: <20180619213058.12273-11-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.15.1 (Apple Git-101) In-Reply-To: <20180619213058.12273-1-ajit.khaparde@broadcom.com> References: <20180619213058.12273-1-ajit.khaparde@broadcom.com> Subject: [dpdk-dev] [PATCH 10/31] net/bnxt: code cleanup style of bnxt cpr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Scott Branden Cleanup alignment, brackets, debug string style of bnxt_cpr Signed-off-by: Scott Branden Reviewed-by: Ajit Khaparde Reviewed-by: Qingmin Liu Reviewed-by: Ray Jui --- drivers/net/bnxt/bnxt_cpr.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c index ff20b6fdf..7257bbedc 100644 --- a/drivers/net/bnxt/bnxt_cpr.c +++ b/drivers/net/bnxt/bnxt_cpr.c @@ -74,12 +74,12 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl) fwd_cmd = (struct input *)bp->pf.vf_info[vf_id].req_buf; if (fw_vf_id < bp->pf.first_vf_id || - fw_vf_id >= (bp->pf.first_vf_id) + bp->pf.active_vfs) { + fw_vf_id >= bp->pf.first_vf_id + bp->pf.active_vfs) { PMD_DRV_LOG(ERR, - "FWD req's source_id 0x%x out of range 0x%x - 0x%x (%d %d)\n", - fw_vf_id, bp->pf.first_vf_id, - (bp->pf.first_vf_id) + bp->pf.active_vfs - 1, - bp->pf.first_vf_id, bp->pf.active_vfs); + "FWD req 0x%x out of range 0x%x - 0x%x (%d %d)\n", + fw_vf_id, bp->pf.first_vf_id, + bp->pf.first_vf_id + bp->pf.active_vfs - 1, + bp->pf.first_vf_id, bp->pf.active_vfs); goto reject; } @@ -95,7 +95,7 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl) if (vfc->enables & HWRM_FUNC_VF_CFG_INPUT_ENABLES_DFLT_MAC_ADDR) { bnxt_hwrm_func_vf_mac(bp, vf_id, - (const uint8_t *)"\x00\x00\x00\x00\x00"); + (const uint8_t *)"\x00\x00\x00\x00\x00"); } } if (fwd_cmd->req_type == HWRM_CFA_L2_SET_RX_MASK) { @@ -104,10 +104,10 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl) srm->vlan_tag_tbl_addr = rte_cpu_to_le_64(0); srm->num_vlan_tags = rte_cpu_to_le_32(0); - srm->mask &= ~rte_cpu_to_le_32( - HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLANONLY | - HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLAN_NONVLAN | - HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_ANYVLAN_NONVLAN); + srm->mask &= ~rte_cpu_to_le_32 + (HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLANONLY | + HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLAN_NONVLAN | + HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_ANYVLAN_NONVLAN); } /* Forward */ rc = bnxt_hwrm_exec_fwd_resp(bp, fw_vf_id, fwd_cmd, req_len); @@ -128,8 +128,6 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl) fw_vf_id - bp->pf.first_vf_id, rte_le_to_cpu_16(fwd_cmd->req_type)); } - - return; } int bnxt_event_hwrm_resp_handler(struct bnxt *bp, struct cmpl_base *cmp)