diff mbox series

[dpdk-dev] devtools/test-meson-build: fix CC override for cross builds

Message ID 20180608103512.71263-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [dpdk-dev] devtools/test-meson-build: fix CC override for cross builds |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Bruce Richardson June 8, 2018, 10:35 a.m. UTC 
  For cross-builds the CC environmental variable only applies for compiling
native binaries i.e. pmdinfogen, so setting it to a cross-build compiler
will only cause problems. Leave the value unset in the script to use the
platform-default compiler.

Fixes: a55277a788df ("devtools: add test script for meson builds")

CC: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 devtools/test-meson-builds.sh | 1 -
 1 file changed, 1 deletion(-)

Comments

Thomas Monjalon June 14, 2018, 3:47 p.m. UTC | #1 
08/06/2018 12:35, Bruce Richardson:
> For cross-builds the CC environmental variable only applies for compiling
> native binaries i.e. pmdinfogen, so setting it to a cross-build compiler
> will only cause problems. Leave the value unset in the script to use the
> platform-default compiler.
> 
> Fixes: a55277a788df ("devtools: add test script for meson builds")
> 
> CC: stable@dpdk.org
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks
diff mbox series

Patch

diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index 9868c325b..f2ad05f32 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -41,6 +41,5 @@  for f in config/arm/arm*gcc ; do
 	if ! command -v $c >/dev/null 2>&1 ; then
 		continue
 	fi
-	export CC="ccache $c"
 	build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) --cross-file $f
 done