From patchwork Mon Jun 4 12:09:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 40621 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C010A7CC4; Mon, 4 Jun 2018 14:10:24 +0200 (CEST) Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com [209.85.215.66]) by dpdk.org (Postfix) with ESMTP id 7BA6C71B3 for ; Mon, 4 Jun 2018 14:10:12 +0200 (CEST) Received: by mail-lf0-f66.google.com with SMTP id t134-v6so24809060lff.6 for ; Mon, 04 Jun 2018 05:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UaQEPRKs4Xh2WIZ839oLE1Djxt7jqWhge+XQPF4BqBA=; b=YqxJrFTIFgJe2yzkxmT+Qp9WrXRzHYmimkqAGiDE8xWvRTtFeft+vbCCDyLOA8UxiD DriR2Hd8NLrie7yPYU3fFAPHkqd7dcfrJ3mxhpK5VIbtRrZjKN0SpIp9r7kvBvE8E7d6 qoz9wzBu2yTnxXKZ6N1zljvnJJtgo5MkKImH4Jc/VCki1cBvbxkZq26u3PPx9vhMigmQ fkqCrGWtIUeQsIxj3YXtxxDv7WPhNeHrHR5JT3VwLB6JoDNmIgh5Je9sv+s9f0HIEDu6 JTabx3YtJSsOHby6vSZap6ZkHDHpbHmR6pJmH2FKOP1ehQg9Fk+M0ynY1RrFqBl7T2ng r8zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UaQEPRKs4Xh2WIZ839oLE1Djxt7jqWhge+XQPF4BqBA=; b=uVDrQ+f/Dl3ERXoXJcW+j/bb5RQgAwHe12eVWoxqau0YH13SjMIKDxzF3iSRAEqnwy zS62tl3rmoNGxlMr3DiTTsfSYkm2ILxJv+ceL3hKpDfAVLQePvSoECRdWS4fjG7lpY3D 8QCAgagzS07qCjtxFCZTb9D07oDIBG0OeVjx5fUE73Ugv4KYfFG9Y0blS7KgUvuKy+WJ ikxCfQ1fykBaz1VJ/fUk/9MYOYqbXXYqIPh4+iqikQlFuNr6zT3bsMCSBtMjHmg3UBth TBUn4ICAyIroZtq2fmmNBq7dxJdkDBHnBNAIyKFySxtCTJxLBbGFu/X4lw97bVsqnH7K c4UA== X-Gm-Message-State: ALKqPwdIb0zeiIA8Z5SFjNbFJSrIUxpG/Wom6Q84e4NV4GYeqA+QwsNk iVAgIFcdceMabK5iVkAJNFMBZg== X-Google-Smtp-Source: ADUXVKJquHsMc0Nqe8YafnfHWpSuKNAOZoMewnDF0RAlRbsWavKLL8LSXK1bABRchUpIGtGQv6mtOg== X-Received: by 2002:a19:f03:: with SMTP id e3-v6mr13307220lfi.145.1528114212177; Mon, 04 Jun 2018 05:10:12 -0700 (PDT) Received: from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id g23-v6sm3817415lfi.49.2018.06.04.05.10.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 05:10:11 -0700 (PDT) From: Michal Krawczyk To: Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik Date: Mon, 4 Jun 2018 14:09:47 +0200 Message-Id: <20180604120955.17319-10-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180604120955.17319-1-mk@semihalf.com> References: <20180604120955.17319-1-mk@semihalf.com> Subject: [dpdk-dev] [PATCH v2 19/26] net/ena: add (un)likely statements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rafal Kozik Add likely and unlikely statements to increase performance. Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 4b853a964..4d4210040 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -936,7 +936,7 @@ ena_calc_queue_size(struct ena_com_dev *ena_dev, if (!rte_is_power_of_2(queue_size)) queue_size = rte_align32pow2(queue_size >> 1); - if (queue_size == 0) { + if (unlikely(queue_size == 0)) { PMD_INIT_LOG(ERR, "Invalid queue size"); return -EFAULT; } @@ -1360,7 +1360,7 @@ static int ena_populate_rx_queue(struct ena_ring *rxq, unsigned int count) } /* When we submitted free recources to device... */ - if (i > 0) { + if (likely(i > 0)) { /* ...let HW know that it can fill buffers with data */ rte_wmb(); ena_com_write_sq_doorbell(rxq->ena_com_io_sq); @@ -1466,7 +1466,7 @@ static void ena_interrupt_handler_rte(void *cb_arg) struct ena_com_dev *ena_dev = &adapter->ena_dev; ena_com_admin_q_comp_intr_handler(ena_dev); - if (adapter->state != ENA_ADAPTER_STATE_CLOSED) + if (likely(adapter->state != ENA_ADAPTER_STATE_CLOSED)) ena_com_aenq_intr_handler(ena_dev, adapter); } @@ -1856,7 +1856,7 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, mbuf->data_off = RTE_PKTMBUF_HEADROOM; mbuf->refcnt = 1; mbuf->next = NULL; - if (segments == 0) { + if (unlikely(segments == 0)) { mbuf->nb_segs = ena_rx_ctx.descs; mbuf->port = rx_ring->port_id; mbuf->pkt_len = 0;