From patchwork Mon Jun 4 12:09:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 40603 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4FF085A44; Mon, 4 Jun 2018 14:09:42 +0200 (CEST) Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by dpdk.org (Postfix) with ESMTP id 5D39D5A3E for ; Mon, 4 Jun 2018 14:09:41 +0200 (CEST) Received: by mail-lf0-f65.google.com with SMTP id r2-v6so24793073lff.4 for ; Mon, 04 Jun 2018 05:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KYH+vwpw20BPr38R6yeZAdht55jH22sCVaFlTJjcbD4=; b=e2CI/vdUsE1Y1pR6S7+TwIF+O+xwjY/M9eMlEzV3oXrz4RVFJM71zIoz4TE4Z+4jzs e6nJp0rAxT/PNnbwAWa4i47R81yRVqnu96jqvX6LXP81LK7Wjb0GGMmm9/6VsK1gWQQ7 XtxC57Ur9Y8Sn9AMKlNrSLmz//3QYSUz2NzPytiPG3YJ2VqaOwyPZRfqY8UgxBVdJw1c T+WOwuIZel2L13Uk9BSrzHDCJt4+aD7fymX/FFtLtAgzrtbJ4ZZtws4Bz+Exr+YaNsSy mDAEO2p7+3YMepPkYZ4seRCZ/XnuC64PokplctK/8suFEAqI41NJKmQljs9aeEPlG0h8 uU4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KYH+vwpw20BPr38R6yeZAdht55jH22sCVaFlTJjcbD4=; b=DNbRH1oTvK4DIGNnxVI23brMmKiFZ/eKAM/3amVIF5LsDeS+odIwkUpkGs2GHT4TR5 dXp3kkX95CW1Tg4YYtpGUgpS/Stn5UFU0/iiUS68kswiUJFnO+zZj/a7q0rTgnTo95rE GtPe8PVMlbInhaIbx6iXKqTjG7HaE9brJ9XtP4f+kD1wVo8ZNmlbjsYy7mLwYAkGnt2f JotqMvK/GkeikOWnlJ0qt23MKU4QFhFTIOKl0j9JcZ7aeu4KsEraN1q0066LF8KdxO/0 sYmCyueUMV5WW27X9Hbl3HkiC0yB4oSRJPyw5nFl0xb0SSKpwwI/f4gKXsEYnMqu1aSg 4IhQ== X-Gm-Message-State: ALKqPwcgTBPoaZSn/CV6OLlTu0yrNf0RMhwTz21sEbq7SbB6GSLjpUtw hQ368qK0Ce1Nr0di1D7EpBowqg== X-Google-Smtp-Source: ADUXVKJwqxnXo0XdD1Ycx7MBrJdbnDP1F4g7wx1Zr4Tb0MM9fVi0WM8v/6tH/pPQgZ8Q9VTwUEbjUQ== X-Received: by 2002:a19:be53:: with SMTP id o80-v6mr13280009lff.140.1528114181023; Mon, 04 Jun 2018 05:09:41 -0700 (PDT) Received: from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id h24-v6sm391607lfc.63.2018.06.04.05.09.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 05:09:40 -0700 (PDT) From: Michal Krawczyk To: Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik Date: Mon, 4 Jun 2018 14:09:27 +0200 Message-Id: <20180604120933.16955-2-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180604120933.16955-1-mk@semihalf.com> References: <20180604120933.16955-1-mk@semihalf.com> Subject: [dpdk-dev] [PATCH v2 02/26] net/ena: remove support of legacy LLQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rafal Kozik The legacy LLQ should no longer be supported by the drivers, as this API is deprecated. Because of that, it was removed from the driver. Signed-off-by: Rafal Kozik Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 29 +++++------------------------ 1 file changed, 5 insertions(+), 24 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 40e669613..171655d33 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1327,16 +1327,11 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) adapter->regs = pci_dev->mem_resource[ENA_REGS_BAR].addr; adapter->dev_mem_base = pci_dev->mem_resource[ENA_MEM_BAR].addr; - /* Present ENA_MEM_BAR indicates available LLQ mode. - * Use corresponding policy - */ - if (adapter->dev_mem_base) - ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_DEV; - else if (adapter->regs) - ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; - else + if (!adapter->regs) { PMD_INIT_LOG(CRIT, "Failed to access registers BAR(%d)", ENA_REGS_BAR); + return -ENXIO; + } ena_dev->reg_bar = adapter->regs; ena_dev->dmadev = adapter->pdev; @@ -1353,22 +1348,8 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) return -1; } - if (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV) { - if (get_feat_ctx.max_queues.max_llq_num == 0) { - PMD_INIT_LOG(ERR, - "Trying to use LLQ but llq_num is 0.\n" - "Fall back into regular queues."); - ena_dev->tx_mem_queue_type = - ENA_ADMIN_PLACEMENT_POLICY_HOST; - adapter->num_queues = - get_feat_ctx.max_queues.max_sq_num; - } else { - adapter->num_queues = - get_feat_ctx.max_queues.max_llq_num; - } - } else { - adapter->num_queues = get_feat_ctx.max_queues.max_sq_num; - } + ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; + adapter->num_queues = get_feat_ctx.max_queues.max_sq_num; queue_size = ena_calc_queue_size(ena_dev, &get_feat_ctx); if ((queue_size <= 0) || (adapter->num_queues <= 0))