[dpdk-dev,1/2] net/bonding: export mode 4 slave info routine

Message ID 20180517232252.19908-1-3chas3@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Chas Williams May 17, 2018, 11:22 p.m. UTC
  From: Chas Williams <chas3@att.com>

rte_eth_bond_8023ad_slave_info() wasn't exported in the original work.
Useful to extract information about the current 802.3ad state.

Fixes: 46fb43683679 ("bond: add mode 4")
Cc: stable@dpdk.org

Signed-off-by: Chas Williams <chas3@att.com>
---
 drivers/net/bonding/rte_pmd_bond_version.map | 7 +++++++
 1 file changed, 7 insertions(+)
  

Comments

Ferruh Yigit May 22, 2018, 10:05 a.m. UTC | #1
On 5/18/2018 12:22 AM, Chas Williams wrote:
> From: Chas Williams <chas3@att.com>
> 
> rte_eth_bond_8023ad_slave_info() wasn't exported in the original work.
> Useful to extract information about the current 802.3ad state.
> 
> Fixes: 46fb43683679 ("bond: add mode 4")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chas Williams <chas3@att.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

(Note, not get whole patch, only this one!)

The API seems added in 2014, not used in any internal tool and nobody complained
up until now, it seems not a popular one...

> ---
>  drivers/net/bonding/rte_pmd_bond_version.map | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/bonding/rte_pmd_bond_version.map b/drivers/net/bonding/rte_pmd_bond_version.map
> index ec3374b0f..cdd77df84 100644
> --- a/drivers/net/bonding/rte_pmd_bond_version.map
> +++ b/drivers/net/bonding/rte_pmd_bond_version.map
> @@ -52,3 +52,10 @@ DPDK_17.08 {
>  
>  
>  } DPDK_16.07;
> +
> +DPDK_18.08 {
> +	global:
> +
> +	rte_eth_bond_8023ad_slave_info;
> +
> +}:
s/}:/ DPDK_17.08;/

Fixed while applying.
  

Patch

diff --git a/drivers/net/bonding/rte_pmd_bond_version.map b/drivers/net/bonding/rte_pmd_bond_version.map
index ec3374b0f..cdd77df84 100644
--- a/drivers/net/bonding/rte_pmd_bond_version.map
+++ b/drivers/net/bonding/rte_pmd_bond_version.map
@@ -52,3 +52,10 @@  DPDK_17.08 {
 
 
 } DPDK_16.07;
+
+DPDK_18.08 {
+	global:
+
+	rte_eth_bond_8023ad_slave_info;
+
+}: