From patchwork Wed May 9 12:47:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 39589 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BFDFE1B65D; Wed, 9 May 2018 14:47:43 +0200 (CEST) Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 75FB61B63E for ; Wed, 9 May 2018 14:47:31 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id o123-v6so50752187lfe.8 for ; Wed, 09 May 2018 05:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zuaqcg21Uni2QO1PEVkgpMRwDUiciwcpo1ZhYkZL/Ck=; b=Xsa5ZRlq6EByGpKOGMrJppH2hK6YPcxQ6diKA5T4OWd0y6KxUBAjM1RBC10sXMjk2n gGwUnCAVT56pECQtljhfdQH1Of3FPsy5zf5uTiyx/qrg6R4RR3SqlOi3oJ6acTholOOc xoBt9adgLWYrBDtTKt3My+BbOJ7aA/dO/u+ycRHfjctqaKBUueaRDYR6ytIFwcQPKoAI gBsG+zGtX4+6Rq591b1oqyWO1rrdQLpHTHQ0XGucmGlH4AU3VGIqK1ScVut/w1M4Q1fx axfoZCBffFqAbNFiCOrnL184S65q6NND9CJoKrYR7vc/y4Y6+wLdC/erLNhu6bHpirho zU9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zuaqcg21Uni2QO1PEVkgpMRwDUiciwcpo1ZhYkZL/Ck=; b=UKPAXBsr5cIC1hVcdB+zMupf+7yt1PAGETV8jp0VM7NlboN5szHztV0r9DDUNyerdJ mNiVcaWdvbA3did7GVtkswqv1BrSGiz7zj6fXZ3PThjVj3qMYiZhu5qnewy6THO5M/YY yGBFxE3lEaml83QB06pVuMlVDl9utmgQ7hXRzmxkXUQVOtsHFzSV4xw2F8pUtfWUSWsw CX6QccGBu975AQj0y0ADgru3VYNMpoDBwXbpBoHs/Q9cRUzmDvx/gLN/4Z1BQ91+VSFS dAfVUIGKWeb21ktAic6k1Pgd+nQP3Kw4GBUbABaDGz8bpcpowtRClSwu9DVh+m3YMkTM qaAw== X-Gm-Message-State: ALKqPwcbFVl1YRuQibwyc/xTQ7spLJFZqb3yKLeNizjNSVrwhi6pjgnO 7ky2QGRXsjH2GrvOrP6fl9CkbcWMeFU= X-Google-Smtp-Source: AB8JxZpE4VQ47AsAIYhuM5pAsjvzhYX6F0RySRbea9PS0C1QVhi9rRwEIYIWRVdfpNaqa0342WZp5w== X-Received: by 2002:a19:ebdd:: with SMTP id f90-v6mr8285625lfk.20.1525870051118; Wed, 09 May 2018 05:47:31 -0700 (PDT) Received: from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id l10-v6sm5149258lja.62.2018.05.09.05.47.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 05:47:30 -0700 (PDT) From: Michal Krawczyk To: Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik Date: Wed, 9 May 2018 14:47:06 +0200 Message-Id: <20180509124714.23305-7-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180509124714.23305-1-mk@semihalf.com> References: <20180509124714.23305-1-mk@semihalf.com> Subject: [dpdk-dev] [PATCH v1 16/24] net/ena: unimplemented handler error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rafal Kozik Enable AENQ FATAL_ERROR and WARNING callbacks by setting flags in aenq_groups. They are handled by "unimplemented handler". If unimplemented handler is called, error is logged. Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.14.1 diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index c8ff62ccc..885d96b59 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1434,7 +1434,9 @@ static int ena_device_init(struct ena_com_dev *ena_dev, aenq_groups = BIT(ENA_ADMIN_LINK_CHANGE) | BIT(ENA_ADMIN_NOTIFICATION) | - BIT(ENA_ADMIN_KEEP_ALIVE); + BIT(ENA_ADMIN_KEEP_ALIVE) | + BIT(ENA_ADMIN_FATAL_ERROR) | + BIT(ENA_ADMIN_WARNING); aenq_groups &= get_feat_ctx->aenq.supported_groups; rc = ena_com_set_aenq_config(ena_dev, aenq_groups); @@ -2258,7 +2260,8 @@ static void ena_keep_alive(void *adapter_data, static void unimplemented_aenq_handler(__rte_unused void *data, __rte_unused struct ena_admin_aenq_entry *aenq_e) { - // Unimplemented handler + RTE_LOG(ERR, PMD, "Unknown event was received or event with " + "unimplemented handler\n"); } static struct ena_aenq_handlers aenq_handlers = {