From patchwork Wed May 9 12:47:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 39597 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A33C21B69B; Wed, 9 May 2018 14:47:57 +0200 (CEST) Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com [209.85.215.66]) by dpdk.org (Postfix) with ESMTP id 9CE7D1B656 for ; Wed, 9 May 2018 14:47:41 +0200 (CEST) Received: by mail-lf0-f66.google.com with SMTP id g12-v6so50761231lfb.10 for ; Wed, 09 May 2018 05:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Pm2eqVxHOtgpGMjweln+2YIu1SGbhO7QVkEQJg53TYI=; b=Kw6nXskG9pq3H1HrxFR/R6zfoxBD9nBKZhGDybw2c2JLfPzh6wLFV4uYch1Xj6MoSo 5k6nXFFKwkT1ZdbVR4by5Nm8wP/CH85rRRvPR0H4Lh6VMNPjJKpJwbddK2YbnDH4X/+6 iJSZiE4kBVucMPS1EJUjGFmu4QE1PEVGVovkw0uQTk0voiOpje0GaMMkPkXtaiCUy+/L FONPJaq2MchaFylO2RhM+PG48UsZeNtEKtFm9OAQs9N3C1HQHkdaQrTCb0eETGZktBEK NhH4fY7d0ThzZQZN03J24NUJBvw1FtDcCIg9hqp3bdNmrpKREyiF5qcj1tkvhcUvK4sO oTqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Pm2eqVxHOtgpGMjweln+2YIu1SGbhO7QVkEQJg53TYI=; b=doG/SuI0G4tPT9M53GY+o67hUtjw/IDXy5/7fEc99qGj15gEk6tQDrYPYKh7JIPRIg o3obXezpbET0SRjEOkK6OUDLL4U2pCcEn5JBJVWtt7FaH4DE70aR+BFIklcNZ5zceQFr Rch0x0OpiKaKgVnHz2+Svbyns9y9RaZuNAiff6RuwFPQel95whdk0cvQNf54pUoYWnAC NSUce2PMoJDd4g0zPNeXdUotNvxgvjgkpFt/6Q0V7bVtbutRau4GcCpeNHGFjuZXILIT NcbfN1lTZY181g/e5OF57BCC4/8NIDpW+W8JHXysz6hqCDAfOhEkrGI9250f/0+nzjbD +LDQ== X-Gm-Message-State: ALQs6tD5nqdaoBuKJfDGcBSCfOAF34gvXUUMekxInMhT8Xw0LZbmC7hi Av2wXivuqvn5Rg3uUUDNjcyUZw== X-Google-Smtp-Source: AB8JxZoRfQp8JHuVcHv2e/LgIS40fG82w+V1QMgmQYEK1/MYe1XZ3Al/jt6sm1QTyIw/GkuLtx8zRg== X-Received: by 2002:a19:2092:: with SMTP id g140-v6mr29851705lfg.38.1525870061317; Wed, 09 May 2018 05:47:41 -0700 (PDT) Received: from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id l10-v6sm5149258lja.62.2018.05.09.05.47.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 05:47:40 -0700 (PDT) From: Michal Krawczyk To: Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik Date: Wed, 9 May 2018 14:47:14 +0200 Message-Id: <20180509124714.23305-15-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180509124714.23305-1-mk@semihalf.com> References: <20180509124714.23305-1-mk@semihalf.com> Subject: [dpdk-dev] [PATCH v1 24/24] net/ena: fix GENMASK_ULL macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rafal Kozik When use GENMASK_ULL(63,0) left shift by 64 bits is performed. Shifting by number greater or equal then word length is undefined operation and failed on some platforms. Fixes: 9ba7981ec992 ("ena: add communication layer for DPDK") Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk --- drivers/net/ena/base/ena_plat_dpdk.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.14.1 diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h index b89cdb55d..58ef57d2b 100644 --- a/drivers/net/ena/base/ena_plat_dpdk.h +++ b/drivers/net/ena/base/ena_plat_dpdk.h @@ -116,11 +116,13 @@ typedef uint64_t dma_addr_t; #define ENA_MIN16(x, y) RTE_MIN((x), (y)) #define ENA_MIN8(x, y) RTE_MIN((x), (y)) +#define BITS_PER_LONG_LONG (__SIZEOF_LONG_LONG__ * 8) #define U64_C(x) x ## ULL #define BIT(nr) (1UL << (nr)) #define BITS_PER_LONG (__SIZEOF_LONG__ * 8) #define GENMASK(h, l) (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h)))) -#define GENMASK_ULL(h, l) (((U64_C(1) << ((h) - (l) + 1)) - 1) << (l)) +#define GENMASK_ULL(h, l) (((~0ULL) - (1ULL << (l)) + 1) & \ + (~0ULL >> (BITS_PER_LONG_LONG - 1 - (h)))) #ifdef RTE_LIBRTE_ENA_COM_DEBUG #define ena_trc_dbg(format, arg...) \