From patchwork Wed May 9 12:47:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 39592 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 022151B674; Wed, 9 May 2018 14:47:50 +0200 (CEST) Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by dpdk.org (Postfix) with ESMTP id F3EAC1B640 for ; Wed, 9 May 2018 14:47:34 +0200 (CEST) Received: by mail-lf0-f65.google.com with SMTP id q2-v6so5578460lfc.12 for ; Wed, 09 May 2018 05:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=O9727Z1wMTE2FCD/BWDUsLX2+pH3M3r51Rk/WxGiiLE=; b=BHpCBSH38bDegaZ4gADr63OxyT2IKHAfqITY81mXaceul9JkWMM8vkfTwgeE47Ibpa g3GKxlELz6BA3UCg8YtJMrVwX7mi4xh5Vd6WNMRxfopaZGksbQ6+MX3JA1AUVqSmqHeu O1GhQhs+P6gjHuG4+kbqXJYK32VU5VgfqVtEMFGydDhbt90tlw6kq4JzzRhWnIPrNPzR OWQ4atviC4KYBIifrQIwz0hEtLkFi4tWhEnxNIKOratJ6v219TLVcdF624RBO3ANhjow ylWAaTWeYEJQBJ8qIIpkT+CNn90a0BEFQouAdwvEbF5uTdLoswTwQDgEBCIkh9XCudWs CYPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=O9727Z1wMTE2FCD/BWDUsLX2+pH3M3r51Rk/WxGiiLE=; b=jM/g/sSQHsqn977Fge7CSiDNjQkIyVmlnWr0wCJUsfZXRXnn6pNhgtxskS7iZNFIbD 9+GdPJaW+25wLxEE3UfX6KEGN1H/WH7exgwcvdAUiaYxthrd37aWRLSQyOuJYbu+OAbn upZ39+A17itsoDjag2wLXJPyOwq/v8h1XEGYnUysDuQMCgK6a/OcRgCAfAHYqBrbeJVv 2UZjIUvcSNOqLC/xmtENMANRcsDHtVL+Fj/HR5qm6CZ/K2Hf7ST3rT2M2f2WNAbzsryJ sTYc/iB5mVRmT15OM1BY1LlWnXoa0Z5BaE/yFgXwge7h3qpTivZFV/ZUSObKkpAC4pa3 bDTQ== X-Gm-Message-State: ALKqPwcpDdAuToOJgGm0AQQMK4Z64nEiwCyy3HgXOgzWSNehpXyrDtRB vNkOeN3ow6vkwlI507EbN01HHQ== X-Google-Smtp-Source: AB8JxZoX8CH7uQtewUIE6t/x+sy23P77azMSkVPVj1WSSlXfko2fpwNXBlTEPIExxfeno4VVrE6LAA== X-Received: by 2002:a19:e45c:: with SMTP id b89-v6mr8007059lfh.48.1525870054626; Wed, 09 May 2018 05:47:34 -0700 (PDT) Received: from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id l10-v6sm5149258lja.62.2018.05.09.05.47.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 05:47:34 -0700 (PDT) From: Michal Krawczyk To: Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik Date: Wed, 9 May 2018 14:47:09 +0200 Message-Id: <20180509124714.23305-10-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180509124714.23305-1-mk@semihalf.com> References: <20180509124714.23305-1-mk@semihalf.com> Subject: [dpdk-dev] [PATCH v1 19/24] net/ena: add (un)likely statements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rafal Kozik Add likely and unlikely statements to increase performance. Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.14.1 diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 43e34a252..b3aa751e9 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -940,7 +940,7 @@ ena_calc_queue_size(struct ena_com_dev *ena_dev, if (!rte_is_power_of_2(queue_size)) queue_size = rte_align32pow2(queue_size >> 1); - if (queue_size == 0) { + if (unlikely(queue_size == 0)) { PMD_INIT_LOG(ERR, "Invalid queue size"); return -EFAULT; } @@ -1379,7 +1379,7 @@ static int ena_populate_rx_queue(struct ena_ring *rxq, unsigned int count) } /* When we submitted free recources to device... */ - if (i > 0) { + if (likely(i > 0)) { /* ...let HW know that it can fill buffers with data */ rte_wmb(); ena_com_write_sq_doorbell(rxq->ena_com_io_sq); @@ -1485,7 +1485,7 @@ static void ena_interrupt_handler_rte(void *cb_arg) struct ena_com_dev *ena_dev = &adapter->ena_dev; ena_com_admin_q_comp_intr_handler(ena_dev); - if (adapter->state != ENA_ADAPTER_STATE_CLOSED) + if (likely(adapter->state != ENA_ADAPTER_STATE_CLOSED)) ena_com_aenq_intr_handler(ena_dev, adapter); } @@ -1917,7 +1917,7 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, mbuf->data_off = RTE_PKTMBUF_HEADROOM; mbuf->refcnt = 1; mbuf->next = NULL; - if (segments == 0) { + if (unlikely(segments == 0)) { mbuf->nb_segs = ena_rx_ctx.descs; mbuf->port = rx_ring->port_id; mbuf->pkt_len = 0;