From patchwork Wed May 9 12:45:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 39577 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC7821B412; Wed, 9 May 2018 14:46:23 +0200 (CEST) Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id EFB6B1B3F7 for ; Wed, 9 May 2018 14:46:14 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id q2-v6so5572680lfc.12 for ; Wed, 09 May 2018 05:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GLnSH6RPB8CNNdNasAKT5tDHEXkpeAVTP8PCed43Pho=; b=cTHRhQEI62eriqHH7/B1RvrdLt/NOutzk70I8lAW+RBKBsKB/OilU9BcZSnSe0AdeV N8XU+6Vs8iJTB74VyQe4/RXnU6Tjjf0S//PXGbQewV7X5dIBEI1eDIc8jYYHxDNIH4bZ zfFoyKt4PZibK5MgKijL5Ake/mWKnfz9CTKxXHszCDm6hCtgp4iqxThtgMLXWwed7//z uMQEyshtIBy8r4vamKty5iNqJmVtAAhseGCL07NmLF5zwQ2y410cLcD10014lKIHgGPY G77tkL32+AvrF7vw5U/ECNLmeprF05ssI56c5O0OQxlp+Pjk2RppDs5mwaVx9j92YXml 4hqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GLnSH6RPB8CNNdNasAKT5tDHEXkpeAVTP8PCed43Pho=; b=rOQHJAtJ6uRnk1cYCZupy5XPLlBhcrJ1/E+l1h7NLDkk0r4JLcPZOUU8WY5NiQalia cZqGeQcFld7sjP5lHE6KnkNPsQ6lUUnwF+vYg3mD0JPa58eVyBdJT3Ot31axKHbOxGMy 8LiKn6Ds3Ak12NXjSBmO2ckiQnu3Rg3E8/GiksnGut//tIlShqfaOEvfIWVkI9Koe3Y1 1kMaig2D1eQaBS1E3iMzXF35D+JdC1S/YCAdORy6QYbsyVyMLiskAn/2hpNNFccir2hA tApxkst/iw5cuRgdoPRQKvvERK8qx6oa8rBMhnLX9/7MDryvMMj/O8kFfuw/KHwGaDCl G5NA== X-Gm-Message-State: ALQs6tBD8tQYHbRYImnHgL0aqEDSGu1LjeXWUyVc7ZiZ18UqeszFD58n QdzOXMZwBsXyE6dyC363nZXygg== X-Google-Smtp-Source: AB8JxZpUj9nl4DKWdE8q5BUUOmKjgAaHDLoGG2+m4qDEu7Pt/Qu6zqOd9bSwpMeCYwUvWIE47iKnGA== X-Received: by 2002:a19:2687:: with SMTP id m129-v6mr22470260lfm.132.1525869974509; Wed, 09 May 2018 05:46:14 -0700 (PDT) Received: from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id i6-v6sm5157497lji.49.2018.05.09.05.46.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 05:46:13 -0700 (PDT) From: Michal Krawczyk To: Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin Cc: dev@dpdk.org, matua@amazon.com Date: Wed, 9 May 2018 14:45:49 +0200 Message-Id: <20180509124552.22854-5-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180509124552.22854-1-mk@semihalf.com> References: <20180509124552.22854-1-mk@semihalf.com> Subject: [dpdk-dev] [PATCH v1 05/24] net/ena: add LSC intr support and AENQ handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" To make the LSC interrupt working, the AENQ must be configured properly in the ENA device. The AENQ interrupt is common for all maintance interrupts - the proper handler is then executed depending on the received descriptor. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 53 ++++++++++++++++++++++++++++++++++++++------ drivers/net/ena/ena_ethdev.h | 2 ++ 2 files changed, 48 insertions(+), 7 deletions(-) -- 2.14.1 diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index ef1b248dc..e9011e721 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -201,7 +201,7 @@ static const struct rte_pci_id pci_id_ena_map[] = { { .device_id = 0 }, }; -static struct ena_aenq_handlers empty_aenq_handlers; +static struct ena_aenq_handlers aenq_handlers; static int ena_device_init(struct ena_com_dev *ena_dev, struct ena_com_dev_get_features_ctx *get_feat_ctx); @@ -736,8 +736,11 @@ static int ena_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete) { struct rte_eth_link *link = &dev->data->dev_link; + struct ena_adapter *adapter; + + adapter = (struct ena_adapter *)(dev->data->dev_private); - link->link_status = ETH_LINK_UP; + link->link_status = adapter->link_status ? ETH_LINK_UP : ETH_LINK_DOWN; link->link_speed = ETH_SPEED_NUM_10G; link->link_duplex = ETH_LINK_FULL_DUPLEX; @@ -1243,6 +1246,7 @@ static int ena_populate_rx_queue(struct ena_ring *rxq, unsigned int count) static int ena_device_init(struct ena_com_dev *ena_dev, struct ena_com_dev_get_features_ctx *get_feat_ctx) { + uint32_t aenq_groups; int rc; bool readless_supported; @@ -1278,7 +1282,7 @@ static int ena_device_init(struct ena_com_dev *ena_dev, ena_dev->dma_addr_bits = ena_com_get_dma_width(ena_dev); /* ENA device administration layer init */ - rc = ena_com_admin_init(ena_dev, &empty_aenq_handlers, true); + rc = ena_com_admin_init(ena_dev, &aenq_handlers, true); if (rc) { RTE_LOG(ERR, PMD, "cannot initialize ena admin queue with device\n"); @@ -1301,6 +1305,15 @@ static int ena_device_init(struct ena_com_dev *ena_dev, goto err_admin_init; } + aenq_groups = BIT(ENA_ADMIN_LINK_CHANGE); + + aenq_groups &= get_feat_ctx->aenq.supported_groups; + rc = ena_com_set_aenq_config(ena_dev, aenq_groups); + if (rc) { + RTE_LOG(ERR, PMD, "Cannot configure aenq groups rc: %d\n", rc); + goto err_admin_init; + } + return 0; err_admin_init: @@ -1312,12 +1325,14 @@ static int ena_device_init(struct ena_com_dev *ena_dev, return rc; } -static void ena_interrupt_handler_rte(__rte_unused void *cb_arg) +static void ena_interrupt_handler_rte(void *cb_arg) { struct ena_adapter *adapter = (struct ena_adapter *)cb_arg; struct ena_com_dev *ena_dev = &adapter->ena_dev; ena_com_admin_q_comp_intr_handler(ena_dev); + if (adapter->state != ENA_ADAPTER_STATE_CLOSED) + ena_com_aenq_intr_handler(ena_dev, adapter); } static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) @@ -1420,6 +1435,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) adapter); rte_intr_enable(intr_handle); ena_com_set_admin_polling_mode(ena_dev, false); + ena_com_admin_aenq_enable(ena_dev); adapters_found++; adapter->state = ENA_ADAPTER_STATE_INIT; @@ -1899,6 +1915,9 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, return sent_idx; } +/********************************************************************* + * PMD configuration + *********************************************************************/ static int eth_ena_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, struct rte_pci_device *pci_dev) { @@ -1913,7 +1932,7 @@ static int eth_ena_pci_remove(struct rte_pci_device *pci_dev) static struct rte_pci_driver rte_ena_pmd = { .id_table = pci_id_ena_map, - .drv_flags = RTE_PCI_DRV_NEED_MAPPING, + .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC, .probe = eth_ena_pci_probe, .remove = eth_ena_pci_remove, }; @@ -1937,6 +1956,26 @@ ena_init_log(void) /****************************************************************************** ******************************** AENQ Handlers ******************************* *****************************************************************************/ +static void ena_update_on_link_change(void *adapter_data, + struct ena_admin_aenq_entry *aenq_e) +{ + struct rte_eth_dev *eth_dev; + struct ena_adapter *adapter; + struct ena_admin_aenq_link_change_desc *aenq_link_desc; + uint32_t status; + + adapter = (struct ena_adapter *)adapter_data; + aenq_link_desc = (struct ena_admin_aenq_link_change_desc *)aenq_e; + eth_dev = adapter->rte_dev; + + status = + get_ena_admin_aenq_link_change_desc_link_status(aenq_link_desc); + adapter->link_status = status; + + ena_link_update(eth_dev, 0); + _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL); +} + /** * This handler will called for unknown event group or unimplemented handlers **/ @@ -1946,9 +1985,9 @@ static void unimplemented_aenq_handler(__rte_unused void *data, // Unimplemented handler } -static struct ena_aenq_handlers empty_aenq_handlers = { +static struct ena_aenq_handlers aenq_handlers = { .handlers = { - [ENA_ADMIN_LINK_CHANGE] = unimplemented_aenq_handler, + [ENA_ADMIN_LINK_CHANGE] = ena_update_on_link_change, [ENA_ADMIN_NOTIFICATION] = unimplemented_aenq_handler, [ENA_ADMIN_KEEP_ALIVE] = unimplemented_aenq_handler }, diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h index 79fb14aeb..16172a54a 100644 --- a/drivers/net/ena/ena_ethdev.h +++ b/drivers/net/ena/ena_ethdev.h @@ -181,6 +181,8 @@ struct ena_adapter { uint64_t tx_selected_offloads; uint64_t rx_supported_offloads; uint64_t rx_selected_offloads; + + bool link_status; }; #endif /* _ENA_ETHDEV_H_ */