From patchwork Wed May 9 12:45:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 39573 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A87431B3EC; Wed, 9 May 2018 14:46:11 +0200 (CEST) Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 1A9601B3E3 for ; Wed, 9 May 2018 14:46:11 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id t129-v6so11464021lff.3 for ; Wed, 09 May 2018 05:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gimuVr5rYypmqQ4ss+xTWBNWE2bC6G+uEHCw/ulKfQo=; b=zoRs6XXzyYYcVgoajTbJlAz3mDZuIZr0NdJX+o9+ozxBBhvU702wiHdnE/DtN2QEvQ gfwpkmbLfh5HKtWLZu0eSRG3IJRSqVBK9vlqDuSlLko2TSbjc3hD4L/JqxkTpjkCa9ll AGiTyZb2FuS42R/GWsAxnQSkIe2MrXTwRgw3ln21Dd8ZMEXlHMiIzreV5Q3ORRoUI4nF 8IkJwzQl7XUsf9FTnwbr28riRSIrbw0e3M4G6vl744CNFKZDX1LPIZQN7nAtW+hgR9fk wkbVpoRUULKkamnraFT7sw9JTVHVWhXHjrOqBtzjXBdJyzk7VsuIA4ACT+c3Zjhfdu1v tFJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gimuVr5rYypmqQ4ss+xTWBNWE2bC6G+uEHCw/ulKfQo=; b=Xcp2yFC+iBbVZ1A0njNEJEFBPF76qgNn45ppN9Vjof1Pq4SE2TemzqcaB+CEfbFJj+ aPdQrt3HJnpMUJxsRuEuZr+7WrwC3NDCxt/sOGgb1za7VPXTskDVd0z21f1qpYrh7q3j 0QmTQebZDUDmZSpoWGssFIvrk8o2AUiSsBbpHtUia3OZ8/LaQ5ONGlOL1OY8vVKPqsAp XvkgW2wFbrbaLYKad2NhfmUOcprujoCQdDyEyIuHneygGbTqfECVoyBbJ6hY6ERHzBrN BWrSuG23ccCKw6d7NXfCx/ZLiklkgopJaaaT/eWKGOGMvPWJQKmwt1XyXEzmoHcWfpF9 p1TA== X-Gm-Message-State: ALQs6tCJgGbVk4pyM4+IFPNrGlBKtrdEAymeyOOXN3aNAcFuZPf5I8vK desYVtYFikGWgeOUELPSWTOGTw== X-Google-Smtp-Source: AB8JxZpAAf2rHcJKh8CVxijji/2EJ9tzpU0Zad3CBM74+oomKacR55bFe+Z1pzR/q0FbAlW1D104xA== X-Received: by 2002:a2e:90d4:: with SMTP id o20-v6mr26477725ljg.15.1525869970688; Wed, 09 May 2018 05:46:10 -0700 (PDT) Received: from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id i6-v6sm5157497lji.49.2018.05.09.05.46.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 05:46:10 -0700 (PDT) From: Michal Krawczyk To: Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik Date: Wed, 9 May 2018 14:45:46 +0200 Message-Id: <20180509124552.22854-2-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180509124552.22854-1-mk@semihalf.com> References: <20180509124552.22854-1-mk@semihalf.com> Subject: [dpdk-dev] [PATCH v1 02/24] net/ena: remove support of legacy LLQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rafal Kozik The legacy LLQ should no longer be supported by the drivers, as this API is deprecated. Because of that, it was removed from the driver. Signed-off-by: Rafal Kozik Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 29 +++++------------------------ 1 file changed, 5 insertions(+), 24 deletions(-) -- 2.14.1 diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 4c90e65bd..81e36b1ef 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1342,16 +1342,11 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) adapter->regs = pci_dev->mem_resource[ENA_REGS_BAR].addr; adapter->dev_mem_base = pci_dev->mem_resource[ENA_MEM_BAR].addr; - /* Present ENA_MEM_BAR indicates available LLQ mode. - * Use corresponding policy - */ - if (adapter->dev_mem_base) - ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_DEV; - else if (adapter->regs) - ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; - else + if (!adapter->regs) { PMD_INIT_LOG(CRIT, "Failed to access registers BAR(%d)", ENA_REGS_BAR); + return -ENXIO; + } ena_dev->reg_bar = adapter->regs; ena_dev->dmadev = adapter->pdev; @@ -1368,22 +1363,8 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) return -1; } - if (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV) { - if (get_feat_ctx.max_queues.max_llq_num == 0) { - PMD_INIT_LOG(ERR, - "Trying to use LLQ but llq_num is 0.\n" - "Fall back into regular queues."); - ena_dev->tx_mem_queue_type = - ENA_ADMIN_PLACEMENT_POLICY_HOST; - adapter->num_queues = - get_feat_ctx.max_queues.max_sq_num; - } else { - adapter->num_queues = - get_feat_ctx.max_queues.max_llq_num; - } - } else { - adapter->num_queues = get_feat_ctx.max_queues.max_sq_num; - } + ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; + adapter->num_queues = get_feat_ctx.max_queues.max_sq_num; queue_size = ena_calc_queue_size(ena_dev, &get_feat_ctx); if ((queue_size <= 0) || (adapter->num_queues <= 0))