From patchwork Wed May 9 09:20:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 39532 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21BD7AACE; Wed, 9 May 2018 11:04:43 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0045.outbound.protection.outlook.com [104.47.1.45]) by dpdk.org (Postfix) with ESMTP id BE29CAAC8 for ; Wed, 9 May 2018 11:04:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eGYlI8u8N39L2YD0Tzv+YrJ9Yg/u5TP5wI6oCcyR3/4=; b=Kj3+X+/XZ+I9ue4o566cs8B5ji97cF4F3S5l2lQP0YfkLJfi+1r2SBs/OdAjzfwc3fQYk5fBHR60DaQ5L4cbarZNlUCU76S+1Xhe2d7+smfxTYwk1CJP8cGVYlKpoQLKSATUF3zZ1MQwMIApWG6F/YgLJyjarU1FI8X2ImijqVY= Received: from Tophie.ap.freescale.net (14.142.187.166) by VI1PR0402MB2782.eurprd04.prod.outlook.com (2603:10a6:800:ad::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Wed, 9 May 2018 09:04:38 +0000 From: Shreyansh Jain To: jerin.jacob@caviumnetworks.com Cc: dev@dpdk.org, hemant.agrawal@nxp.com, Ashish Jain , nipun.gupta@nxp.com Date: Wed, 9 May 2018 14:50:53 +0530 Message-Id: <20180509092053.5956-2-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509092053.5956-1-shreyansh.jain@nxp.com> References: <20180509092053.5956-1-shreyansh.jain@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: HK2PR0302CA0005.apcprd03.prod.outlook.com (2603:1096:202::15) To VI1PR0402MB2782.eurprd04.prod.outlook.com (2603:10a6:800:ad::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0402MB2782; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2782; 3:o4KwPazJkKaTdi1uHQkJi/mqG9gHj26VETIMgmyk9G4tg/f49Lgs9KHkrFqgF6AwkisNZhfS+gCl4H18ikETubC+dMWwsfgSlHDvQ90eyIoB2JiQZHoGJAmVo1atjw+4nESV/bY3xSjNc9Y2Bm1DBlEWCHJsVNgTBNcILPKwPx9+vz25Qc3mda4iK2+4qNILsntkQx6/zWQH1TwLBZw2cZf6bvaJ9yBqKDp9oQFDSF+HZxRRQm/4RNPrRxNOg6JV; 25:9/A2Gw9trj5yvyUZWiYUIxyZ2bHDw/eKLMx5tYEd4/Uom0iSpYVnqbSZFTw4ifHr6zK5sZ9OIyqEalGO/xfiIeic6SzBZUetacT/0n/mStjHp3Lm5tgtfEmqIMCUa6jOKImo/vEnrZvHYfCQk+gxJif6BDhthbd+A8vkP4yC3J2DeUbxjNChXmWWWjVifgnnFbRZvlMK3FLDKxo4Zu+R002u0X8m4s+To8bga//yiwpLXFFiIKkgizhIaIxsmVWsPkIxnGvBq+X/ryD5fFTn/Jt6Pb2D8tGVIZncs3W6i0G0qafu3B20g5OmshEUU+p+wD4CdwWeOnagyiAt8kkJqw==; 31:oCfmqMaS9OQhbQ9xt2dOIXxyLrkRlwRCLA/nnW/jDR0xLjY0/+nFAI/WvA8W5JnBTuEbKbvXUynVEddmLw2gPjwm7GBPzLhpMcgLwaksM+CPrW/43zCSaAHr5KYizDiQuC6LWxNtGPtTF1tOiQmH0JYAyxN3EyOoD6SqO6NTJJ306HQ+hGJw5Bb0xM7PkYAGSzZE5iRNaAEfbgJY72zMkOrtDlzoZGaFbQOUnNZ1kco= X-MS-TrafficTypeDiagnostic: VI1PR0402MB2782: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2782; 20:X0O2H45mfFQXZLvpA1TdZ/NUU6uLg6Oh1G9mEpWP0MKACrzID6/eoqKCLoeqZhOagrJJsWOfclgjoEjba8jzQPJb0Fk14/xxER0hdwelbuU0ddkqAoZG5iX1LPUZ9Mvd+NUAfJyPyKV9dVgyYIXVQW6GiliPh/iAhk9V07+GONn/rjssHHQpq2JhoaX7raGrNAL98fXXgort6OX2kA6rQWEQ/0yMMJc5oxk65aPAeBE6PrrhdWjLgTdZaxORCoqMgkYkyqKUQHzaqYmruqQYWT5WXeIRrJKKZMqOadp8FT2AQjvP7oGcKKJcDahWxZA041ifirP97B/yXdqewCSiv+WPluFGg4qoTSKnZQNIMU+ffAXoQ1Phy9wubUPmqoYq3mXc3VxcMtmS0xymPx6VFjsPSjGqdxkN6AYCPIlh7ze4bRz6ifx4awJjjOkTzQZas4cZ3yi65ARV2JWSgKlQ7VsJ1BzBdnsmnglnQa1e1WhN1MUyhwul5PJopNvh3C4/; 4:8Bwc5jWxkLac2xia8H4Afjr+d6q8oQcPONo1gqdylxEq94Q2NZ1IjKbY+NlpoQbekt2Cnh5v9BPFF/1IA4zIiO9gd3iK/A+qD2K0Slt+NLGbFJd6BiVRPWf66m6JfPzq70aQxY61qD240lfyc/sEK2QFyh0td58lImutWNUgdBjCSdAIjFQzpqSOs9X0hImukHJpcfI2QoY4kfAwRB9ni4Ydy8Z7sm8WmDmWxIM9je9XFbRvTxQtw4aP1av+FuGb2/HdZA1czmWfpOnaYIlEXiBY5dUORMHoK+hhi1p5Gxg+I6YWKYRxMz34sYKXf4ix X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR0402MB2782; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0402MB2782; X-Forefront-PRVS: 0667289FF8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39380400002)(376002)(366004)(39860400002)(189003)(199004)(5009440100003)(66066001)(47776003)(50466002)(3846002)(6116002)(97736004)(25786009)(48376002)(1076002)(305945005)(8936002)(50226002)(7736002)(105586002)(4326008)(68736007)(106356001)(2361001)(53936002)(6512007)(478600001)(81166006)(11346002)(2616005)(76176011)(51416003)(476003)(52116002)(44832011)(6666003)(486006)(55236004)(6916009)(86362001)(956004)(16586007)(446003)(26005)(316002)(36756003)(186003)(386003)(6506007)(2906002)(6486002)(8676002)(81156014)(16526019)(5660300001)(2351001)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB2782; H:Tophie.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0402MB2782; 23:yGdR1mM+rTIZNl+8BVq4koYhke+ReaCgW6LVSrf?= W6KDtMOKlgFXM3sR/EfguCCo900yB6aIHwzR/oqwzeAsLq9kfMI5JhpOO7+KxYZYp0hzMmiYuVpYOOuAz3u0HE26Jxikfjzbik2u8A/i0JCRfxW7jyM3um0uwQfywJMpTtbhsrWv7GXcjDaJMSKH4p3nFGgP6lraQRHXxUx9bE+QaePNcVDA50MD3u1n2SuCVUjBHfSnufic82iBm7zT08PoDcfPAtqBjB9VQbHh13MUBtRYREJyrlZ5A1COaGVkNiov2L5/hFgeQdED8P7Y2kOg+wMftSaSN6dX7z1c9Z4bKBxBg9wbbJmUVg46BBhfg+Om0cxSOEIf9lFYJiCYk35RKF8+Q/HkML5mlOmy+W/k/zYoYvRJD5qf3ID8YpVNuRoM+8A3Ba8FdrEPSS8liHRfJWd751mxa3+Uh8dGIc3eEzXvUe3y/5o1goSxUxt/s5zdY+XPJ9FTag22mqrJuXvpvXVGoRsUNeShzbTt12iW4iYX8ZBaoKpACXVaOZyLxL4BvvVwd2XKiWqQHCRh9KiHGQTlMfkvD5wGW2ciZsvPDuhGuQx5uWngvuWBswoaXmDZMkW2ssP8wKzDBC4jHHGQcxEfF+A8D90gj6G8GRGqO/OPVJXEUD2ewysbji04bYjzPEt9gfGhuZhpod9nJ2SjU70G+kwhD/rqZ7GVxCHfu4U5HK8S/tTvLuuDx7fZBV1v5q9sTqEh/A+HdVH96ittAxvBLnqRoiVmp9Wt4spk1HA43IACX89BuK7CZg0mXgQV5bwrLki2L/ary86gWi5ScM77S1KqEdo7nKXcqaEuGc/eWK6vyGMkX0VuoaBA1rMaSE5IQs7Oe85DoFTbq/9b1uNu40XkNiF/X8PmyehJY/MWW1FMdJqNQ2qD7dbwR/i19L18ApFGV65V+KCzueWEVQlYjG/LoTh1F+nuVDtrYjp5H5CXuHFPiK2omFqfRR+v4kDkMUhQAwSQKDMBEf+eAgGiaEJyzf4rQlLgCelniZ3cCDiwJVbZ9o8n/P8muIJXWXPTFKwJTyxgvqluYCTdgtLHBLywhouoS6b1dqPcDML1X6zfReFVynCfu/lfkgdNUgokLxUHeKnHi9OD3749f1tlF6cmoJ0+cSxon5E4Gb2y7mbNaI7oaB085OekIJmh9dmfW9hghzeq5HdJG61rrDDCc8FkARGSVeC3VLUVU1HdPnv+zvCkaW+KSMH1wtARTcguHCYVsjf3gOMDlXc9mjGntU97uRQc84m4KoVX+RHuQKW4gjBqjTh0CmtoteO01ARs3HVPkD63H2B0AMhiG X-Microsoft-Antispam-Message-Info: AUVzdlBOlTO17/4IN23ym1AOSpKuPKx2f8LUFGsr85yEI9WLpot/yJmeSuC1c/GdGoh0k6drJky9GCq2fUtpaPvfNShtPY1zSHsnXtLVflq5vqGl02F/H6BT3+nBjaCbKUQX0p3qNUusec71eaoZoR7LXKrvKX/g9TNQQvjlqGt0+vtpKL0z1+0MQ42/Iln6 X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2782; 6:GNwreh7Q2rB/8VzpIq4ELbUD6ta7VtFDaOVI1RzDiuvXNzWedNc7uRLsPE7YBCw16o4L4mNHikZUMpplcVySD1ZTx1aMECf5Jhfl+2KqxolQCrMaiztNUvwrcqgWsSRvXpWNk55dZthuQLwTN64569P2UII4INz3CVIIyAk6B6eduqUqd9weqkpW5r8x6jyWxfi6MIcnRO1a2d16TLU8uTdpapGdyIrJlwric/Ol16w9LX7fzYDA/RYbLf7dFzUZhY1HmqaJ76RuoX5k2UqslUTTTD3zcovvr94jSuQNRn5yhBcomNABwHh67Hmhdjv4W+97k5eGD/tuvlTx4ojfpeOEfdHAuMAM276s1QPsZ+fkLNkRjCNL0dNpPtuqDzxeL12maB0c7IZcgwoIspK0/v7K/K508HqNU8sV44uW7ayC75Nu8bvgbJ32Fw7C5n9K4qMa08d6ZH0MugMVGj+n7Q==; 5:6DqSY0Eqyafy+qfKSwE0rd6lNL9MH6JnS23/k1cIAI/p06jyD8UNxD4W0LhDdEEO4Eaq2TuG/zKbJLqntOO6th8rOAp7nszpnkMxq4ObR2I0lKxurUuU+5/5/yhWklCduGdoapL56B8J+m5DyJqtxosmVrHTK8zhnNl61+wIO9U=; 24:L0joNtZSCfQoVl7DZIg/lqCEYuaDkxzQ5mjY5HS9H9QHyarXjQwJiIqSYCBZ7S6iqvHe/m4Zqca0G8HyNWAYSKrzjmlULvqURBmsXzkZI1s= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2782; 7:2zzgUEL5N9TyvitSSI8tS/gDPMdCMk7AqCvsFQGvG2mlG3EoKoZRliSCf3GYoOeAkuuWDWaiGuzO6OgTvk4um4fqsLFvbzeb0kyi4P2UTOmjBdJPHsF6KiBNjHTwYYG8kxYDq/1RV1G4JXNKnmjyK3MT8wPcn4fticM7Zsh9PyNVhIjzW1ulBt2xPwJHx+6M/JAAgZ0JUf1dAVV8AtIGLw7T+gPbRSBRn/POcN4k7Yi+/AvF2AuJE/7lCEjRqkCx X-MS-Office365-Filtering-Correlation-Id: 909dd037-a239-4e46-b237-08d5b58be5fd X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2018 09:04:38.3202 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 909dd037-a239-4e46-b237-08d5b58be5fd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2782 Subject: [dpdk-dev] [PATCH 2/2] event/dpaa2: Remove usage of link under evq_info_t structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Ashish Jain Removing use of link data under evq_info_t structure which was used to check whether the the associated evq has been linked or not. Since, an evq can be linked to multiple event ports, thus setting the link variable only allowed the first event port to be associated with the evq. This led to huge performance drop in case of multiple event ports as I/O only worked on first event port associated with the evq. Fixes: 0ce3ce7c275c ("event/dpaa2: add configuration functions") Cc: nipun.gupta@nxp.com Signed-off-by: Ashish Jain Acked-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 5 ----- drivers/event/dpaa2/dpaa2_eventdev.h | 1 - 2 files changed, 6 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 08388c7bc..cd801bfb1 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -460,7 +460,6 @@ dpaa2_eventdev_port_unlink(struct rte_eventdev *dev, void *port, dpio_remove_static_dequeue_channel(dpaa2_portal->dpio_dev->dpio, 0, dpaa2_portal->dpio_dev->token, evq_info->dpcon->dpcon_id); - evq_info->link = 0; } return (int)nb_unlinks; @@ -481,8 +480,6 @@ dpaa2_eventdev_port_link(struct rte_eventdev *dev, void *port, for (i = 0; i < nb_links; i++) { evq_info = &priv->evq_info[queues[i]]; - if (evq_info->link) - continue; ret = dpio_add_static_dequeue_channel( dpaa2_portal->dpio_dev->dpio, @@ -497,7 +494,6 @@ dpaa2_eventdev_port_link(struct rte_eventdev *dev, void *port, qbman_swp_push_set(dpaa2_portal->dpio_dev->sw_portal, channel_index, 1); evq_info->dpcon->channel_index = channel_index; - evq_info->link = 1; } RTE_SET_USED(priorities); @@ -511,7 +507,6 @@ dpaa2_eventdev_port_link(struct rte_eventdev *dev, void *port, dpio_remove_static_dequeue_channel(dpaa2_portal->dpio_dev->dpio, 0, dpaa2_portal->dpio_dev->token, evq_info->dpcon->dpcon_id); - evq_info->link = 0; } return ret; } diff --git a/drivers/event/dpaa2/dpaa2_eventdev.h b/drivers/event/dpaa2/dpaa2_eventdev.h index 91c8f2a35..229f66afb 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.h +++ b/drivers/event/dpaa2/dpaa2_eventdev.h @@ -63,7 +63,6 @@ struct evq_info_t { struct dpaa2_dpci_dev *dpci; /* Configuration provided by the user */ uint32_t event_queue_cfg; - uint8_t link; }; struct dpaa2_eventdev {