From patchwork Thu May 3 19:37:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "John Daley (johndale)" X-Patchwork-Id: 39361 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E56B520BD; Thu, 3 May 2018 21:45:25 +0200 (CEST) Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) by dpdk.org (Postfix) with ESMTP id DC58E23C for ; Thu, 3 May 2018 21:45:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1030; q=dns/txt; s=iport; t=1525376724; x=1526586324; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=FkvNuU82Ku0bIRMj6grDO3XwtEyvdTMeCRrZahBKuoQ=; b=AoAXysDFSr6h3T3u2t6oWo1gkxOITXoe6qjhmqJ+6B/SmityUP9ij111 JHRgAl+8zPVIRR/WPD7pf2/cX6y/DzlbfVO9uR99C/t+jHk2YpVORiIP1 /uIyBwO1rbjQKmKyTQI2yRk/8MfTW0VzByrP5gRU7dBkGFvSk7nGyWHby U=; X-IronPort-AV: E=Sophos;i="5.49,359,1520899200"; d="scan'208";a="388253894" Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2018 19:45:23 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by rcdn-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id w43JjM0F024776; Thu, 3 May 2018 19:45:22 GMT Received: by cisco.com (Postfix, from userid 392789) id 8EB5020F2001; Thu, 3 May 2018 12:45:22 -0700 (PDT) From: John Daley To: ferruh.yigit@intel.com Cc: dev@dpdk.org, johndale , Hyong Youb Kim Date: Thu, 3 May 2018 12:37:10 -0700 Message-Id: <20180503193713.20622-3-johndale@cisco.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180503193713.20622-1-johndale@cisco.com> References: <20180503193713.20622-1-johndale@cisco.com> Subject: [dpdk-dev] [PATCH 3/6] net/enic: set rte errno to positive value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: johndale Related to d9fff8a31, where rte_errno should always have positive errno values. Technically this is an ABI change since it fixes an error code introduced in 18.02, but is minor and inconsequential. Fixes: 1e81dbb5321b ("net/enic: add Tx prepare handler") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley Reviewed-by: Aaron Conole --- drivers/net/enic/enic_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_rxtx.c b/drivers/net/enic/enic_rxtx.c index aa3393700..8853a2044 100644 --- a/drivers/net/enic/enic_rxtx.c +++ b/drivers/net/enic/enic_rxtx.c @@ -510,7 +510,7 @@ uint16_t enic_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, m = tx_pkts[i]; ol_flags = m->ol_flags; if (ol_flags & wq->tx_offload_notsup_mask) { - rte_errno = -ENOTSUP; + rte_errno = ENOTSUP; return i; } #ifdef RTE_LIBRTE_ETHDEV_DEBUG