From patchwork Wed May 2 15:28:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrien Mazarguil X-Patchwork-Id: 39240 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8C50DED; Wed, 2 May 2018 17:28:51 +0200 (CEST) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 820E123C for ; Wed, 2 May 2018 17:28:50 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id f6so23538720wmc.4 for ; Wed, 02 May 2018 08:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=UAye+yWxYlDaexaoJdzoqH3HLPH4NBZI0vpT+HNSFhA=; b=Um/kpb/3ZRfOEtb9vPHg+UdqY4zrL9J/B66Nf23o5lNN12uMKKktqc1+ZuELdk8z9l 2nDPByIpbO4wIB3O3wDjstMGjW7Uqi8Z3Uc7dk5AOHlrlt8XB1z1FfazXflKouWoHhAr 4b046r6K8KRW3fzFrtpeL6KGsrlkZMGcDluxs/2kYd3rOVGkliTNJ+QPf71xig8aAD/j Y5N+z/scphXhVIbV1BhuLe0m4bt/BAqfHIsDTCimw4RhGC8ThecZ5YZf2tlY/Ayd2TCG Z7oSjF1oP/Uz3gnDK/1WyYhi8aJVU+2/6xVZ6u40Le+u6DMiGY4PH8PvujdPS2VlRsoU 7sOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=UAye+yWxYlDaexaoJdzoqH3HLPH4NBZI0vpT+HNSFhA=; b=YFE6rCLZ52YWgfAmnxL3zqDh9KVYPVquSvjoTm2kXwYCSLjOlBbclvjncYOvMG+YIV WISp0i0iqVC3STIYv1kGYgMyO5fqLFwXM7aA+5UiCfVovFhWnWWj0F0pT7UqIE3kECpF 3fUgAzWQoOiU4zdu9Xnv3AU8uT+SoLsyOf1ZkvL7Su4T6GK3U+uSZoiIWLoLwuQoPZCo N/6nnkNJ57kSKSyvsfY27byMKp8LfZOEdBEKsbK2CrnHFqb9ZjcUYiwmbCRB2WrYueOq ndFsZJtm2efRlnT+IOkT447ebdeeKoWZnj0jR/WYrpghGTGc+3nVGzw2kWSgQf6XM4Ho tvgw== X-Gm-Message-State: ALQs6tD8Q2Cw1sWVKdezlW0gXJYJC9mQlxhz8Bhe2B9lXpHjLWTXxVRw TVVxks+n/5EGQdAgqaNkiiwGEQ== X-Google-Smtp-Source: AB8JxZqPqj0ZxmA63SR82rQbGS8AsZVSWj/WHfOE+ucLKZ4rLvLxHdsCnEf1BtvqH9rfXUBLqdGsRA== X-Received: by 10.28.92.213 with SMTP id q204mr1885415wmb.158.1525274930246; Wed, 02 May 2018 08:28:50 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z11-v6sm12026399wre.15.2018.05.02.08.28.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 May 2018 08:28:49 -0700 (PDT) Date: Wed, 2 May 2018 17:28:35 +0200 From: Adrien Mazarguil To: Shahaf Shuler Cc: dev@dpdk.org Message-ID: <20180502152554.23257-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH] net/mlx4: fix compilation issues in glue mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since the commit referenced below, compiling mlx4 along with its glue library (CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS=y) triggers a compilation failure due to undefined symbols. They are caused by Verbs calls made directly from the PMD instead of going through the glue library. Fixes: ffc7411cabfe ("net/mlx4: fix inner RSS support for broken kernels") Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index c1cc95786..47451b651 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -469,14 +469,14 @@ mlx4_hw_rss_sup(struct ibv_context *ctx, struct ibv_pd *pd, " quirk"); hw_rss_sup &= ~IBV_RX_HASH_INNER; } else { - claim_zero(ibv_destroy_qp(qp)); + claim_zero(mlx4_glue->destroy_qp(qp)); } if (ind) - claim_zero(ibv_destroy_rwq_ind_table(ind)); + claim_zero(mlx4_glue->destroy_rwq_ind_table(ind)); if (wq) - claim_zero(ibv_destroy_wq(wq)); + claim_zero(mlx4_glue->destroy_wq(wq)); if (cq) - claim_zero(ibv_destroy_cq(cq)); + claim_zero(mlx4_glue->destroy_cq(cq)); return hw_rss_sup; }