diff mbox

[dpdk-dev,v2] igb_uio: pass MODULE_CFLAGS in new Kbuild

Message ID 20180501135033.16164-1-luca.boccassi@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Luca Boccassi May 1, 2018, 1:50 p.m. UTC 
  From: Luca Boccassi <bluca@debian.org>

With the legacy build system MODULE_CFLAGS can be set to pass compiler
flags specific for the kernel modules builds.
This is used currently by Ubuntu and Debian.
Set ccflags-y in the Kbuild to achieve the same result with Meson, and
to keep backward compatbility with older scripts.

Fixes regression in Ubuntu/Debian when the Kbuild is included in the
DKMS source package, as DKMS will pick it up silently by default if
present, causing the MODULE_CFLAGS to be ignored.

Fixes: a52f4574f798 ("igb_uio: build with meson")
Cc: stable@dpdk.org

Signed-off-by: Luca Boccassi <bluca@debian.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: forgot --signed-off, added

 kernel/linux/igb_uio/Kbuild | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Monjalon May 1, 2018, 3:11 p.m. UTC | #1 
01/05/2018 15:50, luca.boccassi@gmail.com:
> From: Luca Boccassi <bluca@debian.org>
> 
> With the legacy build system MODULE_CFLAGS can be set to pass compiler
> flags specific for the kernel modules builds.
> This is used currently by Ubuntu and Debian.
> Set ccflags-y in the Kbuild to achieve the same result with Meson, and
> to keep backward compatbility with older scripts.
> 
> Fixes regression in Ubuntu/Debian when the Kbuild is included in the
> DKMS source package, as DKMS will pick it up silently by default if
> present, causing the MODULE_CFLAGS to be ignored.
> 
> Fixes: a52f4574f798 ("igb_uio: build with meson")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/kernel/linux/igb_uio/Kbuild b/kernel/linux/igb_uio/Kbuild
index 98c98fe52..3ab85c411 100644
--- a/kernel/linux/igb_uio/Kbuild
+++ b/kernel/linux/igb_uio/Kbuild
@@ -1 +1,2 @@ 
+ccflags-y := $(MODULE_CFLAGS)
 obj-m := igb_uio.o