From patchwork Tue May 1 11:18:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 39208 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6B452A66; Tue, 1 May 2018 13:18:31 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40048.outbound.protection.outlook.com [40.107.4.48]) by dpdk.org (Postfix) with ESMTP id 9126D2583 for ; Tue, 1 May 2018 13:18:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ujz62HuM68mNUgGrfU1I04+lVa5dHLoE5u9QOso2a+A=; b=Pdi10axfC/Ex4gwaviFb4JEREz+SCZXtYpZgA8qeWjCgsy4ROpCjLu2AN8Ed5/3heId1qpT/HWVArAeUTYQMjRpfrwC8aqlBNaNQzD2kLYNdFUtX1M1zk04XFFVqRihWQ8FrZAGHLDEJcAEMXDdxM4sYrh5ZrRIi9eIlgH3ySQM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by DB7PR05MB4426.eurprd05.prod.outlook.com (2603:10a6:5:1b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.20; Tue, 1 May 2018 11:18:27 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org Date: Tue, 1 May 2018 14:18:06 +0300 Message-Id: <20180501111806.112319-2-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180501111806.112319-1-shahafs@mellanox.com> References: <20180501111806.112319-1-shahafs@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: DB6PR1001CA0006.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::16) To DB7PR05MB4426.eurprd05.prod.outlook.com (2603:10a6:5:1b::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4426; X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 3:AoFMYzsXcykxwmzWw3b5AsjZTW6sZ7iI9eo80q9XUZeOOpKMHXXbk0zqgJcYa7Dxls5C8Ou0yOz/Hnd7puuOW5rGXTW+aKdl8QVGlDDJ/IP2zw+jKD/e0ILwlwItBEpJY/q9ZsYsRYLaukA+qupZWrVwoovcCFzmcP/6hM5zkGFlYcbPWVDkTfq1YXPoMqHtsMN7HiA/yASXaOG+J/8x1IQ4ZYAmVzpagVsE6Brt30L+ui4CF7TN/kxORM+T7nI4; 25:4kS6PV4/jJl85eb21XNYLBgGNV54Oklx6docc53xHMHS9wEs+K9bdXNp4FzRJjJweZMly5uhRKLSnHm44h2X8KZ47XGQFyiddVBFJ/2l0iKOCES2guBlE4SwRqEbZB6OB5zW9e9Wz/vg+/mumitcng9MK3JgPUw9LL0aZx6YS2MhhnZfrmeFVwfpO6RWG3TMD6Jfuazfx9ZYrT4bUo4yNGLuTMhQ3NtWsBJ3dKoE4v3XRx+pExrZcAaH7wMDjWfwObU045gxUTJQKlvkHQh4rBdvwva5TAvzva6Y1GgCdUDPN9Ywt5CqJcVTkpiYhPhH8McSHyet3kigo/cXSx3KMg==; 31:iR0L6/SsOUG0lXuWFaaLHWKXMjG9dBazM5yTkJ/baZwYVfgnbWwzD975ymOBnWnvzPtYvNm+TJzduTIcGxjTmeFjV4EVkEuOPhB+iJnIkN7tGXwVD+SvTenBGJ8/VkbEcPXZ5KpaI5OzlZFRE63TRRNWUHGvPcbBpRSyTcYM8hK5wQk2ykeHd91vpLeu8lX97NJIBR7k5/0HcQKJuEQ3dQ7RL9PgakIqws/QctbdlNc= X-MS-TrafficTypeDiagnostic: DB7PR05MB4426: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 20:wMIJ4uZlu3jfANXYv975l3si5PgEnIr37nKizvflzNPFtrv90Y9HKHqV43VFqsXFRrQqFG/vO0BlXhqfzdvT67EyFXv8OE9xDDs36Gsub1BmaSxMf6Y7FJSy9wcBRiqB0qjngXuLByt1qHvPvGk0bP9lUCBRGvpcDWDGkSqZLVOXI6ibcok0MQDi8A87MdZGUSrOC7YSkB1ZpzD2bLgzc3vShxPCNdPIFWXRpMIg2MXV1YOCdjofmvrG4ZmFGxYFabdlczrh7Hq8HRFzQzV7SXJMizJ1rsLg7XZVMbZ/TXEOk/RqoBrrIS1sNCqbyV6+s6TGMXSeNwjhDZ91/eMzppuOm7LhG+cB8bW+xE1GLDTVbolOGP+65tz2D7wGcvSfKwyOVScPDtOVb+ewXprvxMpr4fIEee2gktcQFgN3kUyTj9mIG2l/w3EhvJl0qzA+JQjpC5Xeeg/QV53YZOHS6zFreObF+rN1xS2Svo80FpHmjl8L2ykOsr06QYXNun2q; 4:z0CeVLRnK+aek9JH1qT+OZaMl6MA/0a5h/QhAh4lQt6BJhIeTYcjWpo6ZzLro5EX1v/HsavokbtwPuI/U9gz7wII72laz6FIrCKrdNOJ+QLznXD3aTY9qY1v3WM2TxoxhF5JkXazOhiYtJhGKGB38+SBdr2BmLzUjmx7CImNdKid9vmlSaj0jIEE60ZpjYG3vS0S5ho+Ynsgy0DfqJthT7BsdrU0Xs9FAW/jP0Z8UkBedjdKTD7HRvJOrbBkytHEtRCrG8KTxcqffu13fGsYfQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(10201501046)(6055026)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:DB7PR05MB4426; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4426; X-Forefront-PRVS: 06592CCE58 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(396003)(39860400002)(346002)(39380400002)(199004)(189003)(25786009)(26005)(50466002)(36756003)(52116002)(186003)(386003)(55016002)(76176011)(51416003)(16526019)(7696005)(7736002)(47776003)(66066001)(81166006)(2906002)(6666003)(8676002)(81156014)(6636002)(50226002)(8936002)(21086003)(97736004)(4326008)(478600001)(105586002)(106356001)(48376002)(68736007)(53936002)(6116002)(3846002)(11346002)(2616005)(956004)(305945005)(316002)(486006)(69596002)(476003)(446003)(1076002)(5660300001)(16586007)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4426; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR05MB4426; 23:TP9dfx3rIvpJ6g62hP4f+eFT0lE3YnqbPevHkR/oI?= RG85I0KIdvfVeLBJwuEfXN2hv2CbvHSqIV+RebWZeFrBUeyHXAOkD4SAiIfK0iYUX5/R1tLPw9aQRNXO/3I+5WNqwiq4GgWxdyxUw2cbuyW0GIEVR8G3ad7q881LPx8CbjZb61csQoN+TdI47Hw9+YgHn2aLvduPrA+i6G6UypDvH+TIUGUGrKttbYZ4pgCigDgG+QEbXFEvDsZhpAkQVfAOgwDEZSirNlkS9qoT5xRMoqBWnUHj1T4hfv0T1cH8kMtdVJdTEhNkTgnmTAcRC9jMdLRO8gCt//LfHXXLSOj7Ti7enCj/x76n4HMpDvqq/VSi96vHircjEklnfw0iPUnGC6ZWl5B3m6fP9ejvnpuNFPobcIBjwCbfBWBgdzZcg9IVYy678NyZAc245ENDcQOIAKBFUqFN0MdEKhkxiBPuModerQQ7pVWzbqX7KQsMWrzYvLFTl0DH6wSR0kX7B8NXyeSWn3hYBsNBMlP+1nWIpP2YQg1Gje9dGSnWCLTlrsMjjK5hHmod28NUYedDjkB+STGHaGYX0LKmjW7O6h0t5E5MUlYDOiB0QI221yMZzeNH7G6rnJ4Uah5m7G846bYs0ktCfionSvWxWV1kRwIUtzpGE+fZPZDVGeeE0a5Q1g/KDCVByLmEPm0BPnOfXbHc9LyozRKRpzBWNQtQcLnPbAkthIzHiRaEZLiCYDuRITN0cArSw/ox2R/EkEXfrhgs684tVklvmTe2tUAN8e7E8yZYnTCnlY8gSUxQca0t+ns3lgz7FV92AZ3ap7kaNfSLvXj5Q2RfekxLMcXwqfUc0fzXx796YQh0XHb2rwyNDklv48c83t6YmVsNYSwqxa/vlUBk7eLJeEZu5kemSma8f/4EDo+C8j0nm/8iBgskLUIAaWqKFfWWyr1l6lwQ+XtiN7+5OlbObdTdydaIh6vQQ3Ymf4/qpjcnCWUmkUGlGyFXxhuyEkd8KstvV/JbKING7isMIVUdy7OUjMbOf7vggr0eZvdplvGOHg+8Hrp9TkNFEPQe618WzhoulaG1DuL3lJgn68X9WFyK+HA6z2fZXj6bEX+TzZYUtFZTiwpTh4CmhubratWaT94QVfDFzKv6wDMC2yAwfn0AzUOmpSGWlN5seVZCIK9L5TVkfWXKSVStQ42Ie+NgNrelh2a6DN2qvq8imRq5oEuPcjphrvExQ== X-Microsoft-Antispam-Message-Info: lDa1bkVeAPLMw+SXgLnSuK0h88X+U9Kb/Ypy9JrKWctk4IfZFANuJRf/s7f0S9Pi0nhrkD9URVqmiD01eodOxhT+z+zxoi1SFABYC0/ZY1weSWfV2uUNRJukJEQe2SYcWkC3uRL26o+gI4YABTf9+chBC3TALi1N/fT7Xj/CLoI1yJamd42lHkw+gI3sDrHc X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 6:S4RoWz0LUAwLJRUDqMyvogsW/CYAY2RmlsRo6WbIZzLYI56Fj08Q9lSFzZ392+CXrtnRKz/nVmvrMGWdjZJ8M2IRxy0qqB+k+GCLulFzLtg/B7883M7a0phlMDLwIUnS/7wqDtNAIUMuAPCd9W36YQlOMfKXszYuSh96DCdE2UbxWUcJTwIQ/xScoWwd27W3J2qkOk8T7jbyuJEG1TXKmjW5TrUnthfoKSyp8E3hGUhUreQDOVZRQhJ87XZO2L1NXECBQawwPLT4nhCsYPYsbXdn+7rAfM+Hblk5nRLkAJFynbcm4CZtWaOmpuIK9MAm3QROI7OH/cKWvQ9sJ8WDTZXmeDKdGQcDGdNBGihXZunVYgGBM+pOI0HQRsnqWXFYMxkILNBlf1pcRhiEuNlHj2VNCE+baoegGZ2ZLc3fgjGlFigpwCS/ssfhKyx7RJdA7ZIEl6NJVxI9HOyDn5sn2w==; 5:M+OGE7OVfNxZ8IMMHPTGf4q0gwTqB5cRNOQJNHm8DDy9JxAxSLGsfxAiCGteD+HD23VukG1QFqqr4VBpgacfhXYyuORHITcqs1YXujtVnvfmfwbzHjXjGcjYR42q8sOcurbOLnUZYcDzFaHeGhXPVqjcqvpLnoVWfs2gOta+jYs=; 24:f/V3duD4wMDJijrE9g7W0pdvNQY/TT4lsXh5/ag06E9gcKhHHPVLH4aEyZ1I20DWGta2WhJaXHfwkJJQxb7WhrdCsHaoTpVA4qqF1XMY4CM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 7:EcC+vPNtm1T+XjViHwCQFj40rMrxGceLuIscWXKjfHnHrn2Ax6yMAEYyHA2moA9tukeGYuHFz4a5uiOV3GK6+3HqYoBveqeR3bR9lkkxEjI90I8NhZOJI3ZDrhKVDPBSdf2I6twkdGXWEcg9+EmYXTY43pDz5TGIePwEkowx90uXMvg1P0INGVumfeymjUpGv8Q54dhpVbWxT6RPw2gLdJr2j/TwMO82y18gp6239xXLgsPWb3EiYFM/+csjQ9pa X-MS-Office365-Filtering-Correlation-Id: 4a287397-00c0-4838-617c-08d5af554390 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2018 11:18:27.8722 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a287397-00c0-4838-617c-08d5af554390 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4426 Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: fix probe return value polarity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" mlx5 prefixed function returns a negative errno value. the error handler on mlx5_pci_probe is doing the same. Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") Cc: nelio.laranjeiro@6wind.com Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 46cb370a29..ab860b5985 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -804,12 +804,16 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, goto error; /* Receive command fd from primary process */ err = mlx5_socket_connect(eth_dev); - if (err < 0) + if (err < 0) { + err = -err; goto error; + } /* Remap UAR for Tx queues. */ err = mlx5_tx_uar_remap(eth_dev, err); - if (err) + if (err) { + err = -err; goto error; + } /* * Ethdev pointer is still required as input since * the primary device is not accessible from the