From patchwork Tue May 1 11:18:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 39207 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D4A1729CB; Tue, 1 May 2018 13:18:19 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40043.outbound.protection.outlook.com [40.107.4.43]) by dpdk.org (Postfix) with ESMTP id 59E712583 for ; Tue, 1 May 2018 13:18:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=umwQRm7VREbi1XRtNIqJ3p9WY+xqBXm2D3jSHJHRKIQ=; b=ozWYmYipvR0ebJ+Lc5FxQMpGS0PPScZK+sRZ7C5fneGpr016TjYXisb8f8VyHv6xAihbSfzLLsWhfg+UpOzqcgyg/L5ja3m0m/oTGQwF6U28UGvbfCN+LOwa7ASI6YEf1ytgRdMETBnUtIDdZYIgUXJ5KsljGFEyuaUj2xbHilg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by DB7PR05MB4426.eurprd05.prod.outlook.com (2603:10a6:5:1b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.20; Tue, 1 May 2018 11:18:17 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org Date: Tue, 1 May 2018 14:18:05 +0300 Message-Id: <20180501111806.112319-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: DB6PR1001CA0006.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::16) To DB7PR05MB4426.eurprd05.prod.outlook.com (2603:10a6:5:1b::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4426; X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 3:vW1MrHcXlZH8TvLu/COImeD4BHn5fIuAYPMeJ2QIw/WsDRp7tvmHZolZr7wBWQenzHM8g7MuN+2u8WqE5nUkEQ79/ZHcOBSgwejCctXzC1dk+oiL1MkxLUFVohlhA/50NiCJC4DqBYW1jOr96m6l8MtPTd3LYhxEyD7TZnu7QZmwLQLLLP8CQrjjifzZ3jqqH7vSAzl545nGV9tYmFtOy7Cul8mKvOGNtJLxvl48u0I1utvuym2TJ0iPZefUQbdg; 25:0mKuDb6cFyzMdhukZRTa762WTnxE1NR+7geRTkCybEPWqps6rFy2mNzBqHnfGCD3GF+4j/YFfpsCQiwjOvYvO/OxRSsiR9MFbNbG5YwMtyIYHowF2rJqCsKrRqOlC00/Lv8TyWabO6qDsPO2Du4XysMloqFibKTdicAOaDgrx41sICyo82IEQdQnhQPPoJvvGa3igU3rQr4CWULNEwLW6j/NMeCW/PNTolubvWoaj00Z/liTB43v0PQNpJ8CfSEE7yiBY6akVTqW22andUfQ/ZiPTIkIBu6JKmp2LF49NRMczIQj7PM186ewkJV7Rt8oWnVluACqs5XvfcG1fZTx0Q==; 31:bWlmaT9Jrq1JsSiaNTrJbXVhglZxKlOf7RFRNY3Lfiwtdtiemy+Opf8QOqVPloofEQkdbG22SaL1Lz5eZdjuc9m88BvKO7WHSw6/dEpZuj7qzBRi2/nWBwafITQ3yUrIEfwQfacwmqnjKpITV7f4X/Rb8igi946+87f5T8PRf2EV5nBdCYrqm+O/vK94cz1v7q6zLswOvZtPiHRRHdqinWBSdB5CWDpryMTkxJPj57M= X-MS-TrafficTypeDiagnostic: DB7PR05MB4426: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 20:KaGDVB/ZXbR+mR5riMsfgxBLRZKIJQP7W1QQcKyeqB/CmpdfTQow3aOEqhQf4V+E0hr4gK0mLz0DvID4KNYkh0yvsedPoiJGsC2ICV9oQ8T9Ic8e+0a9Yqc6knh/nUlW7Gah2GxtcLr9LO93DoiNdXApsLJVrrJ9K1an4IbcU8N6juP4Dh2j/u0smnyiUqRhSpvT+N7/hUyp9JY3dH1obCx1vxWa/fvMZjOaUx1SimIWh62nAxth3RBUBe+KbbtZsKNb/P0s2jkioeEw/9rDQOMVuRR+C7hwFfBZxJHFvsTevZqJxKSiNHd7kULZSIkTws19iePXncINwvU0VxYkm27IE1+niGL967GG2Hvapnr8I8pQuDeipYwH9pOwtPN4smPsJpuV7Rix3elpt2tZayw0jEjkqAQbmekqf7VNrMWTHdUHx3XpzpH7SoMruc8dhG84yiwW6QrlVA4Pq3Hk3vLMa9Jwt14rHUi6VGu4JE+3nSO28ILuutXNnvKB0tcl; 4:SYf6Fl9BFsCc/yIwAa7hJipEXUrkmkRI+2DojLZ6PFo+A6SEtJMF9CqNgZ3DdhbIOXF07ATH+SRscwdOL/eeaZNuV7pkRFEgZuvv26K3twx0fzaxkR6UfOUhNRq088xDPtdBx/udWzYblMDqm5kQm8quX2hVGf3VlIlx90aQTajbE8NnEa9EyqA0YWZcnE9rDLxOlxE20Jzj5ERt3xeq6QzZXHibsNZ6RxcqXEbwzhNRUHWAsgYkLgmfruLk7x56zCbJZGvKcEeEw3G7MOMD4Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(10201501046)(6055026)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:DB7PR05MB4426; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4426; X-Forefront-PRVS: 06592CCE58 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(396003)(39860400002)(346002)(39380400002)(199004)(189003)(25786009)(26005)(50466002)(36756003)(52116002)(186003)(386003)(55016002)(51416003)(16526019)(59450400001)(7696005)(7736002)(47776003)(66066001)(81166006)(2906002)(6666003)(8676002)(81156014)(6636002)(50226002)(8936002)(21086003)(97736004)(4326008)(478600001)(105586002)(106356001)(48376002)(68736007)(53936002)(6116002)(3846002)(2616005)(956004)(305945005)(316002)(486006)(69596002)(476003)(1076002)(5660300001)(16586007)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4426; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR05MB4426; 23:0HvQpmppcpy0rAnSoJG5zUYUBTVRWlrwKFuLI0LCc?= tjeyFWQQ7Nq4uMPJDxjpC9dO8mAGUxjtJxlX7VhslPMXwr2gXsFHTqQhwHSBpu8lVhI9LBwDftpUVQOJrBdPWFahhYcRmU/NRIO8lskpE2LjzhrsTz/CQIr3uPAcEbYH7quhX7bO+8qMVM1Z3HvSLyPtDLpalXqNCmDTh6CtQYtf7SyP5OrcmQ/NjURXulhaeDxNoMjIxfC+0kS8PLbGX8aDCny4Ccr7z8p8d/0QYv/muMPY/NwmP3whJrVf26IewqghFlHB+IY2aNkhw2qD8yTA22tsgKBaOY+c1VXQyhiCBBmzLmhUOA71y345+1PhGA9Qb41gHrZXf/N9BrBgFVjj6Jb/A5JdQ9idjN/0uuR5+88tkHwTaVeJ334HwzVJNqTQ1pUKs6KM8U6Zr15x57Rwq3FK9TIx5jOP4E8Wz/KOEha1EZGxwH4LrEqFPVZo6TDFYZyaH1o7d6SP40mj4Z/w+J+1vHhFID35uh2Xy7N9T0hox2XYLsY6puv4XLrkvZe/KwMQt79+Tit0FrEZ3e8YlQ1lOl9315BO/gOPyn5h26Vb91ScKrE40WCPAdWhd5Ca8hWFNDNLh7dUdoWf4oEhzvJDMJh4vyF+UZl4+EjOfl7I2fJHZL9ohhX4UBybRaiZCseGNSy2TZyh0vNv//bIBRGTJ7oS6nDCYaVL3luLAz5LTLuqlYnnfVSs4IK2GH0k30Kt+R6p1mMjMSRPg72BcmOHwf5F5pDSSlaWD7hmqGTEJmG692XJS6AWQuS2zMJn76I1JyTlQ9G6m/UAJIdaptKgYhYtL2tIJW2gR2K533FLdL1JJtQlgnTT5Jakg7OCBVZEuCO+hitp5q1+AJkHkDX/X1ueCgt/8y5xp4xjCcNyZdNtYF7aIpzNB/66b2Cdp4+wUA5sCkw4uJbrbA3AgAa8LR3pRMAatsQLIf0gwSFspvw7z30gzrAGHjc5MViTx6CU5c8epYRF/PqqPeGrT/eK9glPk/PO+Gz1A/xsM+Xg8LDNXr74qZAwcvhomsHf/MsUIRyJFlyNf4UKafHhiY824SL4KXeo3JjbYTdf6aTlcBlueSUvdyvhEROCPjYDhr8iAkE8HDIKVctLXOuReJJVIUWngQEINx+cmJ2tWznsUl8GLuERpvQr4VlOlA= X-Microsoft-Antispam-Message-Info: ELqFFITKyuyKQvAQzbiLyBWVIyloEFNCNaS8pmURMFSRXVPS/232V3wJkFvLxhtL/arvHyoNRPoHn2I5tIGTiH0E4hGO35pqxiH8KEuhpMzpm+sJFgWw3LeERWIwF7a3cX62xyHP8oSEPheSDgd8jQOklfyk/iDmedU7SBKbqUTycazi6qBlhrzHWNOEAp59 X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 6:RX9b/4854xtI8J9MQKH2ODkuKENqFpqspo5BZkAQc8+JNuGR2LQcYhCuafKnmYfaQKTp8+g0LylO/eRZl8P4+yDadjUQbUWeRpUApBAEZO4CcvmVh4WVePSqwp9Z/TfRFCtHyO2IYSAhM7ogvF0ijd5TyKAR8MNcRuFELEu+0DiCo42xx5QRZIFw2KtocOtFAXFv6tO6Hiyfz9Q2cEF2ZUChCaMwf7suTM8PcKRYwSW9r/yEFnpaUVJ2ZiYS+HAsTjMHM3zfWQMLRklm41mSvA5tw7B0JT0K+SmuKDDRiGE13oge6xwexJCG/0yMW48axDXDSX46E1havtbdsIQI0spssE8MbLnP2/ivghhBnlpXGUtIr8OmhhHzgo5UdUpzuyVhiewVeQSbi4hM0iwMo9MyuZJbsnY2LqCOs6R9GAY60aP5K5G08M5OGfVFW0EjEWdjz9rGfnWQyBYPTA4XMQ==; 5:6CjJg+WG68p0uXqFrLKQZWnR4eE+VJQqZLImXVdyqxbfxG1gnSnV1Ul72Tqu27C3r34yasKqDnGc4sPW0VBSDqmejUBctiwcOgT81FXxDjLT3iMG8VUJwCo0YA+19Jgaat/wKWxWkVRg0fo6rsRb43d/tuejXzKAG4Ql8nXM0rE=; 24:t6u+4aIRpeHFGW7/i51/41308xHh0eBypGPds9O+Jo0+5JCvuOTHJGdCtTy1qz9vBpLXBb+BeyffwfCUP6w2ycys+yU8Pt4dWEkImw9nqtk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 7:DkbTQbSXWpeD/VSdn4bRA62RdpkszEaN5hMPboAyEMoLsKhxYR948i1fPDWCKen/8kKY2fNWBJKgCxF3CkMoRZU/hdYxE2vBtr0w706rwhRPXINXxiaWThYwAm+4d5/GcFngfVQbBEJsJo+79IhFS/G2HdepzUrb0/PzkRViaYf2GWnElZ7twrDqnpVufclGRYp/o+iayfAM91H/Kyquza4b8yt2utKi4DmXPoYTNT4OS3xg5S6fnFagso851VcJ X-MS-Office365-Filtering-Correlation-Id: 67f08127-1fd2-4cee-a618-08d5af553d44 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2018 11:18:17.3095 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 67f08127-1fd2-4cee-a618-08d5af553d44 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4426 Subject: [dpdk-dev] [PATCH 1/2] net/mlx5: fix socket connection return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Upon success, mlx5_socket_connect should return the fd descriptor of the primary process Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") Cc: nelio.laranjeiro@6wind.com Signed-off-by: Yongseok Koh Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5_socket.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 8f983061a0..46cb370a29 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -804,7 +804,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, goto error; /* Receive command fd from primary process */ err = mlx5_socket_connect(eth_dev); - if (err) + if (err < 0) goto error; /* Remap UAR for Tx queues. */ err = mlx5_tx_uar_remap(eth_dev, err); diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c index e12c4cb2e1..99297d5c43 100644 --- a/drivers/net/mlx5/mlx5_socket.c +++ b/drivers/net/mlx5/mlx5_socket.c @@ -294,7 +294,7 @@ mlx5_socket_connect(struct rte_eth_dev *dev) } ret = *fd; close(socket_fd); - return 0; + return ret; error: if (socket_fd != -1) close(socket_fd);