From patchwork Sun Apr 29 18:03:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 39161 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 82F0DA49; Sun, 29 Apr 2018 20:03:43 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40057.outbound.protection.outlook.com [40.107.4.57]) by dpdk.org (Postfix) with ESMTP id E102D3DC for ; Sun, 29 Apr 2018 20:03:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=nUEbRTznsu8f8X7gOH2k10wzQKNoIXsiz/2pq1ea2qk=; b=Q8rEUbakM32ztMsU+cbLg+U1cwdfEjo0SkWwC+LeUQ6eE1gWmbhru/1kkdLVQTxAsK+ZLKX9NnZjkCbew8iySHxXZjZcZBniKMTcc0aZP4yzmU+F/3Ig9v8TabucoB46nVDIOidy7QXiiOWpvwXT+FT/MHZ4gQiIHqB4LTneW8g= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by DB7PR05MB4426.eurprd05.prod.outlook.com (2603:10a6:5:1b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.20; Sun, 29 Apr 2018 18:03:39 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org Date: Sun, 29 Apr 2018 21:03:07 +0300 Message-Id: <20180429180308.85361-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: HE1PR07CA0018.eurprd07.prod.outlook.com (2603:10a6:7:67::28) To DB7PR05MB4426.eurprd05.prod.outlook.com (2603:10a6:5:1b::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4426; X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 3:q15yJyy7CYfSDVKz/gHGTZesuAUicCjbDWKEcbFaxnGhoQRRI1CTXubLIC4AENkNBaCkA539jGbedld2OK/C+oshQcPmIIUq3OytQGBV2Q4CTlkOzSkwe/G7zBNujl30pDofd+/m9GwYuHNaqqfHiMhS6V2m9uKtm2ZXNnu4FYxG70Zi7Tj04q/d7YUygtpKdsLbsw00qDsm9SKKhGnl4PxYW0ZMMFnGgxq/3Aig0APKHqY7TXt0AUDCwIcBNusb; 25:nkt6qs37ZvnzHtU6b1YgKZjF+rHoK2bGK6Vab23z1LTLzuJMdL9YCM4qjGc0U6WnBPb/mV74Ge/Rc5T+Wr+y2atB79Aw4NVM/TnwWv0ioBRRsk2ko59KCIgxUStvQFrRPe/THH8rhxor1fSqvaa/ONaQAkOhxHJNSwgy8cSizbyQfO8BfWHVrwwKGQQN7kFDfTcTQetXBCfgNdsQHj70iumkQ/VEZuvyeM29Mgkk/4dX4nhxRw8qM4Js5YIEh3SGvnF+WIYjxplXJ/Swdwi9wpTjl/ALXe9IVYNsCdwHQ/67/cj5BTBvD9c0lntuLRWH7ySVeZk2fdD2Yi+W1uv6Zw==; 31:UkpoPD4xebqkbvqoCsf8eD3Q5bs2MFMd6eSUE62ib8uXDt5vEadHLKpW5+SgGzuKeOWsfjLoWD4PqKtMkTl2N0Mf+Km+wHHwCnLWxR2RLU6/QTWesK9FK//Ax8bNp6VoEe1Mv9HQdKzvFeJMqDu4iki45nQX5SOlvUzfUPwv2MgJDpqyKg4/lZdGKHbPxRHvWdvFTbKcAkfevF8HKsrbyYZXEPAALnENuuR9EShaWZ4= X-MS-TrafficTypeDiagnostic: DB7PR05MB4426: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 20:jdzGGQD7mEqBvW1IHbhrfwvjnG+Q2x2iP16881DL5Dz5ipu0SGHEmRGRw6dgfhExl4iNUnZoJ04DazywxmDqYrtrJv4uqqb1ITcl08PofzSF2TZRtk5ej6/z2xNbufqWXuELKNnB5N7ro1TarDRDw70gTP2O4E/P+nmxy6Q/1EsuH/6+P71AMSzeEto3MHSleQK2JwozhkbO5lUTw9bdq05y7Pl6GMgGXsu5Cc6LnZmuJZyfYIyYrSQjwPL3eURzGpKz3n7iIPriAfXdQrEKuW0lWi3+rI3dtHlIlAXGFAeGVKMoC2UsUif4gL/X/f3kmB4bEZ3MCRyG4jrbyzEShEWz6pNbwGZ9+kUNTTvJuQBHVcSVeEfrSltgID2Js3UgERBvtP3AkYRdQYbueWbwtjEPyqbieidjKKqr/KYqjy1JrMR4sneFLQE6XJ4pnt5bbBxAQ8zLQC4MRdjJK0VXAiricFxrS/6MbFzJr88UgS2HQ9bpw3paItCbBcrJyhMZ; 4:NsocAOdeUm6oGtWlF8k1qRcN1CPE/oOqNtuiO52sffS4Yovx+GnzT4FM6MBX70NE5/LekKTQW8dBNmmFUzMKsUlN9h1n2qR47SdJcXy8OWcqql0a2AhC2CfotI1EuNMZG9URp9SBNYa5xR1xmW0Wu7lqQg71lDfF8Lu/jfcApOW8DIDKkRQ9VfRgrtTAz7dQy6WoE55h3P+s2QxSeBx/ob+A63LrdamBjNHg208YWB21jK58qtQnTe98LY6/nkpRES4mlzS8r+E71vo6gN2zTA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:DB7PR05MB4426; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4426; X-Forefront-PRVS: 0657D528EC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(396003)(39380400002)(39860400002)(199004)(189003)(66066001)(51416003)(69596002)(52116002)(8936002)(81156014)(81166006)(7696005)(21086003)(59450400001)(86362001)(55016002)(16586007)(50466002)(16526019)(305945005)(8676002)(386003)(53936002)(48376002)(186003)(68736007)(26005)(50226002)(106356001)(47776003)(36756003)(105586002)(316002)(6636002)(6666003)(5660300001)(2906002)(97736004)(1076002)(6116002)(3846002)(7736002)(478600001)(4326008)(25786009)(486006)(476003)(2616005)(956004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4426; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR05MB4426; 23:xcBEqIbOgXMfJQ5XGBlTPmxr3NGIle/DtY0TXWzM9?= +qqNlmnbZVtLKbKoWk8bDfmFJBSV2zBINgjlnT7U49qaMqmWYrhgF9oOyp0hOCX42jW+C35epqTqyLH4sdA7fhDaLgLpk085PgdleGVCngBDll8nZx8c6tdI9svYvDcqKR3eNY2FK4pLvzAMEcp9uvxCFyWnFKKBNB5D0iD2aU6KEXoC+aLbnKy8aK8lNHY2hz0Xwdd7vYzL9pjSxsGLIaDeB1DQuQfvVhoQu6MieOqgaeF4S+ZFZxEiRMrxSkEGQtszcMBW0sjC/EzaVlOLhy6cJ8sQS1TzpZ5UvFDU8BWZ3qK6pgsHc4DBxchqUO0EzWZzvH/mb03Y6s/XFH8GkhZOzxH4kQ82e1cjcHTkkg713LOCEnH8NXFFYx9TaFg4RUyvsmREcqeqV0g1ACwsKUXqatcBWuzQCgK39JVC28GkbGQSMA4CK4GGvho5g7yu6KCb48uE/7k5JwP++Y1ksavAu/OzL3EemhyjtYch7eymiadBETS8b8wG6lARJVlKkb0VKFAD2yI/C88kliYyBo76jVkCb9pcMbu1ndxq9JGhSzErbNQSwewgNgSz7jqUfmgvL6IpOucqX2EBvZCjVW5CoELw0BrIW6x6BPQltnj0xYcbK3pEIpHQVeSvLbbOuuUOmKnHsKvgurakts4ce8HlVw23nHVDWahgiY6JADrKi2wsSevYtzkYoWdjAeT5j5zjbTpXW+zqNJQOaCe3/Cl+qm3yr72N4u5A/WMrZGTMVB1HJRN6lQlV9EmarjqYApYJj4lo5FmS1IKPPzDEzdulYQTiaKtBN43JghvXHOQdbFQhQ2OSBgmxOIH3HcF10kk8mQvEbfHfNiFl9z2/9MZ7zuxEHdm/oGIAI/VhsroCfPymhtQSd0MG17sOMJ/qk73lkyUO4J6xYTBbUZAnNJHLd24cROqaiZXcDmlZ1xqyg2j2/8BpddxEnVqb0/4XR5UXIuYCeSVD8qOAbb/3asfQcoUswTA15Q3yY44mPvoj2MXZ6tFCdCgnL7ZIHUwfHeZ6QMjL0b1D0IKxSqG/0JHVk43zbrFoj13hR4lK4EHg0Ap/U0zZTSXNIG1BnGfA4U5IPF8q6Xzmwq53iy+DdFbZrZoSreQcWEOIuf6A4jdj0n1C4YDJcc/ff1hZlvJOa4= X-Microsoft-Antispam-Message-Info: 6q/VWqQLnIOQWLoJmI9DlGLZnnUZVZ0F3Y+z26iBx2KUavtrvx0dTXIUNBO0GliyzjztLwbTTrqfSYon3Xy2ZrmiC+d6Opu7RH4uYwMIBU67x6mam5qlbEe9C2xlLFNGqXz1KkZ3LVjgX29j7uLjUd3H+Ucyr8TdsGF5L7rzGA4h5fL+i28+t+M+HxIYGrJN X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 6:KMa8HVp2l0iBmPYkd+zB64NLo9xS43gga0CLxM8JN29wuVm4YJ14VzMVV2HrkJMKuw5nhmAcyRiBkVVZs2I/dOh4UGdFSommVqTQqkxqhDHHMfCtJTaxqtHS1NzNSfof8u2F9qrSR3Ex7nKTRiMWXXD/c36nMGaz2arOcBB/LOXFeNh25A8Hh1/5yIyQGsdMe3JewSchJWiiWTmATwpRWXLx/3VCrkaCRv+ydBcAE7+8cX7cdnzfB4UhXOnn8umwxhBREF1hEqG4BB3a73CR/fJw4X6MmXUn1GADDPl6ejIb+YovehypDIIJ8rDLRAC4tIW7e+tEfrnBBDhKfuXT3oWZxnGTHdBDzQT58tVHuJaQWaUh2hANWRv6c5GujaKECI2Gme2jEJQ9vRn6TibrcIS4xQucAzOLMPNNS4nRyVuszcGtXZamU7W4wv4Ii4DoP67X03Q8hmIWql9mVGcKvQ==; 5:/kktzjAtGwRSFQfyBJ6GCR+0CThnuLbVySA2cy9BoimlDvqiG4yb6MnKy3PMUYl+XZHLP81g4pkuRJ0E6WEMbeOD6b92cdOx4JLzveIBhCZusN0eZTww3M2JOOMcMWXAU8GawklobvtmqbhpWa+/vNaftZAxGCFX0yObfA81hmA=; 24:QcjWWYV1KOrycUGDP6xWAg0jST66EmLyckBOWEbTgA5WG5lKWXlLeZtmCwL/0VncGhpJj67w900RqoBymerF6i2GYfQGFWTRlM+85O1o77Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 7:jHH4/pePfBbByrLxMM8s/FHH7fI//lUzgNzvtTau6GmrZ0LBAw/NEsbqvWl/vxoBohC8upG3WPNABM+QGsFETjjxC65J8n+8uOWtqkWJwTbbb/TLmGlOFKJaP21QNL7EokQd+NTfoikR3QJb5PEhViXZCQpgTM5aMlJ5AszpaU8Hs8kmZ+wMLawhX04qBU+IZzvNeB8HDPmWxfXI9juRB5ZfKx0qUrJSY7RWs8CICACPjjoOcNULKapNeo8hWSs6 X-MS-Office365-Filtering-Correlation-Id: 80f1af6b-6f5c-44fc-b5b9-08d5adfb89d7 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2018 18:03:39.3336 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 80f1af6b-6f5c-44fc-b5b9-08d5adfb89d7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4426 Subject: [dpdk-dev] [PATCH 1/2] net/mlx5: fix ethtool link setting call order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" According to ethtool_link_setting API recommendation ETHTOOL_GLINKSETTINGS should be called before ETHTOOL_GSET as the later one deprecated. Fixes: f47ba80080ab ("net/mlx5: remove kernel version check") Cc: nelio.laranjeiro@6wind.com Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 746b94f734..588d4ba627 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -697,9 +697,9 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) time_t start_time = time(NULL); do { - ret = mlx5_link_update_unlocked_gset(dev, &dev_link); + ret = mlx5_link_update_unlocked_gs(dev, &dev_link); if (ret) - ret = mlx5_link_update_unlocked_gs(dev, &dev_link); + ret = mlx5_link_update_unlocked_gset(dev, &dev_link); if (ret == 0) break; /* Handle wait to complete situation. */