[dpdk-dev,v2] net/i40e: fix missing some offload capabilities
Checks
Commit Message
MULTI_SEGS and JUMBO_FRAME offload capability
should be exposed both VF and PF since i40e
does support it.
Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
rework fix line
---
drivers/net/i40e/i40e_ethdev.c | 3 ++-
drivers/net/i40e/i40e_ethdev_vf.c | 6 ++++--
2 files changed, 6 insertions(+), 3 deletions(-)
Comments
> -----Original Message-----
> From: Wu, Yanglong
> Sent: Saturday, April 28, 2018 5:37 PM
> To: dev@dpdk.org
> Cc: Zhang, Helin <helin.zhang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Dai, Wei <wei.dai@intel.com>; Wu, Yanglong
> <yanglong.wu@intel.com>
> Subject: [PATCH v2] net/i40e: fix missing some offload capabilities
>
> MULTI_SEGS and JUMBO_FRAME offload capability should be exposed both
> VF and PF since i40e does support it.
>
> Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
> Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Wednesday, May 2, 2018 1:40 PM
> To: Wu, Yanglong; dev@dpdk.org
> Cc: Zhang, Helin; Dai, Wei
> Subject: RE: [PATCH v2] net/i40e: fix missing some offload capabilities
>
> > -----Original Message-----
> > From: Wu, Yanglong
> > Sent: Saturday, April 28, 2018 5:37 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Helin <helin.zhang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Dai, Wei <wei.dai@intel.com>; Wu, Yanglong
> > <yanglong.wu@intel.com>
> > Subject: [PATCH v2] net/i40e: fix missing some offload capabilities
> >
> > MULTI_SEGS and JUMBO_FRAME offload capability should be exposed both
> > VF and PF since i40e does support it.
> >
> > Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
> > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
> > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
@@ -3316,7 +3316,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
DEV_TX_OFFLOAD_GRE_TNL_TSO |
DEV_TX_OFFLOAD_IPIP_TNL_TSO |
- DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+ DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+ DEV_TX_OFFLOAD_MULTI_SEGS;
dev_info->dev_capa =
RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |
RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP;
@@ -2200,7 +2200,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
DEV_RX_OFFLOAD_TCP_CKSUM |
DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
DEV_RX_OFFLOAD_CRC_STRIP |
- DEV_RX_OFFLOAD_SCATTER;
+ DEV_RX_OFFLOAD_SCATTER |
+ DEV_RX_OFFLOAD_JUMBO_FRAME;
dev_info->tx_queue_offload_capa = 0;
dev_info->tx_offload_capa =
@@ -2215,7 +2216,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
DEV_TX_OFFLOAD_GRE_TNL_TSO |
DEV_TX_OFFLOAD_IPIP_TNL_TSO |
- DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+ DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+ DEV_TX_OFFLOAD_MULTI_SEGS;
dev_info->default_rxconf = (struct rte_eth_rxconf) {
.rx_thresh = {